Diff of the two buildlogs: -- --- b1/build.log 2024-11-14 05:38:22.731658750 +0000 +++ b2/build.log 2024-11-14 05:39:13.725832262 +0000 @@ -1,6 +1,6 @@ I: pbuilder: network access will be disabled during build -I: Current time: Wed Nov 13 17:37:22 -12 2024 -I: pbuilder-time-stamp: 1731562642 +I: Current time: Thu Dec 18 02:01:24 +14 2025 +I: pbuilder-time-stamp: 1765972884 I: Building the build Environment I: extracting base tarball [/var/cache/pbuilder/trixie-reproducible-base.tgz] I: copying local configuration @@ -35,53 +35,85 @@ dpkg-source: info: applying 2018.patch I: Not using root during the build. I: Installing the build-deps -I: user script /srv/workspace/pbuilder/29985/tmp/hooks/D02_print_environment starting +I: user script /srv/workspace/pbuilder/30999/tmp/hooks/D01_modify_environment starting +debug: Running on infom08-i386. +I: Changing host+domainname to test build reproducibility +I: Adding a custom variable just for the fun of it... +I: Changing /bin/sh to bash +'/bin/sh' -> '/bin/bash' +lrwxrwxrwx 1 root root 9 Dec 17 12:01 /bin/sh -> /bin/bash +I: Setting pbuilder2's login shell to /bin/bash +I: Setting pbuilder2's GECOS to second user,second room,second work-phone,second home-phone,second other +I: user script /srv/workspace/pbuilder/30999/tmp/hooks/D01_modify_environment finished +I: user script /srv/workspace/pbuilder/30999/tmp/hooks/D02_print_environment starting I: set - BUILDDIR='/build/reproducible-path' - BUILDUSERGECOS='first user,first room,first work-phone,first home-phone,first other' - BUILDUSERNAME='pbuilder1' - BUILD_ARCH='i386' - DEBIAN_FRONTEND='noninteractive' - DEB_BUILD_OPTIONS='buildinfo=+all reproducible=+all parallel=6 ' - DISTRIBUTION='trixie' - HOME='/root' - HOST_ARCH='i386' + BASH=/bin/sh + BASHOPTS=checkwinsize:cmdhist:complete_fullquote:extquote:force_fignore:globasciiranges:globskipdots:hostcomplete:interactive_comments:patsub_replacement:progcomp:promptvars:sourcepath + BASH_ALIASES=() + BASH_ARGC=() + BASH_ARGV=() + BASH_CMDS=() + BASH_LINENO=([0]="12" [1]="0") + BASH_LOADABLES_PATH=/usr/local/lib/bash:/usr/lib/bash:/opt/local/lib/bash:/usr/pkg/lib/bash:/opt/pkg/lib/bash:. + BASH_SOURCE=([0]="/tmp/hooks/D02_print_environment" [1]="/tmp/hooks/D02_print_environment") + BASH_VERSINFO=([0]="5" [1]="2" [2]="32" [3]="1" [4]="release" [5]="i686-pc-linux-gnu") + BASH_VERSION='5.2.32(1)-release' + BUILDDIR=/build/reproducible-path + BUILDUSERGECOS='second user,second room,second work-phone,second home-phone,second other' + BUILDUSERNAME=pbuilder2 + BUILD_ARCH=i386 + DEBIAN_FRONTEND=noninteractive + DEB_BUILD_OPTIONS='buildinfo=+all reproducible=+all parallel=5 ' + DIRSTACK=() + DISTRIBUTION=trixie + EUID=0 + FUNCNAME=([0]="Echo" [1]="main") + GROUPS=() + HOME=/root + HOSTNAME=i-capture-the-hostname + HOSTTYPE=i686 + HOST_ARCH=i386 IFS=' ' - INVOCATION_ID='f40f1ad2b98943098d2cf1f72ff49664' - LANG='C' - LANGUAGE='en_US:en' - LC_ALL='C' - LD_LIBRARY_PATH='/usr/lib/libeatmydata' - LD_PRELOAD='libeatmydata.so' - MAIL='/var/mail/root' - OPTIND='1' - PATH='/usr/sbin:/usr/bin:/sbin:/bin:/usr/games' - PBCURRENTCOMMANDLINEOPERATION='build' - PBUILDER_OPERATION='build' - PBUILDER_PKGDATADIR='/usr/share/pbuilder' - PBUILDER_PKGLIBDIR='/usr/lib/pbuilder' - PBUILDER_SYSCONFDIR='/etc' - PPID='29985' - PS1='# ' - PS2='> ' + INVOCATION_ID=3372eaae354b4681a325967d57ef094e + LANG=C + LANGUAGE=de_CH:de + LC_ALL=C + LD_LIBRARY_PATH=/usr/lib/libeatmydata + LD_PRELOAD=libeatmydata.so + MACHTYPE=i686-pc-linux-gnu + MAIL=/var/mail/root + OPTERR=1 + OPTIND=1 + OSTYPE=linux-gnu + PATH=/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/i/capture/the/path + PBCURRENTCOMMANDLINEOPERATION=build + PBUILDER_OPERATION=build + PBUILDER_PKGDATADIR=/usr/share/pbuilder + PBUILDER_PKGLIBDIR=/usr/lib/pbuilder + PBUILDER_SYSCONFDIR=/etc + PIPESTATUS=([0]="0") + POSIXLY_CORRECT=y + PPID=30999 PS4='+ ' - PWD='/' - SHELL='/bin/bash' - SHLVL='2' - SUDO_COMMAND='/usr/bin/timeout -k 18.1h 18h /usr/bin/ionice -c 3 /usr/bin/nice /usr/sbin/pbuilder --build --configfile /srv/reproducible-results/rbuild-debian/r-b-build.VCH2S8C6/pbuilderrc_mbi6 --distribution trixie --hookdir /etc/pbuilder/first-build-hooks --debbuildopts -b --basetgz /var/cache/pbuilder/trixie-reproducible-base.tgz --buildresult /srv/reproducible-results/rbuild-debian/r-b-build.VCH2S8C6/b1 --logfile b1/build.log ranger_1.9.3-5.dsc' - SUDO_GID='111' - SUDO_UID='104' - SUDO_USER='jenkins' - TERM='unknown' - TZ='/usr/share/zoneinfo/Etc/GMT+12' - USER='root' - _='/usr/bin/systemd-run' + PWD=/ + SHELL=/bin/bash + SHELLOPTS=braceexpand:errexit:hashall:interactive-comments:posix + SHLVL=3 + SUDO_COMMAND='/usr/bin/timeout -k 24.1h 24h /usr/bin/ionice -c 3 /usr/bin/nice -n 11 /usr/bin/unshare --uts -- /usr/sbin/pbuilder --build --configfile /srv/reproducible-results/rbuild-debian/r-b-build.VCH2S8C6/pbuilderrc_kh5L --distribution trixie --hookdir /etc/pbuilder/rebuild-hooks --debbuildopts -b --basetgz /var/cache/pbuilder/trixie-reproducible-base.tgz --buildresult /srv/reproducible-results/rbuild-debian/r-b-build.VCH2S8C6/b2 --logfile b2/build.log ranger_1.9.3-5.dsc' + SUDO_GID=111 + SUDO_UID=104 + SUDO_USER=jenkins + TERM=unknown + TZ=/usr/share/zoneinfo/Etc/GMT-14 + UID=0 + USER=root + _='I: set' I: uname -a - Linux infom07-i386 6.1.0-27-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.115-1 (2024-11-01) x86_64 GNU/Linux + Linux i-capture-the-hostname 6.10.11+bpo-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.10.11-1~bpo12+1 (2024-10-03) x86_64 GNU/Linux I: ls -l /bin - lrwxrwxrwx 1 root root 7 Aug 4 21:30 /bin -> usr/bin -I: user script /srv/workspace/pbuilder/29985/tmp/hooks/D02_print_environment finished + lrwxrwxrwx 1 root root 7 Aug 4 2024 /bin -> usr/bin +I: user script /srv/workspace/pbuilder/30999/tmp/hooks/D02_print_environment finished -> Attempting to satisfy build-dependencies -> Creating pbuilder-satisfydepends-dummy package Package: pbuilder-satisfydepends-dummy @@ -213,7 +245,7 @@ Get: 82 http://deb.debian.org/debian trixie/main i386 python3-pluggy all 1.5.0-1 [26.9 kB] Get: 83 http://deb.debian.org/debian trixie/main i386 python3-pytest all 8.3.3-1 [249 kB] Get: 84 http://deb.debian.org/debian trixie/main i386 shellcheck i386 0.10.0-1 [7542 kB] -Fetched 38.4 MB in 2s (17.3 MB/s) +Fetched 38.4 MB in 0s (97.8 MB/s) debconf: delaying package configuration, since apt-utils is not installed Selecting previously unselected package libpython3.12-minimal:i386. (Reading database ... (Reading database ... 5% (Reading database ... 10% (Reading database ... 15% (Reading database ... 20% (Reading database ... 25% (Reading database ... 30% (Reading database ... 35% (Reading database ... 40% (Reading database ... 45% (Reading database ... 50% (Reading database ... 55% (Reading database ... 60% (Reading database ... 65% (Reading database ... 70% (Reading database ... 75% (Reading database ... 80% (Reading database ... 85% (Reading database ... 90% (Reading database ... 95% (Reading database ... 100% (Reading database ... 19958 files and directories currently installed.) @@ -500,8 +532,8 @@ Setting up tzdata (2024b-3) ... Current default time zone: 'Etc/UTC' -Local time is now: Thu Nov 14 05:37:45 UTC 2024. -Universal Time is now: Thu Nov 14 05:37:45 UTC 2024. +Local time is now: Wed Dec 17 12:01:40 UTC 2025. +Universal Time is now: Wed Dec 17 12:01:40 UTC 2025. Run 'dpkg-reconfigure tzdata' if you wish to change it. Setting up autotools-dev (20220109.1) ... @@ -578,7 +610,11 @@ Building tag database... -> Finished parsing the build-deps I: Building the package -I: Running cd /build/reproducible-path/ranger-1.9.3/ && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games" HOME="/nonexistent/first-build" dpkg-buildpackage -us -uc -b && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games" HOME="/nonexistent/first-build" dpkg-genchanges -S > ../ranger_1.9.3-5_source.changes +I: user script /srv/workspace/pbuilder/30999/tmp/hooks/A99_set_merged_usr starting +Not re-configuring usrmerge for trixie +I: user script /srv/workspace/pbuilder/30999/tmp/hooks/A99_set_merged_usr finished +hostname: Name or service not known +I: Running cd /build/reproducible-path/ranger-1.9.3/ && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/i/capture/the/path" HOME="/nonexistent/second-build" dpkg-buildpackage -us -uc -b && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/i/capture/the/path" HOME="/nonexistent/second-build" dpkg-genchanges -S > ../ranger_1.9.3-5_source.changes dpkg-buildpackage: info: source package ranger dpkg-buildpackage: info: source version 1.9.3-5 dpkg-buildpackage: info: source distribution unstable @@ -590,9 +626,9 @@ debian/rules override_dh_auto_clean make[1]: Entering directory '/build/reproducible-path/ranger-1.9.3' dh_auto_clean - make -j6 clean + make -j5 clean make[2]: Entering directory '/build/reproducible-path/ranger-1.9.3' -/bin/sh: 1: python: not found +/bin/sh: line 1: python: command not found find ranger -regex .\*\.py[co]\$ -delete find ranger -depth -name __pycache__ -type d -exec rm -r -- {} \; make[2]: Leaving directory '/build/reproducible-path/ranger-1.9.3' @@ -615,250 +651,44 @@ debian/rules override_dh_auto_test make[1]: Entering directory '/build/reproducible-path/ranger-1.9.3' dh_auto_test -- PYTHON=python3 - make -j6 test PYTHON=python3 + make -j5 test PYTHON=python3 make[2]: Entering directory '/build/reproducible-path/ranger-1.9.3' Running pylint... -pylint ./ranger/ext ./ranger/colorschemes ./ranger/core ./ranger/gui ./ranger/container ./ranger/api ./ranger/__init__.py ./doc/tools/print_colors.py ./doc/tools/performance_test.py ./doc/tools/print_keys.py ./doc/tools/convert_papermode_to_metadata.py ./examples/plugin_hello_world.py ./examples/plugin_new_sorting_method.py ./examples/plugin_pmount.py ./examples/plugin_fasd_add.py ./examples/plugin_file_filter.py ./examples/plugin_linemode.py ./examples/plugin_pmount_dynamic.py ./examples/plugin_chmod_keybindings.py ./examples/plugin_ipc.py ./examples/plugin_avfs.py ./examples/plugin_new_macro.py ./ranger.py ./setup.py ./tests +pylint ./ranger/core ./ranger/api ./ranger/container ./ranger/gui ./ranger/ext ./ranger/colorschemes ./ranger/__init__.py ./doc/tools/performance_test.py ./doc/tools/convert_papermode_to_metadata.py ./doc/tools/print_keys.py ./doc/tools/print_colors.py ./examples/plugin_file_filter.py ./examples/plugin_ipc.py ./examples/plugin_avfs.py ./examples/plugin_linemode.py ./examples/plugin_chmod_keybindings.py ./examples/plugin_fasd_add.py ./examples/plugin_new_macro.py ./examples/plugin_pmount_dynamic.py ./examples/plugin_hello_world.py ./examples/plugin_pmount.py ./examples/plugin_new_sorting_method.py ./ranger.py ./setup.py ./tests Running flake8... -flake8 ./ranger/ext ./ranger/colorschemes ./ranger/core ./ranger/gui ./ranger/container ./ranger/api ./ranger/__init__.py ./doc/tools/print_colors.py ./doc/tools/performance_test.py ./doc/tools/print_keys.py ./doc/tools/convert_papermode_to_metadata.py ./examples/plugin_hello_world.py ./examples/plugin_new_sorting_method.py ./examples/plugin_pmount.py ./examples/plugin_fasd_add.py ./examples/plugin_file_filter.py ./examples/plugin_linemode.py ./examples/plugin_pmount_dynamic.py ./examples/plugin_chmod_keybindings.py ./examples/plugin_ipc.py ./examples/plugin_avfs.py ./examples/plugin_new_macro.py ./ranger.py ./setup.py ./tests ./ranger/config +flake8 ./ranger/core ./ranger/api ./ranger/container ./ranger/gui ./ranger/ext ./ranger/colorschemes ./ranger/__init__.py ./doc/tools/performance_test.py ./doc/tools/convert_papermode_to_metadata.py ./doc/tools/print_keys.py ./doc/tools/print_colors.py ./examples/plugin_file_filter.py ./examples/plugin_ipc.py ./examples/plugin_avfs.py ./examples/plugin_linemode.py ./examples/plugin_chmod_keybindings.py ./examples/plugin_fasd_add.py ./examples/plugin_new_macro.py ./examples/plugin_pmount_dynamic.py ./examples/plugin_hello_world.py ./examples/plugin_pmount.py ./examples/plugin_new_sorting_method.py ./ranger.py ./setup.py ./tests ./ranger/config Running doctests... Running py.test tests... -Checking completeness of man page... py.test-3 tests -Testing ranger/ext/keybinding_parser.py... +Checking completeness of man page... +Testing ranger/api/commands.py... +Testing ranger/gui/ansi.py... Running shellcheck... sed '2,$s/^\(\s*\)#/\1/' ./ranger/data/scope.sh | shellcheck -a - -Testing ranger/ext/direction.py... -Testing ranger/ext/iter_tools.py... -Testing ranger/ext/lazy_property.py... +Testing ranger/gui/widgets/console.py... ============================= test session starts ============================== platform linux -- Python 3.12.7, pytest-8.3.3, pluggy-1.5.0 rootdir: /build/reproducible-path/ranger-1.9.3 plugins: typeguard-4.4.1 collected 7 items -tests/ranger/container/test_bookmarks.py Testing ranger/ext/signals.py... -.. [ 28%] +tests/ranger/container/test_bookmarks.py .. [ 28%] tests/ranger/container/test_container.py .. [ 57%] tests/ranger/container/test_fsobject.py .. [ 85%] -tests/ranger/core/test_main.py . [100%] +tests/ranger/core/test_main.py . [100%]Testing ranger/ext/signals.py... -============================== 7 passed in 0.14s =============================== + +============================== 7 passed in 0.06s =============================== +Testing ranger/ext/direction.py... +Testing ranger/ext/keybinding_parser.py... +Testing ranger/ext/lazy_property.py... +Testing ranger/ext/widestring.py... +Testing ranger/ext/iter_tools.py... Testing ranger/ext/rifle.py... Testing ranger/ext/human_readable.py... -Testing ranger/ext/widestring.py... -Testing ranger/gui/widgets/console.py... -Testing ranger/gui/ansi.py... -Testing ranger/api/commands.py... ************* Module /build/reproducible-path/ranger-1.9.3/.pylintrc .pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'locally-enabled' (unknown-option-value) .pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'redefined-variable-type' (unknown-option-value) -************* Module ranger.ext.keybinding_parser -ranger/ext/keybinding_parser.py:93:8: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from) -ranger/ext/keybinding_parser.py:107:24: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from) -ranger/ext/keybinding_parser.py:142:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/keybinding_parser.py:143:11: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/keybinding_parser.py:172:54: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) -ranger/ext/keybinding_parser.py:181:38: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) -ranger/ext/keybinding_parser.py:196:45: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) -ranger/ext/keybinding_parser.py:198:41: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) -ranger/ext/keybinding_parser.py:209:16: W0707: Consider explicitly re-raising using 'except KeyError as exc' and 'raise KeyError("Tried to copy the keybinding `%s', but it was not found." % source) from exc' (raise-missing-from) -ranger/ext/keybinding_parser.py:209:31: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/keybinding_parser.py:220:0: R0205: Class 'KeyBuffer' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -ranger/ext/keybinding_parser.py:242:8: C2801: Unnecessarily calls dunder method __init__. Instantiate class directly. (unnecessary-dunder-call) -************* Module ranger.ext.direction -ranger/ext/direction.py:115:4: R0917: Too many positional arguments (8/5) (too-many-positional-arguments) -ranger/ext/direction.py:168:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) -************* Module ranger.ext.iter_tools -ranger/ext/iter_tools.py:23:12: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from) -************* Module ranger.ext.img_display -ranger/ext/img_display.py:18:0: W4901: Deprecated module 'imghdr' (deprecated-module) -ranger/ext/img_display.py:103:0: R0205: Class 'ImageDisplayer' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -ranger/ext/img_display.py:108:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) -ranger/ext/img_display.py:110:8: W0107: Unnecessary pass statement (unnecessary-pass) -ranger/ext/img_display.py:114:8: W0107: Unnecessary pass statement (unnecessary-pass) -ranger/ext/img_display.py:118:8: W0107: Unnecessary pass statement (unnecessary-pass) -ranger/ext/img_display.py:140:23: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -ranger/ext/img_display.py:150:32: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/img_display.py:164:22: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -ranger/ext/img_display.py:174:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) -ranger/ext/img_display.py:179:8: W0706: The except handler raises immediately (try-except-raise) -ranger/ext/img_display.py:186:12: C0415: Import outside toplevel (time.sleep) (import-outside-toplevel) -ranger/ext/img_display.py:201:14: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/img_display.py:220:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) -ranger/ext/img_display.py:236:14: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/img_display.py:259:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/img_display.py:284:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) -ranger/ext/img_display.py:309:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/img_display.py:320:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) -ranger/ext/img_display.py:347:22: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -ranger/ext/img_display.py:398:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) -ranger/ext/img_display.py:479:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) -ranger/ext/img_display.py:491:14: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/img_display.py:593:16: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/img_display.py:599:12: C0415: Import outside toplevel (PIL.Image) (import-outside-toplevel) -ranger/ext/img_display.py:602:12: W0707: Consider explicitly re-raising using 'except ImportError as exc' and 'raise ImageDisplayError('Image previews in kitty require PIL (pillow)') from exc' (raise-missing-from) -ranger/ext/img_display.py:613:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) -ranger/ext/img_display.py:639:11: R1714: Consider merging these comparisons with 'in' by using 'image.mode not in ('RGB', 'RGBA')'. Use a set instead if elements are hashable. (consider-using-in) -ranger/ext/img_display.py:673:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) -ranger/ext/img_display.py:676:36: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/img_display.py:693:32: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/img_display.py:737:23: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -ranger/ext/img_display.py:746:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) -************* Module ranger.ext.lazy_property -ranger/ext/lazy_property.py:8:0: R0205: Class 'lazy_property' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -************* Module ranger.ext.signals -ranger/ext/signals.py:87:0: R0205: Class 'SignalHandler' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -ranger/ext/signals.py:105:0: R0205: Class 'SignalDispatcher' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -ranger/ext/signals.py:109:24: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) -ranger/ext/signals.py:116:24: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) -ranger/ext/signals.py:118:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) -ranger/ext/signals.py:165:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) -************* Module ranger.ext.popen_forked -ranger/ext/popen_forked.py:21:26: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -ranger/ext/popen_forked.py:21:26: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) -ranger/ext/popen_forked.py:22:46: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -ranger/ext/popen_forked.py:22:46: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) -ranger/ext/popen_forked.py:23:8: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -************* Module ranger.ext.spawn -ranger/ext/spawn.py:34:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) -ranger/ext/spawn.py:35:22: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -************* Module ranger.ext.shell_escape -ranger/ext/shell_escape.py:12:12: R1717: Consider using a dictionary comprehension (consider-using-dict-comprehension) -************* Module ranger.ext.rifle -ranger/ext/rifle.py:50:8: C0415: Import outside toplevel (stat.S_IXOTH, stat.S_IFREG) (import-outside-toplevel) -ranger/ext/rifle.py:83:30: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -ranger/ext/rifle.py:83:30: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) -ranger/ext/rifle.py:84:50: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -ranger/ext/rifle.py:84:50: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) -ranger/ext/rifle.py:85:12: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -ranger/ext/rifle.py:116:0: R0205: Class 'Rifle' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -ranger/ext/rifle.py:163:15: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) -ranger/ext/rifle.py:163:15: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -ranger/ext/rifle.py:219:12: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) -ranger/ext/rifle.py:254:8: C0415: Import outside toplevel (mimetypes) (import-outside-toplevel) -ranger/ext/rifle.py:261:22: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -ranger/ext/rifle.py:266:30: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -ranger/ext/rifle.py:280:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/rifle.py:312:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) -ranger/ext/rifle.py:333:12: R1723: Unnecessary "else" after "break", remove the "else" and de-indent the code inside it (no-else-break) -ranger/ext/rifle.py:344:22: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/rifle.py:351:37: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/rifle.py:353:37: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/rifle.py:430:63: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/rifle.py:442:30: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -ranger/ext/rifle.py:463:12: C0415: Import outside toplevel (ranger) (import-outside-toplevel) -ranger/ext/rifle.py:470:25: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/rifle.py:481:4: C0415: Import outside toplevel (optparse.OptionParser) (import-outside-toplevel) -ranger/ext/rifle.py:509:29: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/rifle.py:510:12: W0707: Consider explicitly re-raising using 'raise SystemExit(1) from ex' (raise-missing-from) -ranger/ext/rifle.py:512:29: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/rifle.py:532:22: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/rifle.py:537:22: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/rifle.py:523:18: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -************* Module ranger.ext.human_readable -ranger/ext/human_readable.py:35:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/human_readable.py:37:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/human_readable.py:39:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/human_readable.py:41:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/human_readable.py:43:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/human_readable.py:45:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/human_readable.py:47:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/human_readable.py:49:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/human_readable.py:51:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/human_readable.py:53:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/human_readable.py:55:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/human_readable.py:65:4: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) -ranger/ext/human_readable.py:77:4: R0205: Class 'SettingsAwareMock' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -ranger/ext/human_readable.py:78:8: R0205: Class 'settings' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -************* Module ranger.ext.shutil_generatorized -ranger/ext/shutil_generatorized.py:19:4: E0601: Using variable 'WindowsError' before assignment (used-before-assignment) -ranger/ext/shutil_generatorized.py:121:20: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/shutil_generatorized.py:132:39: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/shutil_generatorized.py:136:12: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from) -ranger/ext/shutil_generatorized.py:156:8: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from) -ranger/ext/shutil_generatorized.py:161:0: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) -ranger/ext/shutil_generatorized.py:236:40: W1116: Second argument of isinstance is not a type (isinstance-second-argument-not-valid-type) -ranger/ext/shutil_generatorized.py:278:16: W0707: Consider explicitly re-raising using 'except OSError as exc' and 'raise Error("Cannot move a directory '%s' into itself '%s'." % (src, dst)) from exc' (raise-missing-from) -ranger/ext/shutil_generatorized.py:278:28: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/shutil_generatorized.py:279:12: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from) -ranger/ext/shutil_generatorized.py:284:12: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from) -************* Module ranger.ext.widestring -ranger/ext/widestring.py:57:0: R0205: Class 'WideString' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -ranger/ext/widestring.py:80:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) -ranger/ext/widestring.py:91:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) -************* Module ranger.ext.hash -ranger/ext/hash.py:20:12: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from) -************* Module ranger.ext.accumulator -ranger/ext/accumulator.py:9:0: R0205: Class 'Accumulator' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -ranger/ext/accumulator.py:78:12: R1731: Consider using 'i = max(i, 0)' instead of unnecessary if block (consider-using-max-builtin) -************* Module ranger.ext.vcs.git -ranger/ext/vcs/git.py:55:21: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/vcs/git.py:163:56: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/vcs/git.py:189:12: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) -ranger/ext/vcs/git.py:192:31: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/vcs/git.py:196:27: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -************* Module ranger.ext.vcs.hg -ranger/ext/vcs/hg.py:130:12: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) -ranger/ext/vcs/hg.py:133:31: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/vcs/hg.py:137:27: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -************* Module ranger.ext.vcs.svn -ranger/ext/vcs/svn.py:144:12: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) -ranger/ext/vcs/svn.py:147:31: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/vcs/svn.py:151:27: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -************* Module ranger.ext.vcs.vcs -ranger/ext/vcs/vcs.py:24:4: W0107: Unnecessary pass statement (unnecessary-pass) -ranger/ext/vcs/vcs.py:27:0: R0205: Class 'Vcs' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -ranger/ext/vcs/vcs.py:80:23: R1719: The if expression can be replaced with 'test' (simplifiable-if-expression) -ranger/ext/vcs/vcs.py:81:28: R1719: The if expression can be replaced with 'bool(test)' (simplifiable-if-expression) -ranger/ext/vcs/vcs.py:112:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) -ranger/ext/vcs/vcs.py:124:12: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) -ranger/ext/vcs/vcs.py:130:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) -ranger/ext/vcs/vcs.py:134:12: W0707: Consider explicitly re-raising using 'except (subprocess.CalledProcessError, OSError) as exc' and 'raise VcsError('{0:s}: {1:s}'.format(str(cmd), path)) from exc' (raise-missing-from) -ranger/ext/vcs/vcs.py:134:27: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/vcs/vcs.py:171:16: C2801: Unnecessarily calls dunder method __init__. Instantiate class directly. (unnecessary-dunder-call) -ranger/ext/vcs/vcs.py:278:28: C2801: Unnecessarily calls dunder method __init__. Instantiate class directly. (unnecessary-dunder-call) -ranger/ext/vcs/vcs.py:321:16: C2801: Unnecessarily calls dunder method __init__. Instantiate class directly. (unnecessary-dunder-call) -ranger/ext/vcs/vcs.py:326:12: C2801: Unnecessarily calls dunder method __init__. Instantiate class directly. (unnecessary-dunder-call) -ranger/ext/vcs/vcs.py:380:8: R1725: Consider using Python 3 style super() without arguments (super-with-arguments) -ranger/ext/vcs/vcs.py:463:15: W4902: Using deprecated method isSet() (deprecated-method) -ranger/ext/vcs/vcs.py:466:19: W4902: Using deprecated method isSet() (deprecated-method) -ranger/ext/vcs/vcs.py:491:15: W4902: Using deprecated method isSet() (deprecated-method) -ranger/ext/vcs/vcs.py:516:4: W0107: Unnecessary pass statement (unnecessary-pass) -ranger/ext/vcs/vcs.py:521:4: W0107: Unnecessary pass statement (unnecessary-pass) -ranger/ext/vcs/vcs.py:526:4: W0107: Unnecessary pass statement (unnecessary-pass) -ranger/ext/vcs/vcs.py:531:4: W0107: Unnecessary pass statement (unnecessary-pass) -************* Module ranger.ext.vcs.bzr -ranger/ext/vcs/bzr.py:138:12: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) -ranger/ext/vcs/bzr.py:141:31: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/ext/vcs/bzr.py:145:27: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -************* Module ranger.colorschemes.snow -ranger/colorschemes/snow.py:12:4: W0221: Number of parameters was 1 in 'ColorScheme.use' and is now 2 in overriding 'Snow.use' method (arguments-differ) -************* Module ranger.colorschemes.solarized -ranger/colorschemes/solarized.py:21:4: W0221: Number of parameters was 1 in 'ColorScheme.use' and is now 2 in overriding 'Solarized.use' method (arguments-differ) -ranger/colorschemes/solarized.py:24:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) -************* Module ranger.colorschemes.default -ranger/colorschemes/default.py:17:4: W0221: Number of parameters was 1 in 'ColorScheme.use' and is now 2 in overriding 'Default.use' method (arguments-differ) -ranger/colorschemes/default.py:20:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) -************* Module ranger.core.metadata -ranger/core/metadata.py:25:0: R0205: Class 'MetadataManager' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -ranger/core/metadata.py:29:30: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) -ranger/core/metadata.py:31:30: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) -ranger/core/metadata.py:56:8: C0415: Import outside toplevel (json) (import-outside-toplevel) -ranger/core/metadata.py:87:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) -ranger/core/metadata.py:114:8: C0415: Import outside toplevel (json) (import-outside-toplevel) -ranger/core/metadata.py:120:17: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) -ranger/core/metadata.py:124:20: W0707: Consider explicitly re-raising using 'except ValueError as exc' and 'raise ValueError('Failed decoding JSON file %s' % metafile) from exc' (raise-missing-from) -ranger/core/metadata.py:124:37: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -************* Module ranger.core.filter_stack -ranger/core/filter_stack.py:25:0: R0205: Class 'BaseFilter' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -ranger/core/filter_stack.py:58:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/filter_stack.py:74:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/filter_stack.py:100:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/filter_stack.py:195:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/filter_stack.py:219:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/filter_stack.py:239:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/filter_stack.py:255:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) ************* Module ranger.core.main ranger/core/main.py:273:0: C0325: Unnecessary parens after '=' keyword (superfluous-parens) ranger/core/main.py:20:4: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) @@ -909,6 +739,26 @@ ranger/core/main.py:433:23: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) ranger/core/main.py:478:4: C0415: Import outside toplevel (errno.EEXIST) (import-outside-toplevel) ranger/core/main.py:489:16: W0707: Consider explicitly re-raising using 'raise SystemExit from err' (raise-missing-from) +************* Module ranger.core.filter_stack +ranger/core/filter_stack.py:25:0: R0205: Class 'BaseFilter' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +ranger/core/filter_stack.py:58:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/filter_stack.py:74:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/filter_stack.py:100:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/filter_stack.py:195:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/filter_stack.py:219:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/filter_stack.py:239:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/filter_stack.py:255:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +************* Module ranger.core.shared +ranger/core/shared.py:9:0: R0205: Class 'FileManagerAware' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +ranger/core/shared.py:16:0: R0205: Class 'SettingsAware' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +************* Module ranger.core.linemode +ranger/core/linemode.py:17:0: R0205: Class 'LinemodeBase' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +ranger/core/linemode.py:71:19: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/linemode.py:87:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/linemode.py:101:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) +ranger/core/linemode.py:102:12: C0415: Import outside toplevel (subprocess.CalledProcessError) (import-outside-toplevel) +ranger/core/linemode.py:133:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/linemode.py:159:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) ************* Module ranger.core.runner ranger/core/runner.py:209:0: C0325: Unnecessary parens after '=' keyword (superfluous-parens) ranger/core/runner.py:54:0: R0205: Class 'Context' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) @@ -925,19 +775,53 @@ ranger/core/runner.py:193:31: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) ranger/core/runner.py:194:31: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) ranger/core/runner.py:245:30: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -************* Module ranger.core.linemode -ranger/core/linemode.py:17:0: R0205: Class 'LinemodeBase' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -ranger/core/linemode.py:71:19: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/linemode.py:87:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/linemode.py:101:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) -ranger/core/linemode.py:102:12: C0415: Import outside toplevel (subprocess.CalledProcessError) (import-outside-toplevel) -ranger/core/linemode.py:133:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/linemode.py:159:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -************* Module ranger.core.tab -ranger/core/tab.py:30:0: C0325: Unnecessary parens after '=' keyword (superfluous-parens) -ranger/core/tab.py:32:0: C0325: Unnecessary parens after '=' keyword (superfluous-parens) -ranger/core/tab.py:81:12: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) -ranger/core/tab.py:174:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +************* Module ranger.core.metadata +ranger/core/metadata.py:25:0: R0205: Class 'MetadataManager' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +ranger/core/metadata.py:29:30: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) +ranger/core/metadata.py:31:30: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) +ranger/core/metadata.py:56:8: C0415: Import outside toplevel (json) (import-outside-toplevel) +ranger/core/metadata.py:87:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +ranger/core/metadata.py:114:8: C0415: Import outside toplevel (json) (import-outside-toplevel) +ranger/core/metadata.py:120:17: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +ranger/core/metadata.py:124:20: W0707: Consider explicitly re-raising using 'except ValueError as exc' and 'raise ValueError('Failed decoding JSON file %s' % metafile) from exc' (raise-missing-from) +ranger/core/metadata.py:124:37: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +************* Module ranger.core.actions +ranger/core/actions.py:1236:0: C0325: Unnecessary parens after '=' keyword (superfluous-parens) +ranger/core/actions.py:107:29: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/actions.py:118:12: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) +ranger/core/actions.py:138:25: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/actions.py:177:12: W0719: Raising too general exception: Exception (broad-exception-raised) +ranger/core/actions.py:181:19: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/actions.py:239:24: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/actions.py:245:24: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/actions.py:252:24: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/actions.py:295:29: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/actions.py:327:30: R1726: Boolean condition "fl.realpath in self.fm.tags or []" may be simplified to "fl.realpath in self.fm.tags" (simplifiable-condition) +ranger/core/actions.py:402:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +ranger/core/actions.py:412:32: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/actions.py:432:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +ranger/core/actions.py:443:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +ranger/core/actions.py:739:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) +ranger/core/actions.py:823:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) +ranger/core/actions.py:964:19: R1721: Unnecessary use of a comprehension, use list(self.rifle.list_commands([target.path], None, skip_ask=True)) instead. (unnecessary-comprehension) +ranger/core/actions.py:968:28: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/actions.py:1104:27: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/actions.py:1109:27: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/actions.py:1170:16: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) +ranger/core/actions.py:1192:18: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/actions.py:1058:4: R0915: Too many statements (79/50) (too-many-statements) +ranger/core/actions.py:1213:12: C0415: Import outside toplevel (chardet) (import-outside-toplevel) +ranger/core/actions.py:1201:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) +ranger/core/actions.py:1312:4: R1711: Useless return at end of function or method (useless-return) +ranger/core/actions.py:1406:8: R0205: Class 'NaturalOrder' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +ranger/core/actions.py:1429:25: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +ranger/core/actions.py:1440:26: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/actions.py:1443:18: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/actions.py:1454:25: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +ranger/core/actions.py:1473:22: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/actions.py:1479:25: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +ranger/core/actions.py:1485:18: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/core/actions.py:1612:20: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) ************* Module ranger.core.loader ranger/core/loader.py:27:0: R0205: Class 'Loadable' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) ranger/core/loader.py:55:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) @@ -950,9 +834,11 @@ ranger/core/loader.py:189:19: R1714: Consider merging these comparisons with 'in' by using 'ex.errno not in (errno.EPIPE, errno.EINVAL)'. Use a set instead if elements are hashable. (consider-using-in) ranger/core/loader.py:178:33: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) ranger/core/loader.py:429:20: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -************* Module ranger.core.shared -ranger/core/shared.py:9:0: R0205: Class 'FileManagerAware' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -ranger/core/shared.py:16:0: R0205: Class 'SettingsAware' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +************* Module ranger.core.tab +ranger/core/tab.py:30:0: C0325: Unnecessary parens after '=' keyword (superfluous-parens) +ranger/core/tab.py:32:0: C0325: Unnecessary parens after '=' keyword (superfluous-parens) +ranger/core/tab.py:81:12: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) +ranger/core/tab.py:174:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) ************* Module ranger.core.fm ranger/core/fm.py:52:27: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) ranger/core/fm.py:148:12: C0415: Import outside toplevel (re) (import-outside-toplevel) @@ -979,134 +865,43 @@ ranger/core/fm.py:398:12: W0707: Consider explicitly re-raising using 'except KeyboardInterrupt as exc' and 'raise SystemExit from exc' (raise-missing-from) ranger/core/fm.py:405:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) ranger/core/fm.py:412:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) -************* Module ranger.core.actions -ranger/core/actions.py:1236:0: C0325: Unnecessary parens after '=' keyword (superfluous-parens) -ranger/core/actions.py:107:29: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/actions.py:118:12: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) -ranger/core/actions.py:138:25: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/actions.py:177:12: W0719: Raising too general exception: Exception (broad-exception-raised) -ranger/core/actions.py:181:19: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/actions.py:239:24: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/actions.py:245:24: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/actions.py:252:24: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/actions.py:295:29: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/actions.py:327:30: R1726: Boolean condition "fl.realpath in self.fm.tags or []" may be simplified to "fl.realpath in self.fm.tags" (simplifiable-condition) -ranger/core/actions.py:402:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) -ranger/core/actions.py:412:32: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/actions.py:432:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) -ranger/core/actions.py:443:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) -ranger/core/actions.py:739:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) -ranger/core/actions.py:823:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) -ranger/core/actions.py:964:19: R1721: Unnecessary use of a comprehension, use list(self.rifle.list_commands([target.path], None, skip_ask=True)) instead. (unnecessary-comprehension) -ranger/core/actions.py:968:28: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/actions.py:1104:27: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/actions.py:1109:27: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/actions.py:1170:16: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) -ranger/core/actions.py:1192:18: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/actions.py:1058:4: R0915: Too many statements (79/50) (too-many-statements) -ranger/core/actions.py:1213:12: C0415: Import outside toplevel (chardet) (import-outside-toplevel) -ranger/core/actions.py:1201:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) -ranger/core/actions.py:1312:4: R1711: Useless return at end of function or method (useless-return) -ranger/core/actions.py:1406:8: R0205: Class 'NaturalOrder' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -ranger/core/actions.py:1429:25: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -ranger/core/actions.py:1440:26: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/actions.py:1443:18: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/actions.py:1454:25: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -ranger/core/actions.py:1473:22: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/actions.py:1479:25: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -ranger/core/actions.py:1485:18: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/core/actions.py:1612:20: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -************* Module ranger.gui.ui -ranger/gui/ui.py:115:21: R1735: Consider using '{"value": self.settings.mouse_enabled}' instead of a call to 'dict'. (use-dict-literal) -ranger/gui/ui.py:149:25: R1735: Consider using '{"value": False}' instead of a call to 'dict'. (use-dict-literal) -ranger/gui/ui.py:232:25: R1716: Simplify chained comparison between the operands (chained-comparison) -ranger/gui/ui.py:273:8: C0415: Import outside toplevel (ranger.gui.widgets.titlebar.TitleBar) (import-outside-toplevel) -ranger/gui/ui.py:274:8: C0415: Import outside toplevel (ranger.gui.widgets.console.Console) (import-outside-toplevel) -ranger/gui/ui.py:275:8: C0415: Import outside toplevel (ranger.gui.widgets.statusbar.StatusBar) (import-outside-toplevel) -ranger/gui/ui.py:276:8: C0415: Import outside toplevel (ranger.gui.widgets.taskview.TaskView) (import-outside-toplevel) -ranger/gui/ui.py:277:8: C0415: Import outside toplevel (ranger.gui.widgets.pager.Pager) (import-outside-toplevel) -ranger/gui/ui.py:312:8: C0415: Import outside toplevel (ranger.ext.vcs.VcsThread) (import-outside-toplevel) -ranger/gui/ui.py:384:37: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/gui/ui.py:557:29: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/gui/ui.py:564:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) -ranger/gui/ui.py:565:12: C0415: Import outside toplevel (ranger.gui.widgets.view_miller.ViewMiller) (import-outside-toplevel) -ranger/gui/ui.py:568:12: C0415: Import outside toplevel (ranger.gui.widgets.view_multipane.ViewMultipane) (import-outside-toplevel) -************* Module ranger.gui.color -ranger/gui/color.py:52:0: R0022: Useless option value for 'disable', 'bad-whitespace' was removed from pylint, see https://github.com/pylint-dev/pylint/pull/3577. (useless-option-value) -ranger/gui/color.py:72:0: R0022: Useless option value for 'enable', 'bad-whitespace' was removed from pylint, see https://github.com/pylint-dev/pylint/pull/3577. (useless-option-value) -************* Module ranger.gui.displayable -ranger/gui/displayable.py:50:8: C0415: Import outside toplevel (ranger.gui.ui.UI) (import-outside-toplevel) -ranger/gui/displayable.py:113:16: R1716: Simplify chained comparison between the operands (chained-comparison) -ranger/gui/displayable.py:114:13: R1716: Simplify chained comparison between the operands (chained-comparison) -ranger/gui/displayable.py:121:8: W0107: Unnecessary pass statement (unnecessary-pass) -ranger/gui/displayable.py:128:8: W0107: Unnecessary pass statement (unnecessary-pass) -ranger/gui/displayable.py:144:8: W0107: Unnecessary pass statement (unnecessary-pass) -ranger/gui/displayable.py:161:31: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/gui/displayable.py:166:20: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -************* Module ranger.gui.ansi -ranger/gui/ansi.py:45:20: R1724: Unnecessary "elif" after "continue", remove the leading "el" from "elif" (no-else-continue) -ranger/gui/ansi.py:83:21: R1716: Simplify chained comparison between the operands (chained-comparison) -ranger/gui/ansi.py:87:21: R1716: Simplify chained comparison between the operands (chained-comparison) -ranger/gui/ansi.py:93:21: R1716: Simplify chained comparison between the operands (chained-comparison) -ranger/gui/ansi.py:97:21: R1716: Simplify chained comparison between the operands (chained-comparison) -ranger/gui/ansi.py:162:13: R1716: Simplify chained comparison between the operands (chained-comparison) -************* Module ranger.gui.context -ranger/gui/context.py:31:0: R0205: Class 'Context' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -************* Module ranger.gui.mouse_event -ranger/gui/mouse_event.py:9:0: R0205: Class 'MouseEvent' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -ranger/gui/mouse_event.py:45:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) -************* Module ranger.gui.colorscheme -ranger/gui/colorscheme.py:44:0: R0205: Class 'ColorScheme' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -ranger/gui/colorscheme.py:111:16: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -ranger/gui/colorscheme.py:111:16: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) -ranger/gui/colorscheme.py:122:4: R1720: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it (no-else-raise) -ranger/gui/colorscheme.py:127:31: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -************* Module ranger.gui.bar -ranger/gui/bar.py:14:0: R0205: Class 'Bar' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -ranger/gui/bar.py:121:0: R0205: Class 'ColoredString' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -************* Module ranger.gui.widgets.pager -ranger/gui/widgets/pager.py:154:23: R1735: Consider using '{"direction": direction.down(), "override": narg, "current": self.scroll_begin, ... }' instead of a call to 'dict'. (use-dict-literal) -ranger/gui/widgets/pager.py:232:24: R1731: Consider using 'self.max_width = max(self.max_width, len(line))' instead of unnecessary if block (consider-using-max-builtin) -************* Module ranger.gui.widgets.taskview -ranger/gui/widgets/taskview.py:57:42: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/gui/widgets/taskview.py:93:4: W0221: Number of parameters was 0 in 'Accumulator.get_list' and is now 1 in overriding 'TaskView.get_list' method (arguments-differ) -************* Module ranger.gui.widgets.console -ranger/gui/widgets/console.py:46:27: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) -ranger/gui/widgets/console.py:46:27: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -ranger/gui/widgets/console.py:78:23: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) -ranger/gui/widgets/console.py:78:23: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -ranger/gui/widgets/console.py:236:16: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) -ranger/gui/widgets/console.py:466:31: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -************* Module ranger.gui.widgets.browsercolumn -ranger/gui/widgets/browsercolumn.py:422:15: R1728: Consider using a generator instead 'sum(len(WideString(s)) for (s, _) in predisplay)' (consider-using-generator) -ranger/gui/widgets/browsercolumn.py:542:11: R1716: Simplify chained comparison between the operands (chained-comparison) -************* Module ranger.gui.widgets.view_base -ranger/gui/widgets/view_base.py:133:12: C0415: Import outside toplevel (itertools.groupby) (import-outside-toplevel) -************* Module ranger.gui.widgets.statusbar -ranger/gui/widgets/statusbar.py:70:12: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) -ranger/gui/widgets/statusbar.py:160:20: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/gui/widgets/statusbar.py:196:26: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/gui/widgets/statusbar.py:199:26: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/gui/widgets/statusbar.py:309:26: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/gui/widgets/statusbar.py:343:0: R0205: Class 'Message' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -************* Module ranger.container.settings -ranger/container/settings.py:17:0: R0022: Useless option value for 'disable', 'bad-whitespace' was removed from pylint, see https://github.com/pylint-dev/pylint/pull/3577. (useless-option-value) -ranger/container/settings.py:23:0: R0022: Useless option value for 'enable', 'bad-whitespace' was removed from pylint, see https://github.com/pylint-dev/pylint/pull/3577. (useless-option-value) -ranger/container/settings.py:138:42: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) -ranger/container/settings.py:139:41: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) -ranger/container/settings.py:140:40: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) -ranger/container/settings.py:141:37: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) -ranger/container/settings.py:173:35: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/container/settings.py:182:41: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/container/settings.py:190:14: R1735: Consider using '{"setting": name, "value": value, "previous": previous, "path": path, ... }' instead of a call to 'dict'. (use-dict-literal) -ranger/container/settings.py:209:41: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/container/settings.py:234:12: C2801: Unnecessarily calls dunder method __setattr__. Set attribute directly or use setattr built-in function. (unnecessary-dunder-call) -ranger/container/settings.py:249:8: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from) -ranger/container/settings.py:254:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) -ranger/container/settings.py:287:44: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) -ranger/container/settings.py:299:45: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) -ranger/container/settings.py:308:0: R0205: Class 'LocalSettings' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -ranger/container/settings.py:328:8: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from) +************* Module ranger.api +ranger/api/__init__.py:45:4: C0415: Import outside toplevel (ranger.container.fsobject.FileSystemObject) (import-outside-toplevel) +************* Module ranger.api.commands +ranger/api/commands.py:415:0: C0325: Unnecessary parens after '=' keyword (superfluous-parens) +ranger/api/commands.py:32:12: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) +ranger/api/commands.py:56:27: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/api/commands.py:245:16: R1723: Unnecessary "elif" after "break", remove the leading "el" from "elif" (no-else-break) +ranger/api/commands.py:257:8: C0415: Import outside toplevel (logging) (import-outside-toplevel) +ranger/api/commands.py:262:8: C0415: Import outside toplevel (os.path.dirname, os.path.basename, os.path.expanduser, os.path.join) (import-outside-toplevel) +ranger/api/commands.py:261:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) +ranger/api/commands.py:308:8: C0415: Import outside toplevel (os.path.dirname, os.path.basename, os.path.expanduser, os.path.join) (import-outside-toplevel) +ranger/api/commands.py:307:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) +ranger/api/commands.py:373:8: C0415: Import outside toplevel (ranger.ext.get_executables.get_executables) (import-outside-toplevel) +ranger/api/commands.py:387:12: R1725: Consider using Python 3 style super() without arguments (super-with-arguments) +ranger/api/commands.py:407:27: R1734: Consider using [] instead of list() (use-list-literal) +ranger/api/commands.py:407:35: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) +ranger/api/commands.py:431:16: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) +ranger/api/commands.py:442:31: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/api/commands.py:398:8: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) +************* Module ranger.container.history +ranger/container/history.py:13:0: R0205: Class 'History' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +ranger/container/history.py:93:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) +ranger/container/history.py:102:12: W0707: Consider explicitly re-raising using 'except IndexError as exc' and 'raise HistoryEmptyException from exc' (raise-missing-from) +ranger/container/history.py:108:12: W0707: Consider explicitly re-raising using 'except IndexError as exc' and 'raise HistoryEmptyException from exc' (raise-missing-from) +ranger/container/history.py:112:8: R1731: Consider using 'self.index = max(self.index, 0)' instead of unnecessary if block (consider-using-max-builtin) +ranger/container/history.py:118:8: R1730: Consider using 'self.index = min(self.index, len(self.history) - 1)' instead of unnecessary if block (consider-using-min-builtin) +ranger/container/history.py:120:8: R1731: Consider using 'self.index = max(self.index, 0)' instead of unnecessary if block (consider-using-max-builtin) +ranger/container/history.py:145:12: R1730: Consider using 'self.index = min(self.index, len(self.history) - 1)' instead of unnecessary if block (consider-using-min-builtin) +************* Module ranger.container.file +ranger/container/file.py:71:15: E1101: Instance of 'MockFM' has no 'settings' member (no-member) +ranger/container/file.py:77:11: E1101: Instance of 'MockFM' has no 'settings' member (no-member) +ranger/container/file.py:78:28: E1101: Instance of 'MockFM' has no 'settings' member (no-member) +ranger/container/file.py:80:11: E1101: Instance of 'MockFM' has no 'settings' member (no-member) +ranger/container/file.py:81:16: E1101: Instance of 'MockFM' has no 'settings' member (no-member) +ranger/container/file.py:89:11: R1714: Consider merging these comparisons with 'in' by using 'self.path in ('/dev/core', '/proc/kcore')'. Use a set instead if elements are hashable. (consider-using-in) +ranger/container/file.py:96:15: E1101: Instance of 'MockFM' has no 'get_preview' member (no-member) +ranger/container/file.py:100:19: E1101: Instance of 'MockFM' has no 'previews' member (no-member) ************* Module ranger.container.bookmarks ranger/container/bookmarks.py:261:0: R0022: Useless option value for 'disable', 'no-self-use' was moved to an optional extension, see https://pylint.readthedocs.io/en/latest/whatsnew/2/2.14/summary.html#removed-checkers. (useless-option-value) ranger/container/bookmarks.py:92:12: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) @@ -1122,20 +917,6 @@ ranger/container/bookmarks.py:228:19: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) ranger/container/bookmarks.py:230:27: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) ranger/container/bookmarks.py:228:19: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -************* Module ranger.container.tags -ranger/container/tags.py:15:0: R0205: Class 'Tags' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -ranger/container/tags.py:23:12: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -ranger/container/tags.py:23:12: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) -ranger/container/tags.py:31:8: R1715: Consider using dict.get for getting values from a dict if a key is present or a default if not (consider-using-get) -ranger/container/tags.py:50:8: R1715: Consider using dict.get for getting values from a dict if a key is present or a default if not (consider-using-get) -ranger/container/tags.py:76:23: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) -ranger/container/tags.py:78:23: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) -ranger/container/tags.py:78:23: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -ranger/container/tags.py:87:19: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) -ranger/container/tags.py:87:19: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -ranger/container/tags.py:100:27: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/container/tags.py:103:17: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) -ranger/container/tags.py:143:20: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) ************* Module ranger.container.fsobject ranger/container/fsobject.py:114:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) ranger/container/fsobject.py:137:56: E1101: Instance of 'MockFM' has no 'tags' member (no-member) @@ -1147,24 +928,24 @@ ranger/container/fsobject.py:299:26: R1719: The if expression can be replaced with 'bool(test)' (simplifiable-if-expression) ranger/container/fsobject.py:312:26: R1719: The if expression can be replaced with 'bool(test)' (simplifiable-if-expression) ranger/container/fsobject.py:316:11: R1714: Consider merging these comparisons with 'in' by using 'fmt in (8192, 24576)'. Use a set instead if elements are hashable. (consider-using-in) -************* Module ranger.container.history -ranger/container/history.py:13:0: R0205: Class 'History' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) -ranger/container/history.py:93:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) -ranger/container/history.py:102:12: W0707: Consider explicitly re-raising using 'except IndexError as exc' and 'raise HistoryEmptyException from exc' (raise-missing-from) -ranger/container/history.py:108:12: W0707: Consider explicitly re-raising using 'except IndexError as exc' and 'raise HistoryEmptyException from exc' (raise-missing-from) -ranger/container/history.py:112:8: R1731: Consider using 'self.index = max(self.index, 0)' instead of unnecessary if block (consider-using-max-builtin) -ranger/container/history.py:118:8: R1730: Consider using 'self.index = min(self.index, len(self.history) - 1)' instead of unnecessary if block (consider-using-min-builtin) -ranger/container/history.py:120:8: R1731: Consider using 'self.index = max(self.index, 0)' instead of unnecessary if block (consider-using-max-builtin) -ranger/container/history.py:145:12: R1730: Consider using 'self.index = min(self.index, len(self.history) - 1)' instead of unnecessary if block (consider-using-min-builtin) -************* Module ranger.container.file -ranger/container/file.py:71:15: E1101: Instance of 'MockFM' has no 'settings' member (no-member) -ranger/container/file.py:77:11: E1101: Instance of 'MockFM' has no 'settings' member (no-member) -ranger/container/file.py:78:28: E1101: Instance of 'MockFM' has no 'settings' member (no-member) -ranger/container/file.py:80:11: E1101: Instance of 'MockFM' has no 'settings' member (no-member) -ranger/container/file.py:81:16: E1101: Instance of 'MockFM' has no 'settings' member (no-member) -ranger/container/file.py:89:11: R1714: Consider merging these comparisons with 'in' by using 'self.path in ('/dev/core', '/proc/kcore')'. Use a set instead if elements are hashable. (consider-using-in) -ranger/container/file.py:96:15: E1101: Instance of 'MockFM' has no 'get_preview' member (no-member) -ranger/container/file.py:100:19: E1101: Instance of 'MockFM' has no 'previews' member (no-member) +************* Module ranger.container.settings +ranger/container/settings.py:17:0: R0022: Useless option value for 'disable', 'bad-whitespace' was removed from pylint, see https://github.com/pylint-dev/pylint/pull/3577. (useless-option-value) +ranger/container/settings.py:23:0: R0022: Useless option value for 'enable', 'bad-whitespace' was removed from pylint, see https://github.com/pylint-dev/pylint/pull/3577. (useless-option-value) +ranger/container/settings.py:138:42: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) +ranger/container/settings.py:139:41: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) +ranger/container/settings.py:140:40: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) +ranger/container/settings.py:141:37: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) +ranger/container/settings.py:173:35: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/container/settings.py:182:41: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/container/settings.py:190:14: R1735: Consider using '{"setting": name, "value": value, "previous": previous, "path": path, ... }' instead of a call to 'dict'. (use-dict-literal) +ranger/container/settings.py:209:41: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/container/settings.py:234:12: C2801: Unnecessarily calls dunder method __setattr__. Set attribute directly or use setattr built-in function. (unnecessary-dunder-call) +ranger/container/settings.py:249:8: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from) +ranger/container/settings.py:254:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) +ranger/container/settings.py:287:44: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) +ranger/container/settings.py:299:45: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) +ranger/container/settings.py:308:0: R0205: Class 'LocalSettings' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +ranger/container/settings.py:328:8: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from) ************* Module ranger.container.directory ranger/container/directory.py:77:18: R1719: The if expression can be replaced with 'test' (simplifiable-if-expression) ranger/container/directory.py:92:16: W3301: Do not use nested call of 'max'; it's possible to do 'max(mtime, *[-1] + [os.stat(d).st_mtime for d in dirlist])' instead (nested-min-max) @@ -1184,31 +965,284 @@ ranger/container/directory.py:582:34: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) ranger/container/directory.py:652:19: E1101: Instance of 'MockFM' has no 'thisdir' member (no-member) ranger/container/directory.py:709:19: E1101: Instance of 'MockFM' has no 'enter_dir' member (no-member) -************* Module ranger.api -ranger/api/__init__.py:45:4: C0415: Import outside toplevel (ranger.container.fsobject.FileSystemObject) (import-outside-toplevel) -************* Module ranger.api.commands -ranger/api/commands.py:415:0: C0325: Unnecessary parens after '=' keyword (superfluous-parens) -ranger/api/commands.py:32:12: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) -ranger/api/commands.py:56:27: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/api/commands.py:245:16: R1723: Unnecessary "elif" after "break", remove the leading "el" from "elif" (no-else-break) -ranger/api/commands.py:257:8: C0415: Import outside toplevel (logging) (import-outside-toplevel) -ranger/api/commands.py:262:8: C0415: Import outside toplevel (os.path.dirname, os.path.basename, os.path.expanduser, os.path.join) (import-outside-toplevel) -ranger/api/commands.py:261:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) -ranger/api/commands.py:308:8: C0415: Import outside toplevel (os.path.dirname, os.path.basename, os.path.expanduser, os.path.join) (import-outside-toplevel) -ranger/api/commands.py:307:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) -ranger/api/commands.py:373:8: C0415: Import outside toplevel (ranger.ext.get_executables.get_executables) (import-outside-toplevel) -ranger/api/commands.py:387:12: R1725: Consider using Python 3 style super() without arguments (super-with-arguments) -ranger/api/commands.py:407:27: R1734: Consider using [] instead of list() (use-list-literal) -ranger/api/commands.py:407:35: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) -ranger/api/commands.py:431:16: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) -ranger/api/commands.py:442:31: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -ranger/api/commands.py:398:8: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) +************* Module ranger.container.tags +ranger/container/tags.py:15:0: R0205: Class 'Tags' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +ranger/container/tags.py:23:12: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +ranger/container/tags.py:23:12: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +ranger/container/tags.py:31:8: R1715: Consider using dict.get for getting values from a dict if a key is present or a default if not (consider-using-get) +ranger/container/tags.py:50:8: R1715: Consider using dict.get for getting values from a dict if a key is present or a default if not (consider-using-get) +ranger/container/tags.py:76:23: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +ranger/container/tags.py:78:23: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +ranger/container/tags.py:78:23: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +ranger/container/tags.py:87:19: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +ranger/container/tags.py:87:19: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +ranger/container/tags.py:100:27: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/container/tags.py:103:17: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) +ranger/container/tags.py:143:20: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) +************* Module ranger.gui.context +ranger/gui/context.py:31:0: R0205: Class 'Context' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +************* Module ranger.gui.colorscheme +ranger/gui/colorscheme.py:44:0: R0205: Class 'ColorScheme' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +ranger/gui/colorscheme.py:111:16: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +ranger/gui/colorscheme.py:111:16: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +ranger/gui/colorscheme.py:122:4: R1720: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it (no-else-raise) +ranger/gui/colorscheme.py:127:31: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +************* Module ranger.gui.bar +ranger/gui/bar.py:14:0: R0205: Class 'Bar' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +ranger/gui/bar.py:121:0: R0205: Class 'ColoredString' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +************* Module ranger.gui.ui +ranger/gui/ui.py:115:21: R1735: Consider using '{"value": self.settings.mouse_enabled}' instead of a call to 'dict'. (use-dict-literal) +ranger/gui/ui.py:149:25: R1735: Consider using '{"value": False}' instead of a call to 'dict'. (use-dict-literal) +ranger/gui/ui.py:232:25: R1716: Simplify chained comparison between the operands (chained-comparison) +ranger/gui/ui.py:273:8: C0415: Import outside toplevel (ranger.gui.widgets.titlebar.TitleBar) (import-outside-toplevel) +ranger/gui/ui.py:274:8: C0415: Import outside toplevel (ranger.gui.widgets.console.Console) (import-outside-toplevel) +ranger/gui/ui.py:275:8: C0415: Import outside toplevel (ranger.gui.widgets.statusbar.StatusBar) (import-outside-toplevel) +ranger/gui/ui.py:276:8: C0415: Import outside toplevel (ranger.gui.widgets.taskview.TaskView) (import-outside-toplevel) +ranger/gui/ui.py:277:8: C0415: Import outside toplevel (ranger.gui.widgets.pager.Pager) (import-outside-toplevel) +ranger/gui/ui.py:312:8: C0415: Import outside toplevel (ranger.ext.vcs.VcsThread) (import-outside-toplevel) +ranger/gui/ui.py:384:37: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/gui/ui.py:557:29: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/gui/ui.py:564:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) +ranger/gui/ui.py:565:12: C0415: Import outside toplevel (ranger.gui.widgets.view_miller.ViewMiller) (import-outside-toplevel) +ranger/gui/ui.py:568:12: C0415: Import outside toplevel (ranger.gui.widgets.view_multipane.ViewMultipane) (import-outside-toplevel) +************* Module ranger.gui.ansi +ranger/gui/ansi.py:45:20: R1724: Unnecessary "elif" after "continue", remove the leading "el" from "elif" (no-else-continue) +ranger/gui/ansi.py:83:21: R1716: Simplify chained comparison between the operands (chained-comparison) +ranger/gui/ansi.py:87:21: R1716: Simplify chained comparison between the operands (chained-comparison) +ranger/gui/ansi.py:93:21: R1716: Simplify chained comparison between the operands (chained-comparison) +ranger/gui/ansi.py:97:21: R1716: Simplify chained comparison between the operands (chained-comparison) +ranger/gui/ansi.py:162:13: R1716: Simplify chained comparison between the operands (chained-comparison) +************* Module ranger.gui.color +ranger/gui/color.py:52:0: R0022: Useless option value for 'disable', 'bad-whitespace' was removed from pylint, see https://github.com/pylint-dev/pylint/pull/3577. (useless-option-value) +ranger/gui/color.py:72:0: R0022: Useless option value for 'enable', 'bad-whitespace' was removed from pylint, see https://github.com/pylint-dev/pylint/pull/3577. (useless-option-value) +************* Module ranger.gui.mouse_event +ranger/gui/mouse_event.py:9:0: R0205: Class 'MouseEvent' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +ranger/gui/mouse_event.py:45:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) +************* Module ranger.gui.displayable +ranger/gui/displayable.py:50:8: C0415: Import outside toplevel (ranger.gui.ui.UI) (import-outside-toplevel) +ranger/gui/displayable.py:113:16: R1716: Simplify chained comparison between the operands (chained-comparison) +ranger/gui/displayable.py:114:13: R1716: Simplify chained comparison between the operands (chained-comparison) +ranger/gui/displayable.py:121:8: W0107: Unnecessary pass statement (unnecessary-pass) +ranger/gui/displayable.py:128:8: W0107: Unnecessary pass statement (unnecessary-pass) +ranger/gui/displayable.py:144:8: W0107: Unnecessary pass statement (unnecessary-pass) +ranger/gui/displayable.py:161:31: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/gui/displayable.py:166:20: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +************* Module ranger.gui.widgets.statusbar +ranger/gui/widgets/statusbar.py:70:12: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) +ranger/gui/widgets/statusbar.py:160:20: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/gui/widgets/statusbar.py:196:26: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/gui/widgets/statusbar.py:199:26: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/gui/widgets/statusbar.py:309:26: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/gui/widgets/statusbar.py:343:0: R0205: Class 'Message' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +************* Module ranger.gui.widgets.view_base +ranger/gui/widgets/view_base.py:133:12: C0415: Import outside toplevel (itertools.groupby) (import-outside-toplevel) +************* Module ranger.gui.widgets.taskview +ranger/gui/widgets/taskview.py:57:42: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/gui/widgets/taskview.py:93:4: W0221: Number of parameters was 0 in 'Accumulator.get_list' and is now 1 in overriding 'TaskView.get_list' method (arguments-differ) +************* Module ranger.gui.widgets.console +ranger/gui/widgets/console.py:46:27: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +ranger/gui/widgets/console.py:46:27: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +ranger/gui/widgets/console.py:78:23: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +ranger/gui/widgets/console.py:78:23: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +ranger/gui/widgets/console.py:236:16: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) +ranger/gui/widgets/console.py:466:31: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +************* Module ranger.gui.widgets.pager +ranger/gui/widgets/pager.py:154:23: R1735: Consider using '{"direction": direction.down(), "override": narg, "current": self.scroll_begin, ... }' instead of a call to 'dict'. (use-dict-literal) +ranger/gui/widgets/pager.py:232:24: R1731: Consider using 'self.max_width = max(self.max_width, len(line))' instead of unnecessary if block (consider-using-max-builtin) +************* Module ranger.gui.widgets.browsercolumn +ranger/gui/widgets/browsercolumn.py:422:15: R1728: Consider using a generator instead 'sum(len(WideString(s)) for (s, _) in predisplay)' (consider-using-generator) +ranger/gui/widgets/browsercolumn.py:542:11: R1716: Simplify chained comparison between the operands (chained-comparison) +************* Module ranger.ext.popen_forked +ranger/ext/popen_forked.py:21:26: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +ranger/ext/popen_forked.py:21:26: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +ranger/ext/popen_forked.py:22:46: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +ranger/ext/popen_forked.py:22:46: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +ranger/ext/popen_forked.py:23:8: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +************* Module ranger.ext.shell_escape +ranger/ext/shell_escape.py:12:12: R1717: Consider using a dictionary comprehension (consider-using-dict-comprehension) +************* Module ranger.ext.signals +ranger/ext/signals.py:87:0: R0205: Class 'SignalHandler' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +ranger/ext/signals.py:105:0: R0205: Class 'SignalDispatcher' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +ranger/ext/signals.py:109:24: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) +ranger/ext/signals.py:116:24: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) +ranger/ext/signals.py:118:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) +ranger/ext/signals.py:165:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) +************* Module ranger.ext.spawn +ranger/ext/spawn.py:34:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +ranger/ext/spawn.py:35:22: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +************* Module ranger.ext.direction +ranger/ext/direction.py:115:4: R0917: Too many positional arguments (8/5) (too-many-positional-arguments) +ranger/ext/direction.py:168:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) +************* Module ranger.ext.keybinding_parser +ranger/ext/keybinding_parser.py:93:8: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from) +ranger/ext/keybinding_parser.py:107:24: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from) +ranger/ext/keybinding_parser.py:142:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/keybinding_parser.py:143:11: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/keybinding_parser.py:172:54: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) +ranger/ext/keybinding_parser.py:181:38: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) +ranger/ext/keybinding_parser.py:196:45: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) +ranger/ext/keybinding_parser.py:198:41: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) +ranger/ext/keybinding_parser.py:209:16: W0707: Consider explicitly re-raising using 'except KeyError as exc' and 'raise KeyError("Tried to copy the keybinding `%s', but it was not found." % source) from exc' (raise-missing-from) +ranger/ext/keybinding_parser.py:209:31: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/keybinding_parser.py:220:0: R0205: Class 'KeyBuffer' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +ranger/ext/keybinding_parser.py:242:8: C2801: Unnecessarily calls dunder method __init__. Instantiate class directly. (unnecessary-dunder-call) +************* Module ranger.ext.lazy_property +ranger/ext/lazy_property.py:8:0: R0205: Class 'lazy_property' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +************* Module ranger.ext.widestring +ranger/ext/widestring.py:57:0: R0205: Class 'WideString' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +ranger/ext/widestring.py:80:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) +ranger/ext/widestring.py:91:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) +************* Module ranger.ext.iter_tools +ranger/ext/iter_tools.py:23:12: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from) +************* Module ranger.ext.accumulator +ranger/ext/accumulator.py:9:0: R0205: Class 'Accumulator' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +ranger/ext/accumulator.py:78:12: R1731: Consider using 'i = max(i, 0)' instead of unnecessary if block (consider-using-max-builtin) +************* Module ranger.ext.hash +ranger/ext/hash.py:20:12: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from) +************* Module ranger.ext.rifle +ranger/ext/rifle.py:50:8: C0415: Import outside toplevel (stat.S_IXOTH, stat.S_IFREG) (import-outside-toplevel) +ranger/ext/rifle.py:83:30: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +ranger/ext/rifle.py:83:30: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +ranger/ext/rifle.py:84:50: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +ranger/ext/rifle.py:84:50: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +ranger/ext/rifle.py:85:12: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +ranger/ext/rifle.py:116:0: R0205: Class 'Rifle' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +ranger/ext/rifle.py:163:15: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +ranger/ext/rifle.py:163:15: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +ranger/ext/rifle.py:219:12: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) +ranger/ext/rifle.py:254:8: C0415: Import outside toplevel (mimetypes) (import-outside-toplevel) +ranger/ext/rifle.py:261:22: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +ranger/ext/rifle.py:266:30: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +ranger/ext/rifle.py:280:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/rifle.py:312:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) +ranger/ext/rifle.py:333:12: R1723: Unnecessary "else" after "break", remove the "else" and de-indent the code inside it (no-else-break) +ranger/ext/rifle.py:344:22: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/rifle.py:351:37: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/rifle.py:353:37: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/rifle.py:430:63: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/rifle.py:442:30: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +ranger/ext/rifle.py:463:12: C0415: Import outside toplevel (ranger) (import-outside-toplevel) +ranger/ext/rifle.py:470:25: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/rifle.py:481:4: C0415: Import outside toplevel (optparse.OptionParser) (import-outside-toplevel) +ranger/ext/rifle.py:509:29: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/rifle.py:510:12: W0707: Consider explicitly re-raising using 'raise SystemExit(1) from ex' (raise-missing-from) +ranger/ext/rifle.py:512:29: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/rifle.py:532:22: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/rifle.py:537:22: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/rifle.py:523:18: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +************* Module ranger.ext.img_display +ranger/ext/img_display.py:18:0: W4901: Deprecated module 'imghdr' (deprecated-module) +ranger/ext/img_display.py:103:0: R0205: Class 'ImageDisplayer' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +ranger/ext/img_display.py:108:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) +ranger/ext/img_display.py:110:8: W0107: Unnecessary pass statement (unnecessary-pass) +ranger/ext/img_display.py:114:8: W0107: Unnecessary pass statement (unnecessary-pass) +ranger/ext/img_display.py:118:8: W0107: Unnecessary pass statement (unnecessary-pass) +ranger/ext/img_display.py:140:23: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +ranger/ext/img_display.py:150:32: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/img_display.py:164:22: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +ranger/ext/img_display.py:174:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) +ranger/ext/img_display.py:179:8: W0706: The except handler raises immediately (try-except-raise) +ranger/ext/img_display.py:186:12: C0415: Import outside toplevel (time.sleep) (import-outside-toplevel) +ranger/ext/img_display.py:201:14: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/img_display.py:220:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) +ranger/ext/img_display.py:236:14: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/img_display.py:259:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/img_display.py:284:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) +ranger/ext/img_display.py:309:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/img_display.py:320:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) +ranger/ext/img_display.py:347:22: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +ranger/ext/img_display.py:398:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) +ranger/ext/img_display.py:479:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) +ranger/ext/img_display.py:491:14: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/img_display.py:593:16: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/img_display.py:599:12: C0415: Import outside toplevel (PIL.Image) (import-outside-toplevel) +ranger/ext/img_display.py:602:12: W0707: Consider explicitly re-raising using 'except ImportError as exc' and 'raise ImageDisplayError('Image previews in kitty require PIL (pillow)') from exc' (raise-missing-from) +ranger/ext/img_display.py:613:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) +ranger/ext/img_display.py:639:11: R1714: Consider merging these comparisons with 'in' by using 'image.mode not in ('RGB', 'RGBA')'. Use a set instead if elements are hashable. (consider-using-in) +ranger/ext/img_display.py:673:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) +ranger/ext/img_display.py:676:36: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/img_display.py:693:32: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/img_display.py:737:23: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) +ranger/ext/img_display.py:746:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) +************* Module ranger.ext.shutil_generatorized +ranger/ext/shutil_generatorized.py:19:4: E0601: Using variable 'WindowsError' before assignment (used-before-assignment) +ranger/ext/shutil_generatorized.py:121:20: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/shutil_generatorized.py:132:39: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/shutil_generatorized.py:136:12: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from) +ranger/ext/shutil_generatorized.py:156:8: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from) +ranger/ext/shutil_generatorized.py:161:0: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) +ranger/ext/shutil_generatorized.py:236:40: W1116: Second argument of isinstance is not a type (isinstance-second-argument-not-valid-type) +ranger/ext/shutil_generatorized.py:278:16: W0707: Consider explicitly re-raising using 'except OSError as exc' and 'raise Error("Cannot move a directory '%s' into itself '%s'." % (src, dst)) from exc' (raise-missing-from) +ranger/ext/shutil_generatorized.py:278:28: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/shutil_generatorized.py:279:12: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from) +ranger/ext/shutil_generatorized.py:284:12: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from) +************* Module ranger.ext.human_readable +ranger/ext/human_readable.py:35:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/human_readable.py:37:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/human_readable.py:39:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/human_readable.py:41:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/human_readable.py:43:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/human_readable.py:45:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/human_readable.py:47:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/human_readable.py:49:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/human_readable.py:51:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/human_readable.py:53:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/human_readable.py:55:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/human_readable.py:65:4: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) +ranger/ext/human_readable.py:77:4: R0205: Class 'SettingsAwareMock' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +ranger/ext/human_readable.py:78:8: R0205: Class 'settings' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +************* Module ranger.ext.vcs.vcs +ranger/ext/vcs/vcs.py:24:4: W0107: Unnecessary pass statement (unnecessary-pass) +ranger/ext/vcs/vcs.py:27:0: R0205: Class 'Vcs' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) +ranger/ext/vcs/vcs.py:80:23: R1719: The if expression can be replaced with 'test' (simplifiable-if-expression) +ranger/ext/vcs/vcs.py:81:28: R1719: The if expression can be replaced with 'bool(test)' (simplifiable-if-expression) +ranger/ext/vcs/vcs.py:112:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) +ranger/ext/vcs/vcs.py:124:12: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) +ranger/ext/vcs/vcs.py:130:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +ranger/ext/vcs/vcs.py:134:12: W0707: Consider explicitly re-raising using 'except (subprocess.CalledProcessError, OSError) as exc' and 'raise VcsError('{0:s}: {1:s}'.format(str(cmd), path)) from exc' (raise-missing-from) +ranger/ext/vcs/vcs.py:134:27: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/vcs/vcs.py:171:16: C2801: Unnecessarily calls dunder method __init__. Instantiate class directly. (unnecessary-dunder-call) +ranger/ext/vcs/vcs.py:278:28: C2801: Unnecessarily calls dunder method __init__. Instantiate class directly. (unnecessary-dunder-call) +ranger/ext/vcs/vcs.py:321:16: C2801: Unnecessarily calls dunder method __init__. Instantiate class directly. (unnecessary-dunder-call) +ranger/ext/vcs/vcs.py:326:12: C2801: Unnecessarily calls dunder method __init__. Instantiate class directly. (unnecessary-dunder-call) +ranger/ext/vcs/vcs.py:380:8: R1725: Consider using Python 3 style super() without arguments (super-with-arguments) +ranger/ext/vcs/vcs.py:463:15: W4902: Using deprecated method isSet() (deprecated-method) +ranger/ext/vcs/vcs.py:466:19: W4902: Using deprecated method isSet() (deprecated-method) +ranger/ext/vcs/vcs.py:491:15: W4902: Using deprecated method isSet() (deprecated-method) +ranger/ext/vcs/vcs.py:516:4: W0107: Unnecessary pass statement (unnecessary-pass) +ranger/ext/vcs/vcs.py:521:4: W0107: Unnecessary pass statement (unnecessary-pass) +ranger/ext/vcs/vcs.py:526:4: W0107: Unnecessary pass statement (unnecessary-pass) +ranger/ext/vcs/vcs.py:531:4: W0107: Unnecessary pass statement (unnecessary-pass) +************* Module ranger.ext.vcs.hg +ranger/ext/vcs/hg.py:130:12: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) +ranger/ext/vcs/hg.py:133:31: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/vcs/hg.py:137:27: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +************* Module ranger.ext.vcs.git +ranger/ext/vcs/git.py:55:21: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/vcs/git.py:163:56: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/vcs/git.py:189:12: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) +ranger/ext/vcs/git.py:192:31: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/vcs/git.py:196:27: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +************* Module ranger.ext.vcs.bzr +ranger/ext/vcs/bzr.py:138:12: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) +ranger/ext/vcs/bzr.py:141:31: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/vcs/bzr.py:145:27: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +************* Module ranger.ext.vcs.svn +ranger/ext/vcs/svn.py:144:12: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) +ranger/ext/vcs/svn.py:147:31: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +ranger/ext/vcs/svn.py:151:27: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +************* Module ranger.colorschemes.snow +ranger/colorschemes/snow.py:12:4: W0221: Number of parameters was 1 in 'ColorScheme.use' and is now 2 in overriding 'Snow.use' method (arguments-differ) +************* Module ranger.colorschemes.default +ranger/colorschemes/default.py:17:4: W0221: Number of parameters was 1 in 'ColorScheme.use' and is now 2 in overriding 'Default.use' method (arguments-differ) +ranger/colorschemes/default.py:20:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) +************* Module ranger.colorschemes.solarized +ranger/colorschemes/solarized.py:21:4: W0221: Number of parameters was 1 in 'ColorScheme.use' and is now 2 in overriding 'Solarized.use' method (arguments-differ) +ranger/colorschemes/solarized.py:24:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) ************* Module ranger ranger/__init__.py:19:25: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) ranger/__init__.py:21:8: C0415: Import outside toplevel (subprocess) (import-outside-toplevel) ranger/__init__.py:24:27: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) -************* Module doc.tools.print_colors -doc/tools/print_colors.py:27:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) ************* Module doc.tools.performance_test doc/tools/performance_test.py:13:4: C0415: Import outside toplevel (ranger.container.directory) (import-outside-toplevel) doc/tools/performance_test.py:14:4: C0415: Import outside toplevel (ranger.core.shared) (import-outside-toplevel) @@ -1224,12 +1258,14 @@ doc/tools/convert_papermode_to_metadata.py:46:22: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) doc/tools/convert_papermode_to_metadata.py:62:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) doc/tools/convert_papermode_to_metadata.py:65:14: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -************* Module examples.plugin_pmount -examples/plugin_pmount.py:25:23: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -examples/plugin_pmount.py:27:27: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -examples/plugin_pmount.py:29:27: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -examples/plugin_pmount.py:33:16: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -examples/plugin_pmount.py:36:31: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +************* Module doc.tools.print_colors +doc/tools/print_colors.py:27:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +************* Module examples.plugin_ipc +examples/plugin_ipc.py:21:8: C0415: Import outside toplevel (os) (import-outside-toplevel) +examples/plugin_ipc.py:27:12: C0415: Import outside toplevel (thread) (import-outside-toplevel) +examples/plugin_ipc.py:29:12: C0415: Import outside toplevel (_thread) (import-outside-toplevel) +examples/plugin_ipc.py:33:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +examples/plugin_ipc.py:44:8: C0415: Import outside toplevel (atexit) (import-outside-toplevel) ************* Module examples.plugin_pmount_dynamic examples/plugin_pmount_dynamic.py:28:23: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) examples/plugin_pmount_dynamic.py:35:18: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) @@ -1239,12 +1275,12 @@ examples/plugin_pmount_dynamic.py:55:31: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) examples/plugin_pmount_dynamic.py:62:20: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) examples/plugin_pmount_dynamic.py:64:35: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) -************* Module examples.plugin_ipc -examples/plugin_ipc.py:21:8: C0415: Import outside toplevel (os) (import-outside-toplevel) -examples/plugin_ipc.py:27:12: C0415: Import outside toplevel (thread) (import-outside-toplevel) -examples/plugin_ipc.py:29:12: C0415: Import outside toplevel (_thread) (import-outside-toplevel) -examples/plugin_ipc.py:33:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) -examples/plugin_ipc.py:44:8: C0415: Import outside toplevel (atexit) (import-outside-toplevel) +************* Module examples.plugin_pmount +examples/plugin_pmount.py:25:23: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +examples/plugin_pmount.py:27:27: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +examples/plugin_pmount.py:29:27: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +examples/plugin_pmount.py:33:16: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) +examples/plugin_pmount.py:36:31: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) ************* Module setup setup.py:7:0: W4901: Deprecated module 'distutils' (deprecated-module) setup.py:24:4: W4901: Deprecated module 'distutils.core' (deprecated-module) @@ -1400,12 +1436,14 @@ dpkg-buildpackage: info: binary-only upload (no source included) dpkg-genchanges: info: not including original source code in upload I: copying local configuration +I: user script /srv/workspace/pbuilder/30999/tmp/hooks/B01_cleanup starting +I: user script /srv/workspace/pbuilder/30999/tmp/hooks/B01_cleanup finished I: unmounting dev/ptmx filesystem I: unmounting dev/pts filesystem I: unmounting dev/shm filesystem I: unmounting proc filesystem I: unmounting sys filesystem I: cleaning the build env -I: removing directory /srv/workspace/pbuilder/29985 and its subdirectories -I: Current time: Wed Nov 13 17:38:21 -12 2024 -I: pbuilder-time-stamp: 1731562701 +I: removing directory /srv/workspace/pbuilder/30999 and its subdirectories +I: Current time: Thu Dec 18 02:02:11 +14 2025 +I: pbuilder-time-stamp: 1765972931