Diff of the two buildlogs: -- --- b1/build.log 2023-06-07 05:13:45.000047282 +0000 +++ b2/build.log 2023-06-07 05:20:37.090025983 +0000 @@ -1,6 +1,6 @@ I: pbuilder: network access will be disabled during build -I: Current time: Tue Jun 6 17:06:57 -12 2023 -I: pbuilder-time-stamp: 1686114417 +I: Current time: Wed Jul 10 01:36:44 +14 2024 +I: pbuilder-time-stamp: 1720525004 I: Building the build Environment I: extracting base tarball [/var/cache/pbuilder/bookworm-reproducible-base.tgz] I: copying local configuration @@ -16,7 +16,7 @@ I: copying [./lsh-utils_2.1.orig.tar.gz] I: copying [./lsh-utils_2.1-13.debian.tar.xz] I: Extracting source -gpgv: Signature made Wed Jan 6 10:32:58 2021 -12 +gpgv: Signature made Thu Jan 7 12:32:58 2021 +14 gpgv: using RSA key CD2A073B386154170A4082E8D4F219BFEC998489 gpgv: Can't check signature: No public key dpkg-source: warning: cannot verify inline signature for ./lsh-utils_2.1-13.dsc: no acceptable signature found @@ -37,52 +37,84 @@ dpkg-source: info: applying missing_extern.patch I: using fakeroot in build. I: Installing the build-deps -I: user script /srv/workspace/pbuilder/15113/tmp/hooks/D02_print_environment starting +I: user script /srv/workspace/pbuilder/17044/tmp/hooks/D01_modify_environment starting +debug: Running on codethink15-arm64. +I: Changing host+domainname to test build reproducibility +I: Adding a custom variable just for the fun of it... +I: Changing /bin/sh to bash +'/bin/sh' -> '/bin/bash' +lrwxrwxrwx 1 root root 9 Jul 10 01:36 /bin/sh -> /bin/bash +I: Setting pbuilder2's login shell to /bin/bash +I: Setting pbuilder2's GECOS to second user,second room,second work-phone,second home-phone,second other +I: user script /srv/workspace/pbuilder/17044/tmp/hooks/D01_modify_environment finished +I: user script /srv/workspace/pbuilder/17044/tmp/hooks/D02_print_environment starting I: set - BUILDDIR='/build' - BUILDUSERGECOS='first user,first room,first work-phone,first home-phone,first other' - BUILDUSERNAME='pbuilder1' - BUILD_ARCH='arm64' - DEBIAN_FRONTEND='noninteractive' + BASH=/bin/sh + BASHOPTS=checkwinsize:cmdhist:complete_fullquote:extquote:force_fignore:globasciiranges:globskipdots:hostcomplete:interactive_comments:patsub_replacement:progcomp:promptvars:sourcepath + BASH_ALIASES=() + BASH_ARGC=() + BASH_ARGV=() + BASH_CMDS=() + BASH_LINENO=([0]="12" [1]="0") + BASH_LOADABLES_PATH=/usr/local/lib/bash:/usr/lib/bash:/opt/local/lib/bash:/usr/pkg/lib/bash:/opt/pkg/lib/bash:. + BASH_SOURCE=([0]="/tmp/hooks/D02_print_environment" [1]="/tmp/hooks/D02_print_environment") + BASH_VERSINFO=([0]="5" [1]="2" [2]="15" [3]="1" [4]="release" [5]="aarch64-unknown-linux-gnu") + BASH_VERSION='5.2.15(1)-release' + BUILDDIR=/build + BUILDUSERGECOS='second user,second room,second work-phone,second home-phone,second other' + BUILDUSERNAME=pbuilder2 + BUILD_ARCH=arm64 + DEBIAN_FRONTEND=noninteractive DEB_BUILD_OPTIONS='buildinfo=+all reproducible=+all parallel=8 ' - DISTRIBUTION='bookworm' - HOME='/var/lib/jenkins' - HOST_ARCH='arm64' + DIRSTACK=() + DISTRIBUTION=bookworm + EUID=0 + FUNCNAME=([0]="Echo" [1]="main") + GROUPS=() + HOME=/var/lib/jenkins + HOSTNAME=i-capture-the-hostname + HOSTTYPE=aarch64 + HOST_ARCH=arm64 IFS=' ' - LANG='C' - LANGUAGE='en_US:en' - LC_ALL='C' - MAIL='/var/mail/root' - OPTIND='1' - PATH='/usr/sbin:/usr/bin:/sbin:/bin:/usr/games' - PBCURRENTCOMMANDLINEOPERATION='build' - PBUILDER_OPERATION='build' - PBUILDER_PKGDATADIR='/usr/share/pbuilder' - PBUILDER_PKGLIBDIR='/usr/lib/pbuilder' - PBUILDER_SYSCONFDIR='/etc' - PPID='15113' - PS1='# ' - PS2='> ' + LANG=C + LANGUAGE=nl_BE:nl + LC_ALL=C + MACHTYPE=aarch64-unknown-linux-gnu + MAIL=/var/mail/root + OPTERR=1 + OPTIND=1 + OSTYPE=linux-gnu + PATH=/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/i/capture/the/path + PBCURRENTCOMMANDLINEOPERATION=build + PBUILDER_OPERATION=build + PBUILDER_PKGDATADIR=/usr/share/pbuilder + PBUILDER_PKGLIBDIR=/usr/lib/pbuilder + PBUILDER_SYSCONFDIR=/etc + PIPESTATUS=([0]="0") + POSIXLY_CORRECT=y + PPID=17044 PS4='+ ' - PWD='/' - SHELL='/bin/bash' - SHLVL='2' - SUDO_COMMAND='/usr/bin/timeout -k 18.1h 18h /usr/bin/ionice -c 3 /usr/bin/nice /usr/sbin/pbuilder --build --configfile /srv/reproducible-results/rbuild-debian/r-b-build.VeZiJ9Ac/pbuilderrc_YRpY --distribution bookworm --hookdir /etc/pbuilder/first-build-hooks --debbuildopts -b --basetgz /var/cache/pbuilder/bookworm-reproducible-base.tgz --buildresult /srv/reproducible-results/rbuild-debian/r-b-build.VeZiJ9Ac/b1 --logfile b1/build.log lsh-utils_2.1-13.dsc' - SUDO_GID='117' - SUDO_UID='110' - SUDO_USER='jenkins' - TERM='unknown' - TZ='/usr/share/zoneinfo/Etc/GMT+12' - USER='root' - USERNAME='root' - _='/usr/bin/systemd-run' - http_proxy='http://192.168.101.16:3128' + PWD=/ + SHELL=/bin/bash + SHELLOPTS=braceexpand:errexit:hashall:interactive-comments:posix + SHLVL=3 + SUDO_COMMAND='/usr/bin/timeout -k 24.1h 24h /usr/bin/ionice -c 3 /usr/bin/nice -n 11 /usr/bin/unshare --uts -- /usr/sbin/pbuilder --build --configfile /srv/reproducible-results/rbuild-debian/r-b-build.VeZiJ9Ac/pbuilderrc_5UpL --distribution bookworm --hookdir /etc/pbuilder/rebuild-hooks --debbuildopts -b --basetgz /var/cache/pbuilder/bookworm-reproducible-base.tgz --buildresult /srv/reproducible-results/rbuild-debian/r-b-build.VeZiJ9Ac/b2 --logfile b2/build.log --extrapackages usrmerge lsh-utils_2.1-13.dsc' + SUDO_GID=117 + SUDO_UID=110 + SUDO_USER=jenkins + TERM=unknown + TZ=/usr/share/zoneinfo/Etc/GMT-14 + UID=0 + USER=root + USERNAME=root + _='I: set' + http_proxy=http://192.168.101.16:3128 I: uname -a - Linux codethink12-arm64 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:17 UTC 2023 aarch64 GNU/Linux + Linux i-capture-the-hostname 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:17 UTC 2023 aarch64 GNU/Linux I: ls -l /bin - lrwxrwxrwx 1 root root 7 Jun 5 22:26 /bin -> usr/bin -I: user script /srv/workspace/pbuilder/15113/tmp/hooks/D02_print_environment finished + lrwxrwxrwx 1 root root 7 Jul 7 15:14 /bin -> usr/bin +I: user script /srv/workspace/pbuilder/17044/tmp/hooks/D02_print_environment finished -> Attempting to satisfy build-dependencies -> Creating pbuilder-satisfydepends-dummy package Package: pbuilder-satisfydepends-dummy @@ -213,7 +245,7 @@ Get: 62 http://deb.debian.org/debian bookworm/main arm64 tex-common all 6.18 [32.5 kB] Get: 63 http://deb.debian.org/debian bookworm/main arm64 texinfo arm64 6.8-6+b1 [1808 kB] Get: 64 http://deb.debian.org/debian bookworm/main arm64 zlib1g-dev arm64 1:1.2.13.dfsg-1 [913 kB] -Fetched 26.0 MB in 1s (35.4 MB/s) +Fetched 26.0 MB in 1s (45.8 MB/s) debconf: delaying package configuration, since apt-utils is not installed Selecting previously unselected package readline-common. (Reading database ... (Reading database ... 5% (Reading database ... 10% (Reading database ... 15% (Reading database ... 20% (Reading database ... 25% (Reading database ... 30% (Reading database ... 35% (Reading database ... 40% (Reading database ... 45% (Reading database ... 50% (Reading database ... 55% (Reading database ... 60% (Reading database ... 65% (Reading database ... 70% (Reading database ... 75% (Reading database ... 80% (Reading database ... 85% (Reading database ... 90% (Reading database ... 95% (Reading database ... 100% (Reading database ... 19611 files and directories currently installed.) @@ -496,10 +528,15 @@ Reading package lists... Building dependency tree... Reading state information... +usrmerge is already the newest version (35). fakeroot is already the newest version (1.31-1.2). 0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded. I: Building the package -I: Running cd /build/lsh-utils-2.1/ && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games" HOME="/nonexistent/first-build" dpkg-buildpackage -us -uc -b && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games" HOME="/nonexistent/first-build" dpkg-genchanges -S > ../lsh-utils_2.1-13_source.changes +I: user script /srv/workspace/pbuilder/17044/tmp/hooks/A99_set_merged_usr starting +Re-configuring usrmerge... +I: user script /srv/workspace/pbuilder/17044/tmp/hooks/A99_set_merged_usr finished +hostname: Temporary failure in name resolution +I: Running cd /build/lsh-utils-2.1/ && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/i/capture/the/path" HOME="/nonexistent/second-build" dpkg-buildpackage -us -uc -b && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/i/capture/the/path" HOME="/nonexistent/second-build" dpkg-genchanges -S > ../lsh-utils_2.1-13_source.changes dpkg-buildpackage: info: source package lsh-utils dpkg-buildpackage: info: source version 2.1-13 dpkg-buildpackage: info: source distribution unstable @@ -1032,7 +1069,7 @@ config.status: creating config.h config.status: executing depfiles commands === configuring in src/spki (/build/lsh-utils-2.1/src/spki) -configure: running /bin/bash /build/lsh-utils-2.1/src/spki/configure --disable-option-checking '--prefix=/usr' '--build=aarch64-linux-gnu' '--disable-dependency-tracking' '--enable-pam' '--enable-kerberos' '--enable-srp' '--with-pty' '--enable-tcp-forward' '--enable-x11-forward' '--enable-agent-forward' '--enable-ipv6' '--enable-utmp' '--with-zlib' '--with-tcpwrappers' '--with-sshd1=/usr/sbin/sshd' '--with-x' 'XAUTH_PROGRAM=/usr/bin/xauth' 'ASFLAGS=' 'CFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2' 'CXXFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security' 'DFLAGS=-frelease' 'FCFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong' 'FFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong' 'GCJFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong' 'LDFLAGS=-Wl,-z,defs -Wl,--as-needed -Wl,-z,relro' 'OBJCFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security' 'OBJCXXFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security' 'build_alias=aarch64-linux-gnu' --cache-file=/dev/null --srcdir=/build/lsh-utils-2.1/src/spki +configure: running /bin/sh /build/lsh-utils-2.1/src/spki/configure --disable-option-checking '--prefix=/usr' '--build=aarch64-linux-gnu' '--disable-dependency-tracking' '--enable-pam' '--enable-kerberos' '--enable-srp' '--with-pty' '--enable-tcp-forward' '--enable-x11-forward' '--enable-agent-forward' '--enable-ipv6' '--enable-utmp' '--with-zlib' '--with-tcpwrappers' '--with-sshd1=/usr/sbin/sshd' '--with-x' 'XAUTH_PROGRAM=/usr/bin/xauth' 'ASFLAGS=' 'CFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2' 'CXXFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security' 'DFLAGS=-frelease' 'FCFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong' 'FFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong' 'GCJFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong' 'LDFLAGS=-Wl,-z,defs -Wl,--as-needed -Wl,-z,relro' 'OBJCFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security' 'OBJCXXFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security' 'build_alias=aarch64-linux-gnu' --cache-file=/dev/null --srcdir=/build/lsh-utils-2.1/src/spki checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for a race-free mkdir -p... /usr/bin/mkdir -p @@ -1099,7 +1136,7 @@ config.status: creating config.h config.status: executing depfiles commands === configuring in src/sftp (/build/lsh-utils-2.1/src/sftp) -configure: running /bin/bash /build/lsh-utils-2.1/src/sftp/configure --disable-option-checking '--prefix=/usr' '--build=aarch64-linux-gnu' '--disable-dependency-tracking' '--enable-pam' '--enable-kerberos' '--enable-srp' '--with-pty' '--enable-tcp-forward' '--enable-x11-forward' '--enable-agent-forward' '--enable-ipv6' '--enable-utmp' '--with-zlib' '--with-tcpwrappers' '--with-sshd1=/usr/sbin/sshd' '--with-x' 'XAUTH_PROGRAM=/usr/bin/xauth' 'ASFLAGS=' 'CFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2' 'CXXFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security' 'DFLAGS=-frelease' 'FCFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong' 'FFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong' 'GCJFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong' 'LDFLAGS=-Wl,-z,defs -Wl,--as-needed -Wl,-z,relro' 'OBJCFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security' 'OBJCXXFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security' 'build_alias=aarch64-linux-gnu' --cache-file=/dev/null --srcdir=/build/lsh-utils-2.1/src/sftp +configure: running /bin/sh /build/lsh-utils-2.1/src/sftp/configure --disable-option-checking '--prefix=/usr' '--build=aarch64-linux-gnu' '--disable-dependency-tracking' '--enable-pam' '--enable-kerberos' '--enable-srp' '--with-pty' '--enable-tcp-forward' '--enable-x11-forward' '--enable-agent-forward' '--enable-ipv6' '--enable-utmp' '--with-zlib' '--with-tcpwrappers' '--with-sshd1=/usr/sbin/sshd' '--with-x' 'XAUTH_PROGRAM=/usr/bin/xauth' 'ASFLAGS=' 'CFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2' 'CXXFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security' 'DFLAGS=-frelease' 'FCFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong' 'FFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong' 'GCJFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong' 'LDFLAGS=-Wl,-z,defs -Wl,--as-needed -Wl,-z,relro' 'OBJCFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security' 'OBJCXXFLAGS=-g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security' 'build_alias=aarch64-linux-gnu' --cache-file=/dev/null --srcdir=/build/lsh-utils-2.1/src/sftp checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for a race-free mkdir -p... /usr/bin/mkdir -p @@ -1272,134 +1309,6 @@ gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o str_utils.o str_utils.c gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o dc.o dc.c gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o gnu_stuff.o gnu_stuff.c -rl.c: In function 'lsftp_rl_completion': -rl.c:222:39: warning: passing argument 2 of 'rl_completion_matches' from incompatible pointer type [-Wincompatible-pointer-types] - 222 | lsftp_rl_command_generator - | ^~~~~~~~~~~~~~~~~~~~~~~~~~ - | | - | char * (*)(char *, int) -In file included from rl.h:43, - from rl.c:37: -/usr/include/readline/readline.h:494:52: note: expected 'char * (*)(const char *, int)' but argument is of type 'char * (*)(char *, int)' - 494 | extern char **rl_completion_matches (const char *, rl_compentry_func_t *); - | ^~~~~~~~~~~~~~~~~~~~~ -rl.c:245:49: warning: passing argument 2 of 'rl_completion_matches' from incompatible pointer type [-Wincompatible-pointer-types] - 245 | lsftp_rl_command_generator - | ^~~~~~~~~~~~~~~~~~~~~~~~~~ - | | - | char * (*)(char *, int) -/usr/include/readline/readline.h:494:52: note: expected 'char * (*)(const char *, int)' but argument is of type 'char * (*)(char *, int)' - 494 | extern char **rl_completion_matches (const char *, rl_compentry_func_t *); - | ^~~~~~~~~~~~~~~~~~~~~ -rl.c:252:49: warning: passing argument 2 of 'rl_completion_matches' from incompatible pointer type [-Wincompatible-pointer-types] - 252 | lsftp_rl_remotefile_generator - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - | | - | char * (*)(char *, int) -/usr/include/readline/readline.h:494:52: note: expected 'char * (*)(const char *, int)' but argument is of type 'char * (*)(char *, int)' - 494 | extern char **rl_completion_matches (const char *, rl_compentry_func_t *); - | ^~~~~~~~~~~~~~~~~~~~~ -rl.c:267:49: warning: passing argument 2 of 'rl_completion_matches' from incompatible pointer type [-Wincompatible-pointer-types] - 267 | lsftp_rl_no_generator - | ^~~~~~~~~~~~~~~~~~~~~ - | | - | char * (*)(char *, int) -/usr/include/readline/readline.h:494:52: note: expected 'char * (*)(const char *, int)' but argument is of type 'char * (*)(char *, int)' - 494 | extern char **rl_completion_matches (const char *, rl_compentry_func_t *); - | ^~~~~~~~~~~~~~~~~~~~~ -rl.c:282:43: warning: passing argument 2 of 'rl_completion_matches' from incompatible pointer type [-Wincompatible-pointer-types] - 282 | lsftp_rl_command_generator - | ^~~~~~~~~~~~~~~~~~~~~~~~~~ - | | - | char * (*)(char *, int) -/usr/include/readline/readline.h:494:52: note: expected 'char * (*)(const char *, int)' but argument is of type 'char * (*)(char *, int)' - 494 | extern char **rl_completion_matches (const char *, rl_compentry_func_t *); - | ^~~~~~~~~~~~~~~~~~~~~ -rl.c:205:55: warning: unused parameter 'end' [-Wunused-parameter] - 205 | char** lsftp_rl_completion(char* text, int start, int end) - | ~~~~^~~ -rl.c: In function 'lsftp_rl_no_generator': -rl.c:457:36: warning: unused parameter 'text' [-Wunused-parameter] - 457 | char* lsftp_rl_no_generator (char* text, int state) - | ~~~~~~^~~~ -rl.c: In function 'lsftp_rl_history_fname': -rl.c:522:9: warning: unused variable 'username' [-Wunused-variable] - 522 | char* username; - | ^~~~~~~~ -sftp_c.c: In function 'sftp_get_file_init': -sftp_c.c:960:23: warning: pointer targets in passing argument 1 of 'stat' differ in signedness [-Wpointer-sign] - 960 | statret = stat( fname, &st ); - | ^~~~~ - | | - | const uint8_t * {aka const unsigned char *} -In file included from sftp_c.h:39, - from sftp_c.c:34: -/usr/include/aarch64-linux-gnu/sys/stat.h:205:41: note: expected 'const char * restrict' but argument is of type 'const uint8_t *' {aka 'const unsigned char *'} - 205 | extern int stat (const char *__restrict __file, - | ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ -commands.c: In function 'com_lcd': -commands.c:1868:7: warning: variable 'ret' set but not used [-Wunused-but-set-variable] - 1868 | int ret; - | ^~~ -sftp_c.c:971:15: warning: pointer targets in passing argument 1 of 'open' differ in signedness [-Wpointer-sign] - 971 | ret = open( fname, openmode, 0777 & ~mask ); - | ^~~~~ - | | - | const uint8_t * {aka const unsigned char *} -In file included from /usr/include/fcntl.h:314, - from sftp_c.h:45: -/usr/include/aarch64-linux-gnu/bits/fcntl2.h:41:19: note: expected 'const char *' but argument is of type 'const uint8_t *' {aka 'const unsigned char *'} - 41 | open (const char *__path, int __oflag, ...) - | ~~~~~~~~~~~~^~~~~~ -sftp_c.c:938:29: warning: unused parameter 'fnamelen' [-Wunused-parameter] - 938 | uint32_t fnamelen, - | ~~~~~~~~~^~~~~~~~ -sftp_c.c: In function 'sftp_put_file_init': -sftp_c.c:1262:15: warning: pointer targets in passing argument 1 of 'open' differ in signedness [-Wpointer-sign] - 1262 | ret = open( fname, O_RDONLY ); - | ^~~~~ - | | - | const uint8_t * {aka const unsigned char *} -/usr/include/aarch64-linux-gnu/bits/fcntl2.h:41:19: note: expected 'const char *' but argument is of type 'const uint8_t *' {aka 'const unsigned char *'} - 41 | open (const char *__path, int __oflag, ...) - | ~~~~~~~~~~~~^~~~~~ -commands.c: In function 'handle_command': -sftp_c.c:1239:29: warning: unused parameter 'fnamelen' [-Wunused-parameter] - 1239 | uint32_t fnamelen, - | ~~~~~~~~~^~~~~~~~ -commands.c:2144:29: warning: pointer targets in initialization of 'const char *' from 'const unsigned char *' differ in signedness [-Wpointer-sign] - 2144 | const char *entered_cmd = s; - | ^ -commands.c:2149:20: warning: pointer targets in passing argument 1 of 'lsftp_s_skip' differ in signedness [-Wpointer-sign] - 2149 | s = lsftp_s_skip(s," \n\t\r"); /* Skip any initial whitespace */ - | ^ - | | - | const unsigned char * -In file included from sftp_bind.h:63, - from commands.h:41, - from commands.c:31: -str_utils.h:42:38: note: expected 'const char *' but argument is of type 'const unsigned char *' - 42 | const char *lsftp_s_skip(const char *s, const char *sep); - | ~~~~~~~~~~~~^ -commands.c:2149:5: warning: pointer targets in assignment from 'const char *' to 'const unsigned char *' differ in signedness [-Wpointer-sign] - 2149 | s = lsftp_s_skip(s," \n\t\r"); /* Skip any initial whitespace */ - | ^ -commands.c:2158:25: warning: pointer targets in passing argument 1 of 'com_escape' differ in signedness [-Wpointer-sign] - 2158 | return com_escape( s+1, entered_cmd ); - | ~^~ - | | - | const unsigned char * -commands.c:352:24: note: expected 'const char *' but argument is of type 'const unsigned char *' - 352 | com_escape(const char *arg, const char *command UNUSED) - | ~~~~~~~~~~~~^~~ -commands.c:2161:27: warning: pointer targets in passing argument 1 of 'com_longhelp' differ in signedness [-Wpointer-sign] - 2161 | return com_longhelp( s+1, entered_cmd ); - | ~^~ - | | - | const unsigned char * -commands.c:244:26: note: expected 'const char *' but argument is of type 'const unsigned char *' - 244 | com_longhelp(const char *arg, const char *command UNUSED) - | ~~~~~~~~~~~~^~~ lsftp.c: In function 'lsftp_interactive_mainloop': lsftp.c:142:23: warning: pointer targets in passing argument 1 of 'handle_command' differ in signedness [-Wpointer-sign] 142 | handle_command( current_line ); @@ -1434,25 +1343,6 @@ gnu_stuff.h:35:33: note: expected 'const char **' but argument is of type 'char **' 35 | void do_gnu_stuff( const char** argv ); | ~~~~~~~~~~~~~^~~~ -commands.c:2165:22: warning: pointer targets in passing argument 1 of 'lsftp_s_strtok' differ in signedness [-Wpointer-sign] - 2165 | s = lsftp_s_strtok(s," \n\t\r", &tmp ); - | ^ - | | - | const unsigned char * -str_utils.h:39:40: note: expected 'const char *' but argument is of type 'const unsigned char *' - 39 | const char *lsftp_s_strtok(const char *s, const char* tok, - | ~~~~~~~~~~~~^ -commands.c:2165:5: warning: pointer targets in assignment from 'const char *' to 'const unsigned char *' differ in signedness [-Wpointer-sign] - 2165 | s = lsftp_s_strtok(s," \n\t\r", &tmp ); - | ^ -commands.c:2184:50: warning: pointer targets in passing argument 1 of 'lsftp_s_skip' differ in signedness [-Wpointer-sign] - 2184 | lsftp_s_skip(s," \n\t\r"), - | ^ - | | - | const unsigned char * -str_utils.h:42:38: note: expected 'const char *' but argument is of type 'const unsigned char *' - 42 | const char *lsftp_s_skip(const char *s, const char *sep); - | ~~~~~~~~~~~~^ sftp_bind.c: In function 'lsftp_open_connection': sftp_bind.c:210:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 210 | cur_string = @@ -1509,7 +1399,74 @@ sftp_c.h:403:29: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'const char *' 403 | const uint8_t *dir, | ~~~~~~~~~~~~~~~^~~ +rl.c: In function 'lsftp_rl_completion': +rl.c:222:39: warning: passing argument 2 of 'rl_completion_matches' from incompatible pointer type [-Wincompatible-pointer-types] + 222 | lsftp_rl_command_generator + | ^~~~~~~~~~~~~~~~~~~~~~~~~~ + | | + | char * (*)(char *, int) +In file included from rl.h:43, + from rl.c:37: +/usr/include/readline/readline.h:494:52: note: expected 'char * (*)(const char *, int)' but argument is of type 'char * (*)(char *, int)' + 494 | extern char **rl_completion_matches (const char *, rl_compentry_func_t *); + | ^~~~~~~~~~~~~~~~~~~~~ +rl.c:245:49: warning: passing argument 2 of 'rl_completion_matches' from incompatible pointer type [-Wincompatible-pointer-types] + 245 | lsftp_rl_command_generator + | ^~~~~~~~~~~~~~~~~~~~~~~~~~ + | | + | char * (*)(char *, int) +/usr/include/readline/readline.h:494:52: note: expected 'char * (*)(const char *, int)' but argument is of type 'char * (*)(char *, int)' + 494 | extern char **rl_completion_matches (const char *, rl_compentry_func_t *); + | ^~~~~~~~~~~~~~~~~~~~~ +rl.c:252:49: warning: passing argument 2 of 'rl_completion_matches' from incompatible pointer type [-Wincompatible-pointer-types] + 252 | lsftp_rl_remotefile_generator + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + | | + | char * (*)(char *, int) +/usr/include/readline/readline.h:494:52: note: expected 'char * (*)(const char *, int)' but argument is of type 'char * (*)(char *, int)' + 494 | extern char **rl_completion_matches (const char *, rl_compentry_func_t *); + | ^~~~~~~~~~~~~~~~~~~~~ +rl.c:267:49: warning: passing argument 2 of 'rl_completion_matches' from incompatible pointer type [-Wincompatible-pointer-types] + 267 | lsftp_rl_no_generator + | ^~~~~~~~~~~~~~~~~~~~~ + | | + | char * (*)(char *, int) +/usr/include/readline/readline.h:494:52: note: expected 'char * (*)(const char *, int)' but argument is of type 'char * (*)(char *, int)' + 494 | extern char **rl_completion_matches (const char *, rl_compentry_func_t *); + | ^~~~~~~~~~~~~~~~~~~~~ +rl.c:282:43: warning: passing argument 2 of 'rl_completion_matches' from incompatible pointer type [-Wincompatible-pointer-types] + 282 | lsftp_rl_command_generator + | ^~~~~~~~~~~~~~~~~~~~~~~~~~ + | | + | char * (*)(char *, int) +/usr/include/readline/readline.h:494:52: note: expected 'char * (*)(const char *, int)' but argument is of type 'char * (*)(char *, int)' + 494 | extern char **rl_completion_matches (const char *, rl_compentry_func_t *); + | ^~~~~~~~~~~~~~~~~~~~~ +rl.c:205:55: warning: unused parameter 'end' [-Wunused-parameter] + 205 | char** lsftp_rl_completion(char* text, int start, int end) + | ~~~~^~~ +sftp_c.c: In function 'sftp_get_file_init': +sftp_c.c:960:23: warning: pointer targets in passing argument 1 of 'stat' differ in signedness [-Wpointer-sign] + 960 | statret = stat( fname, &st ); + | ^~~~~ + | | + | const uint8_t * {aka const unsigned char *} +In file included from sftp_c.h:39, + from sftp_c.c:34: +/usr/include/aarch64-linux-gnu/sys/stat.h:205:41: note: expected 'const char * restrict' but argument is of type 'const uint8_t *' {aka 'const unsigned char *'} + 205 | extern int stat (const char *__restrict __file, + | ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ sftp_bind.c: In function 'lsftp_handle_ls': +sftp_c.c:971:15: warning: pointer targets in passing argument 1 of 'open' differ in signedness [-Wpointer-sign] + 971 | ret = open( fname, openmode, 0777 & ~mask ); + | ^~~~~ + | | + | const uint8_t * {aka const unsigned char *} +In file included from /usr/include/fcntl.h:314, + from sftp_c.h:45: +/usr/include/aarch64-linux-gnu/bits/fcntl2.h:41:19: note: expected 'const char *' but argument is of type 'const uint8_t *' {aka 'const unsigned char *'} + 41 | open (const char *__path, int __oflag, ...) + | ~~~~~~~~~~~~^~~~~~ sftp_bind.c:1690:46: warning: pointer targets in passing argument 2 of 'lsftp_concat' differ in signedness [-Wpointer-sign] 1690 | prefixed_fname = lsftp_concat( prefix, fname ); | ^~~~~ @@ -1519,6 +1476,18 @@ misc_fun.h:40:49: note: expected 'const char *' but argument is of type 'uint8_t *' {aka 'unsigned char *'} 40 | char* lsftp_concat( const char* s1, const char* s2 ); | ~~~~~~~~~~~~^~ +sftp_c.c:938:29: warning: unused parameter 'fnamelen' [-Wunused-parameter] + 938 | uint32_t fnamelen, + | ~~~~~~~~~^~~~~~~~ +rl.c: In function 'lsftp_rl_no_generator': +rl.c:457:36: warning: unused parameter 'text' [-Wunused-parameter] + 457 | char* lsftp_rl_no_generator (char* text, int state) + | ~~~~~~^~~~ +rl.c: In function 'lsftp_rl_history_fname': +rl.c:522:9: warning: unused variable 'username' [-Wunused-variable] + 522 | char* username; + | ^~~~~~~~ +sftp_c.c: In function 'sftp_put_file_init': sftp_bind.c:1742:35: warning: pointer targets in passing argument 1 of 'lsftp_dc_glob_matches' differ in signedness [-Wpointer-sign] 1742 | fname, | ^~~~~ @@ -1536,15 +1505,26 @@ misc_fun.h:40:33: note: expected 'const char *' but argument is of type 'uint8_t *' {aka 'unsigned char *'} 40 | char* lsftp_concat( const char* s1, const char* s2 ); | ~~~~~~~~~~~~^~ +sftp_c.c:1262:15: warning: pointer targets in passing argument 1 of 'open' differ in signedness [-Wpointer-sign] + 1262 | ret = open( fname, O_RDONLY ); + | ^~~~~ + | | + | const uint8_t * {aka const unsigned char *} sftp_bind.c:1773:31: warning: pointer targets in passing argument 1 of 'strdup' differ in signedness [-Wpointer-sign] 1773 | tmp = strdup( fname ); | ^~~~~ | | | uint8_t * {aka unsigned char *} +/usr/include/aarch64-linux-gnu/bits/fcntl2.h:41:19: note: expected 'const char *' but argument is of type 'const uint8_t *' {aka 'const unsigned char *'} + 41 | open (const char *__path, int __oflag, ...) + | ~~~~~~~~~~~~^~~~~~ In file included from sftp_bind.h:58: /usr/include/string.h:187:34: note: expected 'const char *' but argument is of type 'uint8_t *' {aka 'unsigned char *'} 187 | extern char *strdup (const char *__s) | ~~~~~~~~~~~~^~~ +sftp_c.c:1239:29: warning: unused parameter 'fnamelen' [-Wunused-parameter] + 1239 | uint32_t fnamelen, + | ~~~~~~~~~^~~~~~~~ sftp_bind.c:1780:45: warning: pointer targets in passing argument 1 of 'strdup' differ in signedness [-Wpointer-sign] 1780 | longstrings[used-1] = strdup( longname ); | ^~~~~~~~ @@ -1601,6 +1581,10 @@ /usr/include/string.h:187:34: note: expected 'const char *' but argument is of type 'uint8_t *' {aka 'unsigned char *'} 187 | extern char *strdup (const char *__s) | ~~~~~~~~~~~~^~~ +commands.c: In function 'com_lcd': +commands.c:1868:7: warning: variable 'ret' set but not used [-Wunused-but-set-variable] + 1868 | int ret; + | ^~~ sftp_bind.c: In function 'lsftp_do_chown': sftp_bind.c:2301:25: warning: pointer targets in passing argument 5 of 'sftp_setstat_init' differ in signedness [-Wpointer-sign] 2301 | tmp, strlen( tmp ), @@ -1619,7 +1603,6 @@ sftp_c.h:226:34: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'const char *' 226 | const uint8_t *name, | ~~~~~~~~~~~~~~~^~~~ -gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o misc_fun.o misc_fun.c sftp_bind.c: In function 'lsftp_handle_stat': sftp_bind.c:2390:9: warning: unused variable 'f' [-Wunused-variable] 2390 | void* f; @@ -1641,7 +1624,6 @@ sftp_c.h:147:33: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'const char *' 147 | const uint8_t *dstname, | ~~~~~~~~~~~~~~~^~~~~~~ -gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o buffer.o buffer.c sftp_bind.c: In function 'lsftp_do_ln': sftp_bind.c:2529:25: warning: pointer targets in passing argument 5 of 'sftp_symlink_init' differ in signedness [-Wpointer-sign] 2529 | tmp1, @@ -1659,6 +1641,7 @@ sftp_c.h:135:34: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'const char *' 135 | const uint8_t *targetname, | ~~~~~~~~~~~~~~~^~~~~~~~~~ +gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o misc_fun.o misc_fun.c sftp_bind.c: In function 'lsftp_do_mkdir': sftp_bind.c:2598:23: warning: pointer targets in passing argument 5 of 'sftp_mkdir_init' differ in signedness [-Wpointer-sign] 2598 | tmp, @@ -1668,6 +1651,21 @@ sftp_c.h:165:32: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'const char *' 165 | const uint8_t *name, | ~~~~~~~~~~~~~~~^~~~ +commands.c: In function 'handle_command': +commands.c:2144:29: warning: pointer targets in initialization of 'const char *' from 'const unsigned char *' differ in signedness [-Wpointer-sign] + 2144 | const char *entered_cmd = s; + | ^ +commands.c:2149:20: warning: pointer targets in passing argument 1 of 'lsftp_s_skip' differ in signedness [-Wpointer-sign] + 2149 | s = lsftp_s_skip(s," \n\t\r"); /* Skip any initial whitespace */ + | ^ + | | + | const unsigned char * +In file included from sftp_bind.h:63, + from commands.h:41, + from commands.c:31: +str_utils.h:42:38: note: expected 'const char *' but argument is of type 'const unsigned char *' + 42 | const char *lsftp_s_skip(const char *s, const char *sep); + | ~~~~~~~~~~~~^ sftp_bind.c: In function 'lsftp_do_rmdir': sftp_bind.c:2652:23: warning: pointer targets in passing argument 5 of 'sftp_rmdir_init' differ in signedness [-Wpointer-sign] 2652 | tmp, @@ -1678,6 +1676,36 @@ 174 | const uint8_t *name, | ~~~~~~~~~~~~~~~^~~~ sftp_bind.c: In function 'lsftp_do_rm': +commands.c:2149:5: warning: pointer targets in assignment from 'const char *' to 'const unsigned char *' differ in signedness [-Wpointer-sign] + 2149 | s = lsftp_s_skip(s," \n\t\r"); /* Skip any initial whitespace */ + | ^ +commands.c:2158:25: warning: pointer targets in passing argument 1 of 'com_escape' differ in signedness [-Wpointer-sign] + 2158 | return com_escape( s+1, entered_cmd ); + | ~^~ + | | + | const unsigned char * +commands.c:352:24: note: expected 'const char *' but argument is of type 'const unsigned char *' + 352 | com_escape(const char *arg, const char *command UNUSED) + | ~~~~~~~~~~~~^~~ +commands.c:2161:27: warning: pointer targets in passing argument 1 of 'com_longhelp' differ in signedness [-Wpointer-sign] + 2161 | return com_longhelp( s+1, entered_cmd ); + | ~^~ + | | + | const unsigned char * +commands.c:244:26: note: expected 'const char *' but argument is of type 'const unsigned char *' + 244 | com_longhelp(const char *arg, const char *command UNUSED) + | ~~~~~~~~~~~~^~~ +commands.c:2165:22: warning: pointer targets in passing argument 1 of 'lsftp_s_strtok' differ in signedness [-Wpointer-sign] + 2165 | s = lsftp_s_strtok(s," \n\t\r", &tmp ); + | ^ + | | + | const unsigned char * +str_utils.h:39:40: note: expected 'const char *' but argument is of type 'const unsigned char *' + 39 | const char *lsftp_s_strtok(const char *s, const char* tok, + | ~~~~~~~~~~~~^ +commands.c:2165:5: warning: pointer targets in assignment from 'const char *' to 'const unsigned char *' differ in signedness [-Wpointer-sign] + 2165 | s = lsftp_s_strtok(s," \n\t\r", &tmp ); + | ^ sftp_bind.c:2702:24: warning: pointer targets in passing argument 5 of 'sftp_remove_init' differ in signedness [-Wpointer-sign] 2702 | tmp, | ^~~ @@ -1686,6 +1714,15 @@ sftp_c.h:157:33: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'const char *' 157 | const uint8_t *name, | ~~~~~~~~~~~~~~~^~~~ +commands.c:2184:50: warning: pointer targets in passing argument 1 of 'lsftp_s_skip' differ in signedness [-Wpointer-sign] + 2184 | lsftp_s_skip(s," \n\t\r"), + | ^ + | | + | const unsigned char * +str_utils.h:42:38: note: expected 'const char *' but argument is of type 'const unsigned char *' + 42 | const char *lsftp_s_skip(const char *s, const char *sep); + | ~~~~~~~~~~~~^ +gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o buffer.o buffer.c misc_fun.c: In function 'mgetenv_init': misc_fun.c:61:27: warning: unused parameter 'envp' [-Wunused-parameter] 61 | void mgetenv_init( char** envp ) @@ -1694,6 +1731,7 @@ misc_fun.c:68:38: warning: unused parameter 'local' [-Wunused-parameter] 68 | char* massage_fname(char* fname, int local) | ~~~~^~~~~ +gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o io_input.o io_input.c buffer.c: In function 'sftp_put_printf': buffer.c:149:26: warning: pointer targets in passing argument 1 of 'vsnprintf' differ in signedness [-Wpointer-sign] 149 | length = vsnprintf(current, needed, format, args); @@ -1718,7 +1756,6 @@ /usr/include/time.h:100:42: note: expected 'char * restrict' but argument is of type 'uint8_t *' {aka 'unsigned char *'} 100 | extern size_t strftime (char *__restrict __s, size_t __maxsize, | ~~~~~~~~~~~~~~~~~^~~ -gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o io_input.o io_input.c misc_fun.c: In function 'lsftp_concat': misc_fun.c:102:3: warning: '__builtin_strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation] 102 | strncpy( ret, s1, i1 ); @@ -1732,40 +1769,38 @@ misc_fun.c:95:8: note: length computed here 95 | i2 = strlen( s2 ); | ^~~~~~~~~~~~ -gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o io_output.o io_output.c io_input.c: In function 'sftp_read_packet': io_input.c:149:20: warning: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Wsign-compare] 149 | while (bytesread < sizeof(buf)) | ^ +gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o io_output.o io_output.c gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o xmalloc.o xmalloc.c +gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o werror.o werror.c +gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o sftp-test-client.o sftp-test-client.c io_output.c: In function 'sftp_write_packet': io_output.c:196:17: warning: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Wsign-compare] 196 | while (writteni) | ^ -gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o werror.o werror.c -gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o sftp-test-client.o sftp-test-client.c gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o client.o client.c -gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o dump-hex.o dump-hex.c -client.c: In function 'sftp_open': -client.c:110:41: warning: pointer targets in passing argument 3 of 'sftp_put_string' differ in signedness [-Wpointer-sign] - 110 | sftp_put_string(ctx->o, strlen(name), name ); +sftp-test-client.c: In function 'do_ls': +sftp-test-client.c:168:41: warning: pointer targets in passing argument 3 of 'sftp_put_string' differ in signedness [-Wpointer-sign] + 168 | sftp_put_string(ctx->o, strlen(name), name); | ^~~~ | | | const char * -In file included from client.h:29, - from client.c:32: +In file included from io.h:24, + from sftp-test-client.c:38: buffer.h:108:72: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'const char *' 108 | sftp_put_string(struct sftp_output *o, uint32_t length, const uint8_t *data); | ~~~~~~~~~~~~~~~^~~~ -gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o sftp-server.o sftp-server.c -sftp-test-client.c: In function 'do_ls': -sftp-test-client.c:168:41: warning: pointer targets in passing argument 3 of 'sftp_put_string' differ in signedness [-Wpointer-sign] - 168 | sftp_put_string(ctx->o, strlen(name), name); +client.c: In function 'sftp_open': +client.c:110:41: warning: pointer targets in passing argument 3 of 'sftp_put_string' differ in signedness [-Wpointer-sign] + 110 | sftp_put_string(ctx->o, strlen(name), name ); | ^~~~ | | | const char * -In file included from io.h:24, - from sftp-test-client.c:38: +In file included from client.h:29, + from client.c:32: buffer.h:108:72: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'const char *' 108 | sftp_put_string(struct sftp_output *o, uint32_t length, const uint8_t *data); | ~~~~~~~~~~~~~~~^~~~ @@ -1778,6 +1813,7 @@ buffer.h:108:72: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'const char *' 108 | sftp_put_string(struct sftp_output *o, uint32_t length, const uint8_t *data); | ~~~~~~~~~~~~~~~^~~~ +gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o dump-hex.o dump-hex.c sftp-test-client.c: In function 'do_stat': sftp-test-client.c:526:41: warning: pointer targets in passing argument 3 of 'sftp_put_string' differ in signedness [-Wpointer-sign] 526 | sftp_put_string(ctx->o, strlen(name), name); @@ -1787,7 +1823,9 @@ buffer.h:108:72: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'const char *' 108 | sftp_put_string(struct sftp_output *o, uint32_t length, const uint8_t *data); | ~~~~~~~~~~~~~~~^~~~ +gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o sftp-server.o sftp-server.c gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o filemode.o filemode.c +gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o idcache.o idcache.c dump-hex.c: In function 'main': dump-hex.c:189:33: warning: pointer targets in passing argument 2 of 'do_read' differ in signedness [-Wpointer-sign] 189 | res = do_read(STDIN_FILENO, buf, left); @@ -1813,7 +1851,25 @@ dump-hex.c:50:30: note: expected 'const char *' but argument is of type 'unsigned char *' 50 | do_write(int fd, const char *data, int length) | ~~~~~~~~~~~~^~~~ -gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DTRANSPORT_PROG='"/usr/bin/lshg"' -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -c -o idcache.o idcache.c +sftp_bind.c: In function 'lsftp_handle_ls': +sftp_bind.c:1721:21: warning: pointer 'namestrings' may be used after 'realloc' [-Wuse-after-free] + 1721 | printf( "%s\n", namestrings[l] ); + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +sftp_bind.c:1698:35: note: call to 'realloc' here + 1698 | char** newnamestrings = realloc( namestrings, sizeof( char* ) * ( allocated + allocstepsize ) ); + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +sftp_bind.c:1723:19: warning: pointer 'namestrings' may be used after 'realloc' [-Wuse-after-free] + 1723 | free( namestrings[l] ); + | ^~~~~~~~~~~~~~~~~~~~~~ +sftp_bind.c:1698:35: note: call to 'realloc' here + 1698 | char** newnamestrings = realloc( namestrings, sizeof( char* ) * ( allocated + allocstepsize ) ); + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +sftp_bind.c:1726:15: warning: pointer 'namestrings' may be used after 'realloc' [-Wuse-after-free] + 1726 | free( namestrings ); + | ^~~~~~~~~~~~~~~~~~~ +sftp_bind.c:1698:35: note: call to 'realloc' here + 1698 | char** newnamestrings = realloc( namestrings, sizeof( char* ) * ( allocated + allocstepsize ) ); + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sftp-server.c: In function 'sftp_put_longname_mode': sftp-server.c:229:22: warning: pointer targets in passing argument 2 of 'filemodestring' differ in signedness [-Wpointer-sign] 229 | filemodestring(st, modes); @@ -2141,25 +2197,7 @@ /usr/include/unistd.h:832:53: note: expected 'const char *' but argument is of type 'const uint8_t *' {aka 'const unsigned char *'} 832 | extern int symlink (const char *__from, const char *__to) | ~~~~~~~~~~~~^~~~ -sftp_bind.c: In function 'lsftp_handle_ls': -sftp_bind.c:1721:21: warning: pointer 'namestrings' may be used after 'realloc' [-Wuse-after-free] - 1721 | printf( "%s\n", namestrings[l] ); - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -sftp_bind.c:1698:35: note: call to 'realloc' here - 1698 | char** newnamestrings = realloc( namestrings, sizeof( char* ) * ( allocated + allocstepsize ) ); - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -sftp_bind.c:1723:19: warning: pointer 'namestrings' may be used after 'realloc' [-Wuse-after-free] - 1723 | free( namestrings[l] ); - | ^~~~~~~~~~~~~~~~~~~~~~ -sftp_bind.c:1698:35: note: call to 'realloc' here - 1698 | char** newnamestrings = realloc( namestrings, sizeof( char* ) * ( allocated + allocstepsize ) ); - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -sftp_bind.c:1726:15: warning: pointer 'namestrings' may be used after 'realloc' [-Wuse-after-free] - 1726 | free( namestrings ); - | ^~~~~~~~~~~~~~~~~~~ -sftp_bind.c:1698:35: note: call to 'realloc' here - 1698 | char** newnamestrings = realloc( namestrings, sizeof( char* ) * ( allocated + allocstepsize ) ); - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o sftp-test-client sftp-test-client.o buffer.o io_input.o io_output.o xmalloc.o werror.o client.o -lreadline -lreadline -ltermcap gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o dump-hex dump-hex.o -lreadline -lreadline -ltermcap commands.c: In function 'put_file_or_folder.isra': commands.c:1342:34: warning: pointer 'tmp' may be used after 'free' [-Wuse-after-free] @@ -2192,9 +2230,8 @@ commands.c:1295:3: note: call to 'free' here 1295 | free( tmp ); | ^~~~~~~~~~~ -gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o sftp-test-client sftp-test-client.o buffer.o io_input.o io_output.o xmalloc.o werror.o client.o -lreadline -lreadline -ltermcap -gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o lsftp commands.o lsftp.o rl.o sftp_c.o sftp_bind.o str_utils.o dc.o gnu_stuff.o misc_fun.o buffer.o io_input.o io_output.o xmalloc.o werror.o -lreadline -lreadline -ltermcap gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o sftp-server sftp-server.o buffer.o io_input.o io_output.o xmalloc.o werror.o filemode.o idcache.o -lreadline -lreadline -ltermcap +gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wcast-align -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o lsftp commands.o lsftp.o rl.o sftp_c.o sftp_bind.o str_utils.o dc.o gnu_stuff.o misc_fun.o buffer.o io_input.o io_output.o xmalloc.o werror.o -lreadline -lreadline -ltermcap make[7]: Leaving directory '/build/lsh-utils-2.1/src/sftp' Making all in testsuite make[7]: Entering directory '/build/lsh-utils-2.1/src/sftp/testsuite' @@ -2363,73 +2400,6 @@ gcc -DHAVE_CONFIG_H -I. -I.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o sign.o sign.c gcc -DHAVE_CONFIG_H -I. -I.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o spki-delegate.o spki-delegate.c gcc -DHAVE_CONFIG_H -I. -I.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o spki-reduce.o spki-reduce.c -misc.c: In function 'hash_file': -misc.c:67:30: warning: pointer targets in passing argument 3 of 'hash->update' differ in signedness [-Wpointer-sign] - 67 | hash->update(ctx, res, buffer); - | ^~~~~~ - | | - | char * -misc.c:67:30: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'char *' -spki-reduce.c: In function 'process_acls': -spki-reduce.c:115:55: warning: pointer targets in passing argument 3 of 'spki_transport_iterator_first' differ in signedness [-Wpointer-sign] - 115 | && spki_transport_iterator_first(&i, length, data) - | ^~~~ - | | - | char * -In file included from spki-reduce.c:31: -../parse.h:67:57: note: expected 'uint8_t *' {aka 'unsigned char *'} but argument is of type 'char *' - 67 | unsigned length, uint8_t *expr); - | ~~~~~~~~~^~~~ -spki-reduce.c: In function 'process_sequence': -spki-reduce.c:136:52: warning: pointer targets in passing argument 3 of 'spki_transport_iterator_first' differ in signedness [-Wpointer-sign] - 136 | && spki_transport_iterator_first(&i, length, data)) - | ^~~~ - | | - | char * -../parse.h:67:57: note: expected 'uint8_t *' {aka 'unsigned char *'} but argument is of type 'char *' - 67 | unsigned length, uint8_t *expr); - | ~~~~~~~~~^~~~ -spki-reduce.c: In function 'main': -spki-reduce.c:187:46: warning: pointer targets in passing argument 3 of 'write_file' differ in signedness [-Wpointer-sign] - 187 | if (!write_file(stdout, buffer.size, buffer.contents)) - | ~~~~~~^~~~~~~~~ - | | - | uint8_t * {aka unsigned char *} -In file included from spki-reduce.c:34: -misc.h:48:48: note: expected 'const char *' but argument is of type 'uint8_t *' {aka 'unsigned char *'} - 48 | write_file(FILE *f, unsigned size, const char *buffer); - | ~~~~~~~~~~~~^~~~~~ -spki-reduce.c: In function 'parse_options': -spki-reduce.c:89:11: warning: this statement may fall through [-Wimplicit-fallthrough=] - 89 | die("spki-delegate --version not implemented\n"); - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -spki-reduce.c:91:9: note: here - 91 | case 'a': - | ^~~~ -spki-check-signature.c: In function 'main': -spki-check-signature.c:116:66: warning: pointer targets in passing argument 3 of 'nettle_sexp_transport_iterator_first' differ in signedness [-Wpointer-sign] - 116 | if (sexp_transport_iterator_first(&sexp, strlen(o.signature), o.signature) - | ~^~~~~~~~~~ - | | - | char * -In file included from ../parse.h:26, - from spki-check-signature.c:32: -/usr/include/nettle/sexp.h:95:55: note: expected 'uint8_t *' {aka 'unsigned char *'} but argument is of type 'char *' - 95 | size_t length, uint8_t *input); - | ~~~~~~~~~^~~~~ -spki-check-signature.c:130:13: warning: this statement may fall through [-Wimplicit-fallthrough=] - 130 | die("Unsupported hash algorithm."); - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -spki-check-signature.c:131:11: note: here - 131 | case SPKI_TYPE_MD5: - | ^~~~ -spki-check-signature.c: In function 'parse_options': -spki-check-signature.c:88:11: warning: this statement may fall through [-Wimplicit-fallthrough=] - 88 | die("spki-check-signature --version not implemented\n"); - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -spki-check-signature.c:90:9: note: here - 90 | case 'n': - | ^~~~ spki-delegate.c: In function 'process_principal': spki-delegate.c:157:55: warning: pointer targets in passing argument 3 of 'spki_transport_iterator_first' differ in signedness [-Wpointer-sign] 157 | if (spki_transport_iterator_first(&i, strlen(expr), expr) @@ -2461,6 +2431,31 @@ spki-delegate.c:213:19: warning: pointer targets in assignment from 'const uint8_t *' {aka 'const unsigned char *'} to 'const char *' differ in signedness [-Wpointer-sign] 213 | && (tag = spki_parse_prevexpr(&i, start, &tag_length))) | ^ +spki-delegate.c: In function 'main': +spki-delegate.c:301:60: warning: pointer targets in passing argument 3 of 'spki_transport_iterator_first' differ in signedness [-Wpointer-sign] + 301 | if (! (spki_transport_iterator_first(&i, key_length, key) + | ^~~ + | | + | char * +../parse.h:67:57: note: expected 'uint8_t *' {aka 'unsigned char *'} but argument is of type 'char *' + 67 | unsigned length, uint8_t *expr); + | ~~~~~~~~~^~~~ +spki-delegate.c:319:38: warning: pointer targets in passing argument 3 of 'write_file' differ in signedness [-Wpointer-sign] + 319 | buffer.size, buffer.contents)) + | ~~~~~~^~~~~~~~~ + | | + | uint8_t * {aka unsigned char *} +In file included from spki-delegate.c:38: +misc.h:48:48: note: expected 'const char *' but argument is of type 'uint8_t *' {aka 'unsigned char *'} + 48 | write_file(FILE *f, unsigned size, const char *buffer); + | ~~~~~~~~~~~~^~~~~~ +spki-delegate.c: In function 'parse_options': +spki-delegate.c:114:11: warning: this statement may fall through [-Wimplicit-fallthrough=] + 114 | die("spki-delegate --version not implemented\n"); + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +spki-delegate.c:116:9: note: here + 116 | case 'i': + | ^~~~ spki-make-signature.c: In function 'main': spki-make-signature.c:136:56: warning: pointer targets in passing argument 3 of 'spki_transport_iterator_first' differ in signedness [-Wpointer-sign] 136 | if (! (spki_transport_iterator_first(&i, key_length, key) @@ -2499,30 +2494,72 @@ spki-make-signature.c:101:9: note: here 101 | case 's': | ^~~~ -spki-delegate.c: In function 'main': -spki-delegate.c:301:60: warning: pointer targets in passing argument 3 of 'spki_transport_iterator_first' differ in signedness [-Wpointer-sign] - 301 | if (! (spki_transport_iterator_first(&i, key_length, key) - | ^~~ - | | - | char * +misc.c: In function 'hash_file': +misc.c:67:30: warning: pointer targets in passing argument 3 of 'hash->update' differ in signedness [-Wpointer-sign] + 67 | hash->update(ctx, res, buffer); + | ^~~~~~ + | | + | char * +misc.c:67:30: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'char *' +spki-reduce.c: In function 'process_acls': +spki-reduce.c:115:55: warning: pointer targets in passing argument 3 of 'spki_transport_iterator_first' differ in signedness [-Wpointer-sign] + 115 | && spki_transport_iterator_first(&i, length, data) + | ^~~~ + | | + | char * +In file included from spki-reduce.c:31: ../parse.h:67:57: note: expected 'uint8_t *' {aka 'unsigned char *'} but argument is of type 'char *' 67 | unsigned length, uint8_t *expr); | ~~~~~~~~~^~~~ -spki-delegate.c:319:38: warning: pointer targets in passing argument 3 of 'write_file' differ in signedness [-Wpointer-sign] - 319 | buffer.size, buffer.contents)) - | ~~~~~~^~~~~~~~~ - | | - | uint8_t * {aka unsigned char *} -In file included from spki-delegate.c:38: +spki-reduce.c: In function 'process_sequence': +spki-reduce.c:136:52: warning: pointer targets in passing argument 3 of 'spki_transport_iterator_first' differ in signedness [-Wpointer-sign] + 136 | && spki_transport_iterator_first(&i, length, data)) + | ^~~~ + | | + | char * +../parse.h:67:57: note: expected 'uint8_t *' {aka 'unsigned char *'} but argument is of type 'char *' + 67 | unsigned length, uint8_t *expr); + | ~~~~~~~~~^~~~ +spki-reduce.c: In function 'main': +spki-reduce.c:187:46: warning: pointer targets in passing argument 3 of 'write_file' differ in signedness [-Wpointer-sign] + 187 | if (!write_file(stdout, buffer.size, buffer.contents)) + | ~~~~~~^~~~~~~~~ + | | + | uint8_t * {aka unsigned char *} +In file included from spki-reduce.c:34: misc.h:48:48: note: expected 'const char *' but argument is of type 'uint8_t *' {aka 'unsigned char *'} 48 | write_file(FILE *f, unsigned size, const char *buffer); | ~~~~~~~~~~~~^~~~~~ -spki-delegate.c: In function 'parse_options': -spki-delegate.c:114:11: warning: this statement may fall through [-Wimplicit-fallthrough=] - 114 | die("spki-delegate --version not implemented\n"); +spki-reduce.c: In function 'parse_options': +spki-reduce.c:89:11: warning: this statement may fall through [-Wimplicit-fallthrough=] + 89 | die("spki-delegate --version not implemented\n"); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -spki-delegate.c:116:9: note: here - 116 | case 'i': +spki-reduce.c:91:9: note: here + 91 | case 'a': + | ^~~~ +spki-check-signature.c: In function 'main': +spki-check-signature.c:116:66: warning: pointer targets in passing argument 3 of 'nettle_sexp_transport_iterator_first' differ in signedness [-Wpointer-sign] + 116 | if (sexp_transport_iterator_first(&sexp, strlen(o.signature), o.signature) + | ~^~~~~~~~~~ + | | + | char * +In file included from ../parse.h:26, + from spki-check-signature.c:32: +/usr/include/nettle/sexp.h:95:55: note: expected 'uint8_t *' {aka 'unsigned char *'} but argument is of type 'char *' + 95 | size_t length, uint8_t *input); + | ~~~~~~~~~^~~~~ +spki-check-signature.c:130:13: warning: this statement may fall through [-Wimplicit-fallthrough=] + 130 | die("Unsupported hash algorithm."); + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +spki-check-signature.c:131:11: note: here + 131 | case SPKI_TYPE_MD5: + | ^~~~ +spki-check-signature.c: In function 'parse_options': +spki-check-signature.c:88:11: warning: this statement may fall through [-Wimplicit-fallthrough=] + 88 | die("spki-check-signature --version not implemented\n"); + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +spki-check-signature.c:90:9: note: here + 90 | case 'n': | ^~~~ gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o spki-check-signature spki-check-signature.o misc.o getopt.o getopt1.o ../libspki.a -lhogweed -lnettle -lgmp gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o spki-reduce spki-reduce.o misc.o getopt.o getopt1.o ../libspki.a -lhogweed -lnettle -lgmp @@ -2539,49 +2576,36 @@ gcc -DHAVE_CONFIG_H -I. -I.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o lookup-acl-test.o lookup-acl-test.c gcc -DHAVE_CONFIG_H -I. -I.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o read-cert-test.o read-cert-test.c gcc -DHAVE_CONFIG_H -I. -I.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o cdsa-reduce-test.o cdsa-reduce-test.c -cdsa-reduce-test.c: In function 'test_main': -cdsa-reduce-test.c:140:14: warning: pointer targets in assignment from 'char *' to 'uint8_t *' {aka 'unsigned char *'} differ in signedness [-Wpointer-sign] - 140 | data = read_file(srcdir, "cdsa-cases/", i, ".in", - | ^ -In file included from read-cert-test.c:1: -read-cert-test.c: In function 'test_main': -read-cert-test.c:23:19: warning: pointer targets in passing argument 4 of 'read_cert' differ in signedness [-Wpointer-sign] - 23 | LDATA("(4:cert(6:issuer(10:public-key2:k1))" - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - | | - | char * -testutils.h:30:35: note: in definition of macro 'LDATA' - 30 | #define LDATA(x) (sizeof(x) - 1), x - | ^ -read-cert-test.c:5:43: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'char *' - 5 | unsigned length, const uint8_t *data) - | ~~~~~~~~~~~~~~~^~~~ -read-cert-test.c:30:43: warning: pointer targets in passing argument 3 of 'spki_principal_by_key' differ in signedness [-Wpointer-sign] - 30 | spki_principal_by_key(&db, LDATA("(10:public-key2:k1)"))); - | ^~~~~~~~~~~~~~~~~~~~~ - | | - | char * +principal-test.c: In function 'test_main': +principal-test.c:11:37: warning: pointer targets in passing argument 3 of 'spki_principal_by_key' differ in signedness [-Wpointer-sign] + 11 | s = spki_principal_by_key(&db, 5, "3:foo"); + | ^~~~~~~ + | | + | char * +In file included from testutils.h:5, + from principal-test.c:1: +../certificate.h:221:59: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'char *' + 221 | unsigned key_length, const uint8_t *key); + | ~~~~~~~~~~~~~~~^~~ +principal-test.c:14:40: warning: pointer targets in passing argument 3 of 'spki_principal_by_key' differ in signedness [-Wpointer-sign] + 14 | ASSERT(spki_principal_by_key(&db, 5, "3:foo") == s); + | ^~~~~~~ + | | + | char * testutils.h:27:30: note: in definition of macro 'ASSERT' 27 | #define ASSERT(x) do { if (!(x)) FAIL("ASSERT failure: " #x); } while(0) | ^ -read-cert-test.c:30:37: note: in expansion of macro 'LDATA' - 30 | spki_principal_by_key(&db, LDATA("(10:public-key2:k1)"))); - | ^~~~~ -In file included from testutils.h:5: ../certificate.h:221:59: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'char *' 221 | unsigned key_length, const uint8_t *key); | ~~~~~~~~~~~~~~~^~~ -read-cert-test.c:32:43: warning: pointer targets in passing argument 3 of 'spki_principal_by_key' differ in signedness [-Wpointer-sign] - 32 | spki_principal_by_key(&db, LDATA("(10:public-key2:k2)"))); - | ^~~~~~~~~~~~~~~~~~~~~ - | | - | char * +principal-test.c:15:40: warning: pointer targets in passing argument 3 of 'spki_principal_by_key' differ in signedness [-Wpointer-sign] + 15 | ASSERT(spki_principal_by_key(&db, 5, "3:bar") != s); + | ^~~~~~~ + | | + | char * testutils.h:27:30: note: in definition of macro 'ASSERT' 27 | #define ASSERT(x) do { if (!(x)) FAIL("ASSERT failure: " #x); } while(0) | ^ -read-cert-test.c:32:37: note: in expansion of macro 'LDATA' - 32 | spki_principal_by_key(&db, LDATA("(10:public-key2:k2)"))); - | ^~~~~ ../certificate.h:221:59: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'char *' 221 | unsigned key_length, const uint8_t *key); | ~~~~~~~~~~~~~~~^~~ @@ -3097,17 +3121,6 @@ tag-test.c:5:43: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'char *' 5 | unsigned blength, const uint8_t *bdata) | ~~~~~~~~~~~~~~~^~~~~ -principal-test.c: In function 'test_main': -principal-test.c:11:37: warning: pointer targets in passing argument 3 of 'spki_principal_by_key' differ in signedness [-Wpointer-sign] - 11 | s = spki_principal_by_key(&db, 5, "3:foo"); - | ^~~~~~~ - | | - | char * -In file included from testutils.h:5, - from principal-test.c:1: -../certificate.h:221:59: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'char *' - 221 | unsigned key_length, const uint8_t *key); - | ~~~~~~~~~~~~~~~^~~ tag-test.c:61:20: warning: pointer targets in passing argument 2 of 'includes' differ in signedness [-Wpointer-sign] 61 | ASSERT(!INCLUDES("(1:*3:set(3:foo)(3:bar))", | ^~~~~~~~~~~~~~~~~~~~~~~~~~ @@ -3142,67 +3155,8 @@ tag-test.c:5:43: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'char *' 5 | unsigned blength, const uint8_t *bdata) | ~~~~~~~~~~~~~~~^~~~~ -principal-test.c:14:40: warning: pointer targets in passing argument 3 of 'spki_principal_by_key' differ in signedness [-Wpointer-sign] - 14 | ASSERT(spki_principal_by_key(&db, 5, "3:foo") == s); - | ^~~~~~~ - | | - | char * -testutils.h:27:30: note: in definition of macro 'ASSERT' - 27 | #define ASSERT(x) do { if (!(x)) FAIL("ASSERT failure: " #x); } while(0) - | ^ -../certificate.h:221:59: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'char *' - 221 | unsigned key_length, const uint8_t *key); - | ~~~~~~~~~~~~~~~^~~ -principal-test.c:15:40: warning: pointer targets in passing argument 3 of 'spki_principal_by_key' differ in signedness [-Wpointer-sign] - 15 | ASSERT(spki_principal_by_key(&db, 5, "3:bar") != s); - | ^~~~~~~ - | | - | char * -testutils.h:27:30: note: in definition of macro 'ASSERT' - 27 | #define ASSERT(x) do { if (!(x)) FAIL("ASSERT failure: " #x); } while(0) - | ^ -../certificate.h:221:59: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'char *' - 221 | unsigned key_length, const uint8_t *key); - | ~~~~~~~~~~~~~~~^~~ -In file included from read-acl-test.c:1: -read-acl-test.c: In function 'test_main': -read-acl-test.c:11:13: warning: pointer targets in passing argument 3 of 'read_acl' differ in signedness [-Wpointer-sign] - 11 | ("(3:acl(7:version1:\0)(5:entry" - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - | | - | char * -testutils.h:30:35: note: in definition of macro 'LDATA' - 30 | #define LDATA(x) (sizeof(x) - 1), x - | ^ -testutils.h:17:42: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'char *' - 17 | unsigned length, const uint8_t *data); - | ~~~~~~~~~~~~~~~^~~~ -read-acl-test.c:17:43: warning: pointer targets in passing argument 3 of 'spki_principal_by_key' differ in signedness [-Wpointer-sign] - 17 | ASSERT(spki_principal_by_key(&db, LDATA("k1"))); - | ^~~~ - | | - | char * -testutils.h:27:30: note: in definition of macro 'ASSERT' - 27 | #define ASSERT(x) do { if (!(x)) FAIL("ASSERT failure: " #x); } while(0) - | ^ -read-acl-test.c:17:37: note: in expansion of macro 'LDATA' - 17 | ASSERT(spki_principal_by_key(&db, LDATA("k1"))); - | ^~~~~ -In file included from testutils.h:5: -../certificate.h:221:59: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'char *' - 221 | unsigned key_length, const uint8_t *key); - | ~~~~~~~~~~~~~~~^~~ -read-acl-test.c:18:37: warning: pointer targets in passing argument 2 of 'spki_principal_by_md5' differ in signedness [-Wpointer-sign] - 18 | ASSERT(spki_principal_by_md5(&db, "xxxxxxxxxxxxxxxx")); - | ^~~~~~~~~~~~~~~~~~ - | | - | char * -testutils.h:27:30: note: in definition of macro 'ASSERT' - 27 | #define ASSERT(x) do { if (!(x)) FAIL("ASSERT failure: " #x); } while(0) - | ^ -../certificate.h:224:62: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'char *' - 224 | spki_principal_by_md5(struct spki_acl_db *db, const uint8_t *digest); - | ~~~~~~~~~~~~~~~^~~~~~ +gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o date-test date-test.o testutils.o ../libspki.a -lhogweed -lnettle -lgmp +gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o principal-test principal-test.o testutils.o ../libspki.a -lhogweed -lnettle -lgmp In file included from lookup-acl-test.c:1: lookup-acl-test.c: In function 'test_main': lookup-acl-test.c:17:13: warning: pointer targets in passing argument 3 of 'read_acl' differ in signedness [-Wpointer-sign] @@ -3305,12 +3259,95 @@ testutils.h:20:42: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'char *' 20 | make_tag(unsigned length, const uint8_t *expr); | ~~~~~~~~~~~~~~~^~~~ -gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o principal-test principal-test.o testutils.o ../libspki.a -lhogweed -lnettle -lgmp -gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o date-test date-test.o testutils.o ../libspki.a -lhogweed -lnettle -lgmp -gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o read-acl-test read-acl-test.o testutils.o ../libspki.a -lhogweed -lnettle -lgmp +In file included from read-cert-test.c:1: +read-cert-test.c: In function 'test_main': +read-cert-test.c:23:19: warning: pointer targets in passing argument 4 of 'read_cert' differ in signedness [-Wpointer-sign] + 23 | LDATA("(4:cert(6:issuer(10:public-key2:k1))" + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + | | + | char * +testutils.h:30:35: note: in definition of macro 'LDATA' + 30 | #define LDATA(x) (sizeof(x) - 1), x + | ^ +read-cert-test.c:5:43: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'char *' + 5 | unsigned length, const uint8_t *data) + | ~~~~~~~~~~~~~~~^~~~ +read-cert-test.c:30:43: warning: pointer targets in passing argument 3 of 'spki_principal_by_key' differ in signedness [-Wpointer-sign] + 30 | spki_principal_by_key(&db, LDATA("(10:public-key2:k1)"))); + | ^~~~~~~~~~~~~~~~~~~~~ + | | + | char * +testutils.h:27:30: note: in definition of macro 'ASSERT' + 27 | #define ASSERT(x) do { if (!(x)) FAIL("ASSERT failure: " #x); } while(0) + | ^ +read-cert-test.c:30:37: note: in expansion of macro 'LDATA' + 30 | spki_principal_by_key(&db, LDATA("(10:public-key2:k1)"))); + | ^~~~~ +In file included from testutils.h:5: +../certificate.h:221:59: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'char *' + 221 | unsigned key_length, const uint8_t *key); + | ~~~~~~~~~~~~~~~^~~ +read-cert-test.c:32:43: warning: pointer targets in passing argument 3 of 'spki_principal_by_key' differ in signedness [-Wpointer-sign] + 32 | spki_principal_by_key(&db, LDATA("(10:public-key2:k2)"))); + | ^~~~~~~~~~~~~~~~~~~~~ + | | + | char * +testutils.h:27:30: note: in definition of macro 'ASSERT' + 27 | #define ASSERT(x) do { if (!(x)) FAIL("ASSERT failure: " #x); } while(0) + | ^ +read-cert-test.c:32:37: note: in expansion of macro 'LDATA' + 32 | spki_principal_by_key(&db, LDATA("(10:public-key2:k2)"))); + | ^~~~~ +../certificate.h:221:59: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'char *' + 221 | unsigned key_length, const uint8_t *key); + | ~~~~~~~~~~~~~~~^~~ +In file included from read-acl-test.c:1: +read-acl-test.c: In function 'test_main': +read-acl-test.c:11:13: warning: pointer targets in passing argument 3 of 'read_acl' differ in signedness [-Wpointer-sign] + 11 | ("(3:acl(7:version1:\0)(5:entry" + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + | | + | char * +testutils.h:30:35: note: in definition of macro 'LDATA' + 30 | #define LDATA(x) (sizeof(x) - 1), x + | ^ +testutils.h:17:42: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'char *' + 17 | unsigned length, const uint8_t *data); + | ~~~~~~~~~~~~~~~^~~~ +read-acl-test.c:17:43: warning: pointer targets in passing argument 3 of 'spki_principal_by_key' differ in signedness [-Wpointer-sign] + 17 | ASSERT(spki_principal_by_key(&db, LDATA("k1"))); + | ^~~~ + | | + | char * +testutils.h:27:30: note: in definition of macro 'ASSERT' + 27 | #define ASSERT(x) do { if (!(x)) FAIL("ASSERT failure: " #x); } while(0) + | ^ +read-acl-test.c:17:37: note: in expansion of macro 'LDATA' + 17 | ASSERT(spki_principal_by_key(&db, LDATA("k1"))); + | ^~~~~ +In file included from testutils.h:5: +../certificate.h:221:59: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'char *' + 221 | unsigned key_length, const uint8_t *key); + | ~~~~~~~~~~~~~~~^~~ +read-acl-test.c:18:37: warning: pointer targets in passing argument 2 of 'spki_principal_by_md5' differ in signedness [-Wpointer-sign] + 18 | ASSERT(spki_principal_by_md5(&db, "xxxxxxxxxxxxxxxx")); + | ^~~~~~~~~~~~~~~~~~ + | | + | char * +testutils.h:27:30: note: in definition of macro 'ASSERT' + 27 | #define ASSERT(x) do { if (!(x)) FAIL("ASSERT failure: " #x); } while(0) + | ^ +../certificate.h:224:62: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'char *' + 224 | spki_principal_by_md5(struct spki_acl_db *db, const uint8_t *digest); + | ~~~~~~~~~~~~~~~^~~~~~ +cdsa-reduce-test.c: In function 'test_main': +cdsa-reduce-test.c:140:14: warning: pointer targets in assignment from 'char *' to 'uint8_t *' {aka 'unsigned char *'} differ in signedness [-Wpointer-sign] + 140 | data = read_file(srcdir, "cdsa-cases/", i, ".in", + | ^ +gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o tag-test tag-test.o testutils.o ../libspki.a -lhogweed -lnettle -lgmp gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o read-cert-test read-cert-test.o testutils.o ../libspki.a -lhogweed -lnettle -lgmp +gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o read-acl-test read-acl-test.o testutils.o ../libspki.a -lhogweed -lnettle -lgmp gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o lookup-acl-test lookup-acl-test.o testutils.o ../libspki.a -lhogweed -lnettle -lgmp -gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o tag-test tag-test.o testutils.o ../libspki.a -lhogweed -lnettle -lgmp gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o cdsa-reduce-test cdsa-reduce-test.o testutils.o ../libspki.a -lhogweed -lnettle -lgmp make check to build testprograms. make[7]: Leaving directory '/build/lsh-utils-2.1/src/spki/testsuite' @@ -3607,7 +3644,6 @@ 73 | {"forwarded-tcpip", 15}, | ^~~~~~~~~~~~~~~~~ atoms_table.c:73:4: note: (near initialization for 'atom_table[69].name') -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o channel_forward.o channel_forward.c atoms_table.c:74:4: warning: pointer targets in initialization of 'const uint8_t *' {aka 'const unsigned char *'} from 'char *' differ in signedness [-Wpointer-sign] 74 | {"direct-tcpip", 12}, | ^~~~~~~~~~~~~~ @@ -3760,12 +3796,10 @@ 111 | {"ssh-ring1", 9}, | ^~~~~~~~~~~ atoms_table.c:111:4: note: (near initialization for 'atom_table[107].name') +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o channel_forward.o channel_forward.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o charset.o charset.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o client.o client.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o client_escape.o client_escape.c -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o client_keyexchange.o client_keyexchange.c -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o client_pty.o client_pty.c -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o client_session.o client_session.c client.c: In function 'do_exit_signal': client.c:321:27: warning: pointer targets in passing argument 2 of 'parse_atom' differ in signedness [-Wpointer-sign] 321 | && parse_atom(args, &signal) @@ -3797,6 +3831,9 @@ lsh_string.h:110:33: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'char *' 110 | const uint8_t *data); | ~~~~~~~~~~~~~~~^~~~ +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o client_keyexchange.o client_keyexchange.c +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o client_pty.o client_pty.c +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o client_session.o client_session.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o client_userauth.o client_userauth.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o client_x11.o client_x11.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o combinators.o combinators.c @@ -3804,6 +3841,7 @@ gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o compress.o compress.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o parse_config.o parse_config.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o connection.o connection.c +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o connection_commands.o connection_commands.c parse_config.c: In function 'next_token': parse_config.c:156:25: warning: pointer targets in assignment from 'const uint8_t *' {aka 'const unsigned char *'} to 'const char *' differ in signedness [-Wpointer-sign] 156 | self->token = HERE; @@ -3818,11 +3856,8 @@ lsh_string.h:89:77: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'const char *' 89 | lsh_string_eq_l(const struct lsh_string *a, uint32_t length, const uint8_t *b); | ~~~~~~~~~~~~~~~^ -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o connection_commands.o connection_commands.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o crypto.o crypto.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o daemon.o daemon.c -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o debug.o debug.c -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o dh_exchange.o dh_exchange.c crypto.c: In function 'do_aes_cbc_encrypt': crypto.c:117:26: warning: 'nettle_aes_encrypt' is deprecated [-Wdeprecated-declarations] 117 | (nettle_crypt_func*) aes_encrypt, @@ -3865,8 +3900,12 @@ /usr/include/nettle/aes.h:158:1: note: declared here 158 | aes_set_encrypt_key(struct aes_ctx *ctx, | ^~~~~~~~~~~~~~~~~~~ +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o debug.o debug.c +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o dh_exchange.o dh_exchange.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o dsa.o dsa.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o exception.o exception.c +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o format.o format.c +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o gc.o gc.c dsa.c: In function 'do_dsa_verify': dsa.c:138:37: warning: pointer targets in initialization of 'const uint8_t *' {aka 'const unsigned char *'} from 'char *' differ in signedness [-Wpointer-sign] 138 | const uint8_t *names[2] = { "r", "s" }; @@ -3885,9 +3924,6 @@ /usr/include/nettle/sexp.h:152:41: note: expected 'const char * const*' but argument is of type 'const uint8_t **' {aka 'const unsigned char **'} 152 | const char * const *keys, | ~~~~~~~~~~~~~~~~~~~~^~~~ -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o format.o format.c -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o gc.o gc.c -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o gateway.o gateway.c format.c: In function 'ssh_vformat_write': format.c:362:20: warning: pointer targets in assignment from 'const char *' to 'const uint8_t *' {aka 'const unsigned char *'} differ in signedness [-Wpointer-sign] 362 | data = va_arg(args, const char *); @@ -3901,9 +3937,12 @@ /usr/include/string.h:407:35: note: expected 'const char *' but argument is of type 'const uint8_t *' {aka 'const unsigned char *'} 407 | extern size_t strlen (const char *__s) | ~~~~~~~~~~~~^~~ +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o gateway.o gateway.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o gateway_channel.o gateway_channel.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o gateway_commands.o gateway_commands.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o handshake.o handshake.c +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o interact.o interact.c +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o io.o io.c gateway.c: In function 'make_gateway_address': gateway.c:92:20: warning: pointer targets in passing argument 1 of 'check_string' differ in signedness [-Wpointer-sign] 92 | if (check_string(local_user) @@ -3929,20 +3968,9 @@ gateway.c:51:48: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'const char *' 51 | check_string_l(unsigned length, const uint8_t *s) | ~~~~~~~~~~~~~~~^ -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o interact.o interact.c -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o io.o io.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o io_commands.o io_commands.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o keyexchange.o keyexchange.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o list.o list.c -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o lookup_verifier.o lookup_verifier.c -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o lock_file.o lock_file.c -io.c: In function 'do_buffered_read': -io.c:490:9: warning: this statement may fall through [-Wimplicit-fallthrough=] - 490 | werror("Unexpected EPIPE from read.\n"); - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -io.c:491:7: note: here - 491 | default: - | ^~~~~~~ In file included from list.c:35: list.c: In function 'lsh_list_alloc': xalloc.h:95:30: warning: statement with no effect [-Wunused-value] @@ -3951,15 +3979,22 @@ list.c:55:3: note: in expansion of macro 'CHECK_SUBTYPE' 55 | CHECK_SUBTYPE(list_header, list); | ^~~~~~~~~~~~~ +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o lookup_verifier.o lookup_verifier.c +io.c: In function 'do_buffered_read': +io.c:490:9: warning: this statement may fall through [-Wimplicit-fallthrough=] + 490 | werror("Unexpected EPIPE from read.\n"); + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +io.c:491:7: note: here + 491 | default: + | ^~~~~~~ +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o lock_file.o lock_file.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o lsh_string.o lsh_string.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o parse.o parse.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o pkcs5.o pkcs5.c -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o publickey_crypto.o publickey_crypto.c lsh_string.c: In function 'lsh_get_cstring': lsh_string.c:139:60: warning: pointer targets in returning 'const uint8_t *' {aka 'const unsigned char *'} from a function with return type 'const char *' differ in signedness [-Wpointer-sign] 139 | return (s && !memchr(s->data, '\0', s->length) ? s->data : NULL); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o queue.o queue.c lsh_string.c: In function 'lsh_string_cbc_encrypt': lsh_string.c:257:20: warning: passing argument 2 of 'nettle_cbc_encrypt' from incompatible pointer type [-Wincompatible-pointer-types] 257 | cbc_encrypt(ctx, f, block_size, iv, @@ -4037,6 +4072,8 @@ /usr/include/nettle/base64.h:107:27: note: expected 'char *' but argument is of type 'uint8_t *' {aka 'unsigned char *'} 107 | char *dst); | ~~~~~~^~~ +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o publickey_crypto.o publickey_crypto.c +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o queue.o queue.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o randomness.o randomness.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o read_data.o read_data.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o read_file.o read_file.c @@ -4045,9 +4082,6 @@ gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o reaper.o reaper.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o resource.o resource.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o rsa.o rsa.c -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o server.o server.c -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o server_authorization.o server_authorization.c -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o server_keyexchange.o server_keyexchange.c read_packet.c: In function 'do_read_packet': read_packet.c:262:24: warning: this statement may fall through [-Wimplicit-fallthrough=] 262 | closure->state = WAIT_CONTENTS; @@ -4061,13 +4095,16 @@ read_packet.c:305:7: note: here 305 | case WAIT_MAC: | ^~~~ +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o server.o server.c +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o server_authorization.o server_authorization.c +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o server_keyexchange.o server_keyexchange.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o server_password.o server_password.c +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o server_publickey.o server_publickey.c +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o server_pty.o server_pty.c server_keyexchange.c: In function 'do_handle_srp_init': server_keyexchange.c:297:29: warning: variable 'e' set but not used [-Wunused-but-set-variable] 297 | struct exception_handler *e; | ^ -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o server_publickey.o server_publickey.c -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o server_pty.o server_pty.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o server_session.o server_session.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o server_userauth.o server_userauth.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o server_x11.o server_x11.c @@ -4076,15 +4113,10 @@ gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o spki.o spki.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o srp_exchange.o srp_exchange.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o string_buffer.o string_buffer.c -srp_exchange.c: In function 'make_srp_entry': -srp_exchange.c:72:32: warning: variable 'salt' set but not used [-Wunused-but-set-variable] - 72 | const struct lsh_string *salt; - | ^~~~ spki.c: In function 'make_ssh_hostkey_tag': spki.c:76:22: warning: pointer targets in initialization of 'const uint8_t *' {aka 'const unsigned char *'} from 'const char *' differ in signedness [-Wpointer-sign] 76 | const uint8_t *s = host; | ^~~~ -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o suspend.o suspend.c spki.c: In function 'parse_pkcs5': spki.c:408:37: warning: pointer targets in initialization of 'const uint8_t *' {aka 'const unsigned char *'} from 'char *' differ in signedness [-Wpointer-sign] 408 | const uint8_t *names[2] = { "salt", "iterations" }; @@ -4094,6 +4126,10 @@ 408 | const uint8_t *names[2] = { "salt", "iterations" }; | ^~~~~~~~~~~~ spki.c:408:45: note: (near initialization for 'names[1]') +srp_exchange.c: In function 'make_srp_entry': +srp_exchange.c:72:32: warning: variable 'salt' set but not used [-Wunused-but-set-variable] + 72 | const struct lsh_string *salt; + | ^~~~ spki.c:421:43: warning: passing argument 3 of 'nettle_sexp_iterator_assoc' from incompatible pointer type [-Wincompatible-pointer-types] 421 | return (sexp_iterator_assoc(i, 2, names, values) | ^~~~~ @@ -4128,6 +4164,7 @@ /usr/include/nettle/sexp.h:152:41: note: expected 'const char * const*' but argument is of type 'const uint8_t **' {aka 'const unsigned char **'} 152 | const char * const *keys, | ~~~~~~~~~~~~~~~~~~~~^~~~ +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o suspend.o suspend.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o tcpforward.o tcpforward.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o tcpforward_commands.o tcpforward_commands.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o translate_signal.o translate_signal.c @@ -4146,7 +4183,6 @@ 392 | if (!tty_getattr(self->tty_fd, &res->ios) < 0) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ( ) -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o werror.o werror.c unix_user.c: In function 'do_verify_password': unix_user.c:255:11: warning: pointer targets in assignment from 'const char *' to 'const uint8_t *' {aka 'const unsigned char *'} differ in signedness [-Wpointer-sign] 255 | cpasswd = lsh_get_cstring(password); @@ -4163,7 +4199,10 @@ /usr/include/unistd.h:1159:33: note: expected 'const char *' but argument is of type 'const uint8_t *' {aka 'const unsigned char *'} 1159 | extern char *crypt (const char *__key, const char *__salt) | ~~~~~~~~~~~~^~~~~ +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o werror.o werror.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o write_buffer.o write_buffer.c +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o write_packet.o write_packet.c +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o xalloc.o xalloc.c werror.c: In function 'werror_cstring': werror.c:294:51: warning: pointer targets in passing argument 2 of 'werror_write' differ in signedness [-Wpointer-sign] 294 | werror_cstring(char *s) { werror_write(strlen(s), s); } @@ -4198,6 +4237,7 @@ werror.c:275:46: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'char *' 275 | werror_write(uint32_t length, const uint8_t *msg) | ~~~~~~~~~~~~~~~^~~ +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o xauth.o xauth.c werror.c:576:44: warning: pointer targets in passing argument 2 of 'werror_write' differ in signedness [-Wpointer-sign] 576 | werror_write(strlen(type), type); | ^~~~ @@ -4235,13 +4275,12 @@ werror.c:617:1: warning: 'werror_format' defined but not used [-Wunused-function] 617 | werror_format(const char *format, ...) | ^~~~~~~~~~~~~ -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o write_packet.o write_packet.c -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o xalloc.o xalloc.c -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o xauth.o xauth.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o zlib.o zlib.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o lshg.o lshg.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o dummy.o dummy.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o lsh-keygen.o lsh-keygen.c +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o lsh-writekey.o lsh-writekey.c +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o lsh-decrypt-key.o lsh-decrypt-key.c dummy.c:150:29: warning: argument 1 of type 'const __mpz_struct[1]' with mismatched bound [-Warray-parameter=] 150 | mpz_sizeinbase (const mpz_t x UNUSED, int base UNUSED) In file included from /usr/include/nettle/bignum.h:50, @@ -4254,15 +4293,11 @@ /usr/include/aarch64-linux-gnu/gmp.h:833:48: note: previously declared as 'mpz_srcptr' {aka 'const __mpz_struct *'} 833 | __GMP_DECLSPEC char *mpz_get_str (char *, int, mpz_srcptr); | ^~~~~~~~~~ -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o lsh-writekey.o lsh-writekey.c -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o lsh-decrypt-key.o lsh-decrypt-key.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o lsh-decode-key.o lsh-decode-key.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o lsh-export-key.o lsh-export-key.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o lsh-make-seed.o lsh-make-seed.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o srp-gen.o srp-gen.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o lshd.o lshd.c -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o lsh-execuv.o lsh-execuv.c -gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o lsh-krb-checkpw.o lsh-krb-checkpw.c lsh-make-seed.c: In function 'get_dev_random': lsh-make-seed.c:312:51: warning: pointer targets in passing argument 5 of 'nettle_yarrow256_update' differ in signedness [-Wpointer-sign] 312 | yarrow256_update(ctx, source, res * 4, res, buffer); @@ -4284,12 +4319,17 @@ lsh-make-seed.c:1037:23: warning: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Wsign-compare] 1037 | if (res > linux_proc_sources[i].limit) | ^ +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o lsh-execuv.o lsh-execuv.c +gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o lsh-krb-checkpw.o lsh-krb-checkpw.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o lsh-pam-checkpw.o lsh-pam-checkpw.c +rm -f liblsh.a lsh-krb-checkpw.c: In function 'main': lsh-krb-checkpw.c:98:15: warning: unused variable 'ccache' [-Wunused-variable] 98 | krb5_ccache ccache; | ^~~~~~ -rm -f liblsh.a +ar cru liblsh.a abstract_io.o abstract_crypto.o algorithms.o alist.o atoms.o channel.o channel_commands.o channel_forward.o charset.o client.o client_escape.o client_keyexchange.o client_pty.o client_session.o client_userauth.o client_x11.o combinators.o command.o compress.o parse_config.o connection.o connection_commands.o crypto.o daemon.o debug.o dh_exchange.o dsa.o exception.o format.o gc.o gateway.o gateway_channel.o gateway_commands.o handshake.o interact.o io.o io_commands.o keyexchange.o list.o lookup_verifier.o lock_file.o lsh_string.o parse.o pkcs5.o publickey_crypto.o queue.o randomness.o read_data.o read_file.o read_line.o read_packet.o reaper.o resource.o rsa.o server.o server_authorization.o server_keyexchange.o server_password.o server_publickey.o server_pty.o server_session.o server_userauth.o server_x11.o sexp.o socks.o spki.o srp_exchange.o string_buffer.o suspend.o tcpforward.o tcpforward_commands.o translate_signal.o tty.o unix_interact.o unix_process.o unix_random.o unix_user.o userauth.o werror.o write_buffer.o write_packet.o xalloc.o xauth.o zlib.o +ar: `u' modifier ignored since `D' is the default (see `U') +gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o lsh-execuv lsh-execuv.o -lpam -lutil -lcrypt -lXau -lwrap -lz -loop -lgmp lsh-krb-checkpw.c:135:7: warning: 'server' may be used uninitialized [-Wmaybe-uninitialized] 135 | if (krb5_verify_init_creds(context, &creds, server, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ @@ -4298,9 +4338,6 @@ lsh-krb-checkpw.c:101:18: note: 'server' was declared here 101 | krb5_principal server; | ^~~~~~ -ar cru liblsh.a abstract_io.o abstract_crypto.o algorithms.o alist.o atoms.o channel.o channel_commands.o channel_forward.o charset.o client.o client_escape.o client_keyexchange.o client_pty.o client_session.o client_userauth.o client_x11.o combinators.o command.o compress.o parse_config.o connection.o connection_commands.o crypto.o daemon.o debug.o dh_exchange.o dsa.o exception.o format.o gc.o gateway.o gateway_channel.o gateway_commands.o handshake.o interact.o io.o io_commands.o keyexchange.o list.o lookup_verifier.o lock_file.o lsh_string.o parse.o pkcs5.o publickey_crypto.o queue.o randomness.o read_data.o read_file.o read_line.o read_packet.o reaper.o resource.o rsa.o server.o server_authorization.o server_keyexchange.o server_password.o server_publickey.o server_pty.o server_session.o server_userauth.o server_x11.o sexp.o socks.o spki.o srp_exchange.o string_buffer.o suspend.o tcpforward.o tcpforward_commands.o translate_signal.o tty.o unix_interact.o unix_process.o unix_random.o unix_user.o userauth.o werror.o write_buffer.o write_packet.o xalloc.o xauth.o zlib.o -ar: `u' modifier ignored since `D' is the default (see `U') -gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o lsh-execuv lsh-execuv.o -lpam -lutil -lcrypt -lXau -lwrap -lz -loop -lgmp gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o lsh-krb-checkpw lsh-krb-checkpw.o -lkrb5 -lresolv -lpam -lutil -lcrypt -lXau -lwrap -lz -loop -lgmp lshd.c: In function 'main_argp_parser': lshd.c:699:17: warning: 'host' may be used uninitialized [-Wmaybe-uninitialized] @@ -4317,10 +4354,10 @@ gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o lsh-decrypt-key lsh-decrypt-key.o liblsh.a spki/libspki.a -lnettle -lhogweed -lpam -lutil -lcrypt -lXau -lwrap -lz -loop -lgmp gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o lsh-decode-key lsh-decode-key.o liblsh.a spki/libspki.a -lnettle -lhogweed -lpam -lutil -lcrypt -lXau -lwrap -lz -loop -lgmp gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o lsh-export-key lsh-export-key.o liblsh.a spki/libspki.a -lnettle -lhogweed -lpam -lutil -lcrypt -lXau -lwrap -lz -loop -lgmp +gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o lsh-make-seed lsh-make-seed.o liblsh.a spki/libspki.a -lnettle -lhogweed -lpam -lutil -lcrypt -lXau -lwrap -lz -loop -lgmp gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o srp-gen srp-gen.o liblsh.a spki/libspki.a -lnettle -lhogweed -lpam -lutil -lcrypt -lXau -lwrap -lz -loop -lgmp gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o lshd lshd.o liblsh.a spki/libspki.a -lnettle -lhogweed -lpam -lutil -lcrypt -lXau -lwrap -lz -loop -lgmp gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o lsh-pam-checkpw lsh-pam-checkpw.o liblsh.a spki/libspki.a -lnettle -lhogweed -lpam -lutil -lcrypt -lXau -lwrap -lz -loop -lgmp -gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o lsh-make-seed lsh-make-seed.o liblsh.a spki/libspki.a -lnettle -lhogweed -lpam -lutil -lcrypt -lXau -lwrap -lz -loop -lgmp make[5]: Leaving directory '/build/lsh-utils-2.1/src' Making all in testsuite make[5]: Entering directory '/build/lsh-utils-2.1/src/testsuite' @@ -4332,11 +4369,11 @@ gcc -DHAVE_CONFIG_H -I. -I../.. -I/build/lsh-utils-2.1/src/testsuite/.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o des-test.o des-test.c gcc -DHAVE_CONFIG_H -I. -I../.. -I/build/lsh-utils-2.1/src/testsuite/.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o serpent-test.o serpent-test.c gcc -DHAVE_CONFIG_H -I. -I../.. -I/build/lsh-utils-2.1/src/testsuite/.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o twofish-test.o twofish-test.c -In file included from aes-test.c:1: -aes-test.c: In function 'test_main': -aes-test.c:9:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] - 9 | H("603deb1015ca71be2b73aef0857d7781" - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +In file included from blowfish-test.c:1: +blowfish-test.c: In function 'test_main': +blowfish-test.c:7:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] + 7 | H("0123456789ABCDEF FEDCBA9876543210"), + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | char * testutils.h:63:25: note: in definition of macro 'H' @@ -4345,9 +4382,9 @@ testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' 21 | decode_hex(const unsigned char *); | ^~~~~~~~~~~~~~~~~~~~~ -aes-test.c:11:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] - 11 | H("6bc1bee22e409f96e93d7e117393172a" - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +blowfish-test.c:8:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] + 8 | H("0000000000000000 1111111111111111"), + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | char * testutils.h:63:25: note: in definition of macro 'H' @@ -4356,9 +4393,9 @@ testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' 21 | decode_hex(const unsigned char *); | ^~~~~~~~~~~~~~~~~~~~~ -aes-test.c:15:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] - 15 | H("f58c4c04d6e5f1ba779eabfb5f7bfbd6" - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +blowfish-test.c:9:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] + 9 | H("f0fb0320a19f306d ff5880191e616c10"), + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | char * testutils.h:63:25: note: in definition of macro 'H' @@ -4367,9 +4404,9 @@ testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' 21 | decode_hex(const unsigned char *); | ^~~~~~~~~~~~~~~~~~~~~ -aes-test.c:19:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] - 19 | H("000102030405060708090a0b0c0d0e0f")); - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +blowfish-test.c:10:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] + 10 | H("0011223344556677")); + | ^~~~~~~~~~~~~~~~~~ | | | char * testutils.h:63:25: note: in definition of macro 'H' @@ -4378,11 +4415,11 @@ testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' 21 | decode_hex(const unsigned char *); | ^~~~~~~~~~~~~~~~~~~~~ -In file included from blowfish-test.c:1: -blowfish-test.c: In function 'test_main': -blowfish-test.c:7:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] - 7 | H("0123456789ABCDEF FEDCBA9876543210"), - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +In file included from aes-test.c:1: +aes-test.c: In function 'test_main': +aes-test.c:9:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] + 9 | H("603deb1015ca71be2b73aef0857d7781" + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | char * testutils.h:63:25: note: in definition of macro 'H' @@ -4391,9 +4428,9 @@ testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' 21 | decode_hex(const unsigned char *); | ^~~~~~~~~~~~~~~~~~~~~ -blowfish-test.c:8:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] - 8 | H("0000000000000000 1111111111111111"), - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +aes-test.c:11:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] + 11 | H("6bc1bee22e409f96e93d7e117393172a" + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | char * testutils.h:63:25: note: in definition of macro 'H' @@ -4402,9 +4439,9 @@ testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' 21 | decode_hex(const unsigned char *); | ^~~~~~~~~~~~~~~~~~~~~ -blowfish-test.c:9:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] - 9 | H("f0fb0320a19f306d ff5880191e616c10"), - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +aes-test.c:15:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] + 15 | H("f58c4c04d6e5f1ba779eabfb5f7bfbd6" + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | char * testutils.h:63:25: note: in definition of macro 'H' @@ -4413,9 +4450,9 @@ testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' 21 | decode_hex(const unsigned char *); | ^~~~~~~~~~~~~~~~~~~~~ -blowfish-test.c:10:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] - 10 | H("0011223344556677")); - | ^~~~~~~~~~~~~~~~~~ +aes-test.c:19:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] + 19 | H("000102030405060708090a0b0c0d0e0f")); + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | char * testutils.h:63:25: note: in definition of macro 'H' @@ -4424,15 +4461,6 @@ testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' 21 | decode_hex(const unsigned char *); | ^~~~~~~~~~~~~~~~~~~~~ -testutils.c: In function 'decode_hex': -testutils.c:62:39: warning: pointer targets in passing argument 1 of 'decode_hex_length' differ in signedness [-Wpointer-sign] - 62 | uint32_t length = decode_hex_length(hex); - | ^~~ - | | - | const unsigned char * -testutils.c:39:31: note: expected 'const char *' but argument is of type 'const unsigned char *' - 39 | decode_hex_length(const char *h) - | ~~~~~~~~~~~~^ In file included from arcfour-test.c:1: arcfour-test.c: In function 'test_main': arcfour-test.c:7:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] @@ -4468,10 +4496,19 @@ testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' 21 | decode_hex(const unsigned char *); | ^~~~~~~~~~~~~~~~~~~~~ -In file included from serpent-test.c:1: -serpent-test.c: In function 'test_main': -serpent-test.c:10:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] - 10 | H("0123456789ABCDEF FEDCBA9876543210" +testutils.c: In function 'decode_hex': +testutils.c:62:39: warning: pointer targets in passing argument 1 of 'decode_hex_length' differ in signedness [-Wpointer-sign] + 62 | uint32_t length = decode_hex_length(hex); + | ^~~ + | | + | const unsigned char * +testutils.c:39:31: note: expected 'const char *' but argument is of type 'const unsigned char *' + 39 | decode_hex_length(const char *h) + | ~~~~~~~~~~~~^ +In file included from cast128-test.c:1: +cast128-test.c: In function 'test_main': +cast128-test.c:7:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] + 7 | H("0123456789ABCDEF FEDCBA9876543210"), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | char * @@ -4481,8 +4518,8 @@ testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' 21 | decode_hex(const unsigned char *); | ^~~~~~~~~~~~~~~~~~~~~ -serpent-test.c:12:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] - 12 | H("0000000000000000 0000000000000000" +cast128-test.c:8:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] + 8 | H("0000000000000000 1111111111111111"), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | char * @@ -4492,8 +4529,8 @@ testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' 21 | decode_hex(const unsigned char *); | ^~~~~~~~~~~~~~~~~~~~~ -serpent-test.c:14:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] - 14 | H("c170ed586cfda8fe 084f01ef04475883" +cast128-test.c:9:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] + 9 | H("9a1bf354bca596ad f7b2a2ce5f09a8b2"), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | char * @@ -4503,9 +4540,9 @@ testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' 21 | decode_hex(const unsigned char *); | ^~~~~~~~~~~~~~~~~~~~~ -serpent-test.c:16:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] - 16 | H("0011223344556677 8899AABBCCDDEEFF")); - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +cast128-test.c:10:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] + 10 | H("0011223344556677")); + | ^~~~~~~~~~~~~~~~~~ | | | char * testutils.h:63:25: note: in definition of macro 'H' @@ -4514,8 +4551,6 @@ testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' 21 | decode_hex(const unsigned char *); | ^~~~~~~~~~~~~~~~~~~~~ -In file included from cast128-test.c:1: -cast128-test.c: In function 'test_main': In file included from des-test.c:1: des-test.c: In function 'test_main': des-test.c:7:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] @@ -4562,8 +4597,10 @@ testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' 21 | decode_hex(const unsigned char *); | ^~~~~~~~~~~~~~~~~~~~~ -cast128-test.c:7:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] - 7 | H("0123456789ABCDEF FEDCBA9876543210"), +In file included from serpent-test.c:1: +serpent-test.c: In function 'test_main': +serpent-test.c:10:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] + 10 | H("0123456789ABCDEF FEDCBA9876543210" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | char * @@ -4573,8 +4610,8 @@ testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' 21 | decode_hex(const unsigned char *); | ^~~~~~~~~~~~~~~~~~~~~ -cast128-test.c:8:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] - 8 | H("0000000000000000 1111111111111111"), +serpent-test.c:12:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] + 12 | H("0000000000000000 0000000000000000" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | char * @@ -4584,8 +4621,8 @@ testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' 21 | decode_hex(const unsigned char *); | ^~~~~~~~~~~~~~~~~~~~~ -cast128-test.c:9:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] - 9 | H("9a1bf354bca596ad f7b2a2ce5f09a8b2"), +serpent-test.c:14:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] + 14 | H("c170ed586cfda8fe 084f01ef04475883" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | char * @@ -4595,9 +4632,9 @@ testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' 21 | decode_hex(const unsigned char *); | ^~~~~~~~~~~~~~~~~~~~~ -cast128-test.c:10:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] - 10 | H("0011223344556677")); - | ^~~~~~~~~~~~~~~~~~ +serpent-test.c:16:17: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] + 16 | H("0011223344556677 8899AABBCCDDEEFF")); + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | char * testutils.h:63:25: note: in definition of macro 'H' @@ -4903,6 +4940,41 @@ testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' 21 | decode_hex(const unsigned char *); | ^~~~~~~~~~~~~~~~~~~~~ +In file included from string-test.c:1: +string-test.c: In function 'test_main': +string-test.c:14:9: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] + 14 | s = H("66006f"); + | ^~~~~~~~ + | | + | char * +testutils.h:63:25: note: in definition of macro 'H' + 63 | #define H(x) decode_hex(x) + | ^ +testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' + 21 | decode_hex(const unsigned char *); + | ^~~~~~~~~~~~~~~~~~~~~ +string-test.c:17:9: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] + 17 | s = H("6600"); + | ^~~~~~ + | | + | char * +testutils.h:63:25: note: in definition of macro 'H' + 63 | #define H(x) decode_hex(x) + | ^ +testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' + 21 | decode_hex(const unsigned char *); + | ^~~~~~~~~~~~~~~~~~~~~ +string-test.c:20:9: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] + 20 | s = H(""); + | ^~ + | | + | char * +testutils.h:63:25: note: in definition of macro 'H' + 63 | #define H(x) decode_hex(x) + | ^ +testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' + 21 | decode_hex(const unsigned char *); + | ^~~~~~~~~~~~~~~~~~~~~ In file included from sha1-test.c:1: sha1-test.c: In function 'test_main': sha1-test.c:11:15: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] @@ -5136,41 +5208,7 @@ testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' 21 | decode_hex(const unsigned char *); | ^~~~~~~~~~~~~~~~~~~~~ -In file included from string-test.c:1: -string-test.c: In function 'test_main': -string-test.c:14:9: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] - 14 | s = H("66006f"); - | ^~~~~~~~ - | | - | char * -testutils.h:63:25: note: in definition of macro 'H' - 63 | #define H(x) decode_hex(x) - | ^ -testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' - 21 | decode_hex(const unsigned char *); - | ^~~~~~~~~~~~~~~~~~~~~ -string-test.c:17:9: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] - 17 | s = H("6600"); - | ^~~~~~ - | | - | char * -testutils.h:63:25: note: in definition of macro 'H' - 63 | #define H(x) decode_hex(x) - | ^ -testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' - 21 | decode_hex(const unsigned char *); - | ^~~~~~~~~~~~~~~~~~~~~ -string-test.c:20:9: warning: pointer targets in passing argument 1 of 'decode_hex' differ in signedness [-Wpointer-sign] - 20 | s = H(""); - | ^~ - | | - | char * -testutils.h:63:25: note: in definition of macro 'H' - 63 | #define H(x) decode_hex(x) - | ^ -testutils.h:21:12: note: expected 'const unsigned char *' but argument is of type 'char *' - 21 | decode_hex(const unsigned char *); - | ^~~~~~~~~~~~~~~~~~~~~ +gcc -DHAVE_CONFIG_H -I. -I../.. -I/build/lsh-utils-2.1/src/testsuite/.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o sockaddr2info-test.o sockaddr2info-test.c parse-config-test.c: In function 'test_main': parse-config-test.c:100:48: warning: pointer targets in passing argument 2 of 'config_parse_string' differ in signedness [-Wpointer-sign] 100 | = config_parse_string(strlen(config_file), config_file); @@ -5181,14 +5219,13 @@ /build/lsh-utils-2.1/src/testsuite/../parse_config.h:36:53: note: expected 'const uint8_t *' {aka 'const unsigned char *'} but argument is of type 'const char *' 36 | config_parse_string(uint32_t length, const uint8_t *data); | ~~~~~~~~~~~~~~~^~~~ -gcc -DHAVE_CONFIG_H -I. -I../.. -I/build/lsh-utils-2.1/src/testsuite/.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o sockaddr2info-test.o sockaddr2info-test.c gcc -DHAVE_CONFIG_H -I. -I../.. -I/build/lsh-utils-2.1/src/testsuite/.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o utf8-test.o utf8-test.c gcc -DHAVE_CONFIG_H -I. -I../.. -I/build/lsh-utils-2.1/src/testsuite/.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o mini-inetd.o mini-inetd.c gcc -DHAVE_CONFIG_H -I. -I../.. -I/build/lsh-utils-2.1/src/testsuite/.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -c -o tcpconnect.o tcpconnect.c gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o arcfour-test arcfour-test.o testutils.o ../liblsh.a ../spki/libspki.a -lnettle -lhogweed -lpam -lutil -lcrypt -lXau -lwrap -lz -loop -lgmp gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o aes-test aes-test.o testutils.o ../liblsh.a ../spki/libspki.a -lnettle -lhogweed -lpam -lutil -lcrypt -lXau -lwrap -lz -loop -lgmp -gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o cast128-test cast128-test.o testutils.o ../liblsh.a ../spki/libspki.a -lnettle -lhogweed -lpam -lutil -lcrypt -lXau -lwrap -lz -loop -lgmp gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o blowfish-test blowfish-test.o testutils.o ../liblsh.a ../spki/libspki.a -lnettle -lhogweed -lpam -lutil -lcrypt -lXau -lwrap -lz -loop -lgmp +gcc -g -O2 -ffile-prefix-map=/build/lsh-utils-2.1=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb3 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -Wl,-z,defs -Wl,--as-needed -Wl,-z,relro -o cast128-test cast128-test.o testutils.o ../liblsh.a ../spki/libspki.a -lnettle -lhogweed -lpam -lutil -lcrypt -lXau -lwrap -lz -loop -lgmp In file included from sockaddr2info-test.c:1: sockaddr2info-test.c: In function 'test_ip_v4': sockaddr2info-test.c:19:50: warning: pointer targets in passing argument 3 of 'lsh_string_eq_l' differ in signedness [-Wpointer-sign] @@ -5429,39 +5466,38 @@ PASS: conv-3 PASS: export-1 Testing lsh-keygen DSA key generation -xxxxxxxxxqpg(private-key (dsa (p |AIQX0A4ahtz37aVwxcP5SrpiiuK29rND3nkTDnDtZSXKOb4APd - Qhjltitavp+lwMWYTZzldsAU81d147zx9lZJmZsohY7lGUKGN6 - +d4kVExL|) - (q |ALFt8zCqBOosLzkxlKQt5FzixLlr|) - (g |ECsyI3440T+2pPz9lzDSnoQjyjp8a4P1LxS5+Io5XYRS5x9l/X - tMGdAYpFR41QQxnJ5cFxXFi+sR0Md0nuwcyZWjffOduR00MwwQ - oBytLC8=|) - (y |HMi/DLA6+O/JZ/uS7/u0THz847cjaSTlE9cyzSU6bRcTelzDKP - TFfUOWybY7A4m0366x+kof8ncNvAbzT9fqWvAs4/35bIFfb5bC - lsoqHeM=|) - (x |FnNu6cv0miohxd4tISj5m4E/70g=|))) +xxxxxxxxxqpg(private-key (dsa (p |AJtQ5k+UTUsBIf3YVSB6820mf0bgAWijLfXja5xtC3+VarG6YF + fpsEw5dzv17/6tt00BcbGL5y9kFbsQ5lRonCFAReBu5w8YGK2I + R2I81opT|) + (q |ALJoqrb5xVNmti05rS3Pewqc+Jo/|) + (g |AIFBCGFwWkzvL63CfR0zduAuMmFrTJ/IYV6zV8T8GbgFOpC+A8 + wPw2PQVSakX1fbepWZCxTvlCKCO4upZTLdCX9aMGcMlEKJ2gb6 + HPc96qfp|) + (y |f0i/twY12C3zV9xGkJN08ClgmCt3RtoFGrB44bNuD54etHyiw9 + JbNQToIjB4GkOmMlePQIl8t2tRORdlM+0EdKGBwjOBn9ioadzn + 7e/qdYs=|) + (x |eDAiPu5L3vQNRfEENppTVxWO34w=|))) PASS: keygen-1 Testing lsh-keygen RSA key generation xxxxx xxxxx - -(private-key (rsa-pkcs1 (n |AYG6Ecw0YjHFvQjAuSWACbhRO75ybJ0DqHekphXf1SHI - Gw/zNMEWwMpUCQC1EcQKgH5c526zg6ovqhOel+Y4luGA - G04ql1opSUahf5F67rUatPHGUvPy9NzQBsOweJT5oMU=|) - (e |PEf40w==|) - (d |AWo33gLYNFI0+xAKep2gfMNKdI71UnskTo02pMRwKxfD - nI6R6wITigW6NiIF+DYTa11PFczlHzy+JuGet/tpbmf+ - WxgPwO03MgpxtE0g+0N9TmFRHkZNrZCeEYI/KSsXt9s=|) - (p |H4/v2LiITQO4lYUUUHbG15O0tPfhXvNHQ+Rx8KG8ukJG - roDJ+d1fVrJ8hPTVaIq5lQ==|) - (q |DDic3rvutWZIe0Z/eoZiQ7ZqaYZnevUhlE/UtprP3HqI - aMok5KH/aE8sZ6TSVPVecQ==|) - (a |FxtfP36OqjpLm9bLvLic/oT7uu90Yib0652pZp42omxm - qrIXymIY+1XrmGydhv+fFw==|) - (b |BSB+o8VC81SV/BIsy5nxcaw+sCWlS3ANa0gjT2T1Hn8g - 5ZFlV928QErCV7PiuhmgOw==|) - (c |Crtn9UlOw11U3mOEjXBJYTRtxVeOTglm3QFvfcDdAtDF - H6IMk9N9OkrlZ9jmnhpQhw==|))) +(private-key (rsa-pkcs1 (n |AWfiavCOe1S3p12yH5IvTL69dJuhSwv4oB2WdsVIazmz + /grMV5HopYu8MJaqLlBd2y4pZG4PLJGny7XHtWIqWYma + OEGL0lILLkSRbWOcSC+b7fwgsv230hdH02v0ut0jpSE=|) + (e |OgJVPQ==|) + (d |AWJE3znLScGOIAtmnCXPtTuDbpEGpz6S+RE8dDjgpB4Y + RFItShxskOm07sEN1o5YB4t7WNs9ClDxy1neyKk2MP4h + RAFstRWnJchXBBG4LcQH61vP/itazHKER90Rssx4rrE=|) + (p |HC7rAs5H230Ynqejq450ji+P9ltP1/2fFcF3rZG3GzhS + UEOY/CZa2qvzLvc19UJbvw==|) + (q |DMT5nJ+JKdKgyIQMTpwXW8rCAOXu/LHAycWFuZ5WZkg9 + kCkKcVjJ+DI/Uvl+yru3Hw==|) + (a |EewrPvDc92Er/jot43hfjfX82EHGtpXs6jKJs6TnL2jN + B3uaFJwWl91pR3Ywz0Ao6w==|) + (b |BvN8xJTpkm4THkJW1vgQyaodTduLXRXFgMeqwPZLb4KS + 4DVlPgj8jQST44CCKFvU/w==|) + (c |B19vzruYxxFI3ko1b8HRXOFUS6f8WE+TuMggo7Ml8P9S + UrcTRlvO7O7TMu8T28qN/w==|))) PASS: keygen-2 Testing lsh-writekey PASS: write-key-1 @@ -5471,25 +5507,25 @@ test-seed-1 test-seed-2 differ: char 1, line 1 PASS: seed lsh, test 1 -lshd pid: 21243 +lshd pid: 1885 PASS: lsh-1 lsh, test 2 -lshd pid: 23842 +lshd pid: 2153 Hello world. PASS: lsh-2 lsh, test 3 -lshd pid: 25587 +lshd pid: 2213 Hello world. PASS: lsh-3 lsh, test 4 -lshd pid: 26819 +lshd pid: 2453 Hello world PASS: lsh-4 lsh, test 5, using an RSA hostkey -lshd pid: 28362 +lshd pid: 2778 PASS: lsh-5 lsh, test 6, using various encryption algorithms -lshd pid: 29606 +lshd pid: 3018 Trying encryption flag arcfour Ok Trying encryption flag twofish @@ -5510,62 +5546,59 @@ Ok PASS: lsh-6 lsh, test 7 -lshd pid: 31136 +lshd pid: 3590 PASS: lsh-7 lsh, test 8, unencrypted session -lshd pid: 32672 +lshd pid: 4061 PASS: lsh-8 lsh, test 9, check that LSHFLAGS works. -lshd pid: 1603 +lshd pid: 4500 PASS: lsh-9 lsh, encrypted key test xxxxxx xxxxxx -lshd pid: 2401 +lshd pid: 6133 Hello world PASS: lsh-encrypted-key lsh-decrypt-key-test xxxxxx xxxxxx - PASS: lsh-decrypt-key lsh, cat test -lshd pid: 3430 +lshd pid: 6463 lsh-cat-test: Ok, files match. PASS: lsh-cat lshg test 1 -lshd pid: 3849 +lshd pid: 6670 PASS: lshg-1 lshg, cat test -lshd pid: 4856 +lshd pid: 7007 lshg-cat-test: Ok, files match. PASS: lshg-cat lshg, cat 2 test -lshd pid: 5871 +lshd pid: 7284 lshg-cat-2-test: Ok, files match. PASS: lshg-cat-2 Closed spurious fd 9 -lshd pid: 8267 +lshd pid: 7879 daemon-fd-test: Ok, files match. PASS: daemon-fd -lshd pid: 12682 +lshd pid: 8168 foo PASS: tcpip-local -lshd pid: 16292 +lshd pid: 8635 bar PASS: tcpip-local-in-use -lshd pid: 20704 +lshd pid: 9005 foo PASS: tcpip-remote SKIP: socks5 SKIP: socks4 -lshd pid: 1259 +lshd pid: 10334 foo -./lshg-tcpip-local-test: 1: kill: No such process - PASS: lshg-tcpip-local testing lcp -lshd pid: 3770 +lshd pid: 10400 bash: line 1: files/lcp-file-1.txt: cannot overwrite existing file bash: line 1: files/lcp-file-1.txt: cannot overwrite existing file /build/lsh-utils-2.1/src/testsuite/../lcp: line 116: ./lcp-file-1.txt: cannot overwrite existing file @@ -6242,7 +6275,7 @@ Test done PASS: rapid7-lsh Testing lshd -lshd pid: 14314 +lshd pid: 15332 Testing /build/lsh-utils-2.1/src/testsuite/rapid7-ssh-pdu/0000001.pdu Testing /build/lsh-utils-2.1/src/testsuite/rapid7-ssh-pdu/0000002.pdu Testing /build/lsh-utils-2.1/src/testsuite/rapid7-ssh-pdu/0000003.pdu @@ -6912,7 +6945,7 @@ Test done PASS: rapid7-lshd lsh, test login, login-auth-mode -lshd pid: 18492 +lshd pid: 17019 lsh-login-test: Ok, files match. PASS: login-auth lshd, no-auth-test @@ -6920,7 +6953,7 @@ Try `lshd --help' or `lshd --usage' for more information. PASS: lshd-no-auth Testing lshd with random input -lshd pid: 20263 +lshd pid: 17607 Trying seed 1 Trying seed 2 Trying seed 3 @@ -7134,8 +7167,8 @@ dh_md5sums -a dh_builddeb -a dpkg-deb: building package 'lsh-utils' in '../lsh-utils_2.1-13_arm64.deb'. -dpkg-deb: building package 'lsh-client-dbgsym' in '../lsh-client-dbgsym_2.1-13_arm64.deb'. dpkg-deb: building package 'lsh-utils-dbgsym' in '../lsh-utils-dbgsym_2.1-13_arm64.deb'. +dpkg-deb: building package 'lsh-client-dbgsym' in '../lsh-client-dbgsym_2.1-13_arm64.deb'. dpkg-deb: building package 'lsh-server-dbgsym' in '../lsh-server-dbgsym_2.1-13_arm64.deb'. dpkg-deb: building package 'lsh-client' in '../lsh-client_2.1-13_arm64.deb'. dpkg-deb: building package 'lsh-server' in '../lsh-server_2.1-13_arm64.deb'. @@ -7171,12 +7204,14 @@ dpkg-buildpackage: info: binary-only upload (no source included) dpkg-genchanges: info: not including original source code in upload I: copying local configuration +I: user script /srv/workspace/pbuilder/17044/tmp/hooks/B01_cleanup starting +I: user script /srv/workspace/pbuilder/17044/tmp/hooks/B01_cleanup finished I: unmounting dev/ptmx filesystem I: unmounting dev/pts filesystem I: unmounting dev/shm filesystem I: unmounting proc filesystem I: unmounting sys filesystem I: cleaning the build env -I: removing directory /srv/workspace/pbuilder/15113 and its subdirectories -I: Current time: Tue Jun 6 17:13:43 -12 2023 -I: pbuilder-time-stamp: 1686114823 +I: removing directory /srv/workspace/pbuilder/17044 and its subdirectories +I: Current time: Wed Jul 10 01:43:31 +14 2024 +I: pbuilder-time-stamp: 1720525411