![\"doxygen\"/](\"doxygen.svg\")
why not BlasMatrixDomain ?
\n-necessitates the inclusion of those things after of before. We should not include directly this but just the matrices and they automatically need their domain (for now)
\n+necessitates the inclusion of those things after of before. We should not include directly this but just the matrices and they automatically need their domain (for now)
\n+why not BlasMatrixDomain ?
\nit is dangerous to include matrices defs that include hom for their rebind...
\n+it is dangerous to include matrices defs that include hom for their rebind...
\n+\nshould try a modular minpoly and decide on the degree of that...
\n+\n+this does not seem right for float or any non M/modular field: doing blas wherever we have a fflas-ffpack field (?)
\nshould return true for some Givaro::ZRing
\nmatrix/random-matrix.h occasionnnaly there is a \"SIGFPE, Arithmetic exception.\" in CRA
\ntestRandomCharpoly is not always tested !!
\nftrmm fails on non-double transposed versions.
\nis fgemm correct on null A and B ?
\nmatrix/random-matrix.h if beta != 0 but A and B are 0 (or don't exist) then C != beta C
\n+if beta != 0 but A and B are 0 (or don't exist) then C != beta C
\n+\n 1.9.1\n \n", "details": [{"source1": "html2text {}", "source2": "html2text {}", "unified_diff": "@@ -10,18 +10,18 @@\n Global BlackboxContainerBase<_Field,_Blackbox_>::BlackboxContainerBase (const\n Blackbox *BB, const Field &F, size_t Size)\n no need for F\n Global BlackboxContainerBase<_Field,_Blackbox_>::BlackboxContainerBase (const\n Blackbox *BB, const Field &F)\n no need for F\n Class BlasMatrix<__Field,__Storage_>\n- why not BlasMatrixDomain ?\n necessitates the inclusion of those things after of before. We should not\n include directly this but just the matrices and they automatically need\n their domain (for now)\n+ why not BlasMatrixDomain ?\n Global BlasMatrix<__Field,__Storage_>::_MD\n why public ?\n Global BlasMatrix<__Field,__Storage_>::_ptr\n why public ?\n Global BlasMatrix<__Field,__Storage_>::_VD\n why public ?\n Global BlasMatrix<__Field,__Storage_>::operator[] (size_t i)\n@@ -51,20 +51,20 @@\n &x) const\n use Matrix domain\n Global BlasSubmatrix<__Matrix_>::BlasSubmatrix (constMatrixType &M, size_t\n rowbeg, size_t colbeg, size_t Rowdim, size_t Coldim)\n NOT HERE\n Global BlasSubmatrix<__Matrix_>::read (std::istream &file)\n reading a submatrix should not be allowed !!\n- Global CRABuilderEarlyMultip<_Domain_Type_>::dot (Integer &z, const Integer\n- &D, const Vect1 &v1, const Vect2 &v2)\n- why a dot product here ?\n Global CRABuilderEarlyMultip<_Domain_Type_>::dot (DomainElement &z, const\n Domain &D, const Vect1 &v1, const Vect2 &v2)\n why a dot product here ?\n+ Global CRABuilderEarlyMultip<_Domain_Type_>::dot (Integer &z, const Integer\n+ &D, const Vect1 &v1, const Vect2 &v2)\n+ why a dot product here ?\n Global distinct (I1 a, I1 b, Lp &c)\n this already exists elsewhere\n this already exists elsewhere\n Global field_subtests::testRingTrivia (const Field &F, const char *name)\n BlockRing does not know about 0 and 1 !\n Global FieldArchetype::constructor (FieldAbstract *trait, Field_qcq\n *field_ptr)\n@@ -74,44 +74,42 @@\n non reentrant strtok\n Class indexDomain\n does not belong here\n Class IndexedCategory<_BlasMatrix<_Field,__Rep_>_>\n this is trait, not a Category\n Namespace LinBox\n those are not just traits:\n- this does not belong here.\n it is dangerous to include matrices defs that include hom for their\n rebind...\n+ this does not belong here.\n Global LinBox::checkBlasPrime (const Prime p)\n why is this hard coded ?\n Global LinBox::CheckRank (const Field &F, const typename Field ::Element *A,\n const size_t &m, const size_t &n, const size_t &lda, const size_t\n &alledged_rank)\n not used\n Global LinBox::isPositiveDefinite (const Blackbox &A, const RingCategories::\n IntegerTag &tag, const Method::Auto &M)\n should try a modular minpoly and decide on the degree of that...\n+ this crude size check can be refined\n Global LinBox::isPositiveDefinite (const Blackbox &A, const RingCategories::\n IntegerTag &tag, const Method::DenseElimination &M)\n why map (same field)? This is a copy.\n- Global LinBox::isPositiveDefinite (const Blackbox &A, const RingCategories::\n- IntegerTag &tag, const Method::Auto &M)\n- this crude size check can be refined\n Global LinBox::Protected::checkBlasApply (const Field &F, size_t n)\n this does not seem right for float or any non M/modular field: doing blas\n wherever we have a fflas-ffpack field (?)\n should return true for some Givaro::ZRing\n Global LinBox::Protected::Identity (const Field &F, typename Field::Element\n *Id, const size_t ldI, const size_t lig1, const size_t col1, const size_t\n lig2, const size_t col2)\n long et size_t ne cohabitent pas bien.\n Global LinBox::Protected::random_rankupdate (Field &F, const Randiter &R,\n BlasMatrix<_Field_> &A, int &rank, const RingCategories::IntegerTag &tag)\n- do perms ?\n const !\n+ do perms ?\n Global LinBox::randomAns (const Ring &R, Matrix &Mat, size_t n, size_t epr)\n use BlasVector.\n Global LinBox::RandomMatrixWithDet (const Field &F, typename Field ::Element\n *A, const size_t &m, const size_t &lda, const typename Field ::Element &det)\n not used\n Global LinBox::rank (size_t &r, const Blackbox &A, const RingCategories::\n ModularTag &tag, const Method::Auto &m)\n@@ -180,14 +178,16 @@\n Global OpenCLMatrixDomain<_Field__>::isZero (const Matrix1 &A)\n use refs\n Class PLUQMatrix<_Field_>\n Should really be tempalted by Matrix and be a (sub)domain\n Global PLUQMatrix<_Field_>::PLUQMatrix (BlasMatrix< Field, _Rep > &A,\n BlasPermutation<_size_t_> &P, BlasPermutation<_size_t_> &Q)\n in place ?\n+ Global printPolynomial (const Field &F, const Polynomial &v)\n+ this should be elsewhere\n File rational-reconstruction.h\n there seems to be a confusion between Ring _r, [iI]nteger... Besides we\n have to check that Ring/Integer/NTL_ZZ are the 'same'.\n Global ScalarMatrix<_Field__>::ScalarMatrix ()\n this should not be allowed (unknown field)\n Global SparseMatrix<__Field,_SparseMatrixFormat::COO_>::SparseMatrix (const\n _Field &F, VectStream &stream)\n@@ -205,49 +205,47 @@\n &out) const\n we should not support too many formats\n Global SparseMatrixGeneric<__Field,__Row,_Trait_>::size () const\n should it be elements or non zero elements ?\n Global SparseMatrixWriteHelper<_Matrix_>::write (const Matrix &A, std::\n ostream &os, Tag::FileFormat format)\n this is reall the \"generic\" one\n+ File test-charpoly.C\n+ occasionnnaly there is a \"SIGFPE, Arithmetic exception.\" in CRA\n+ testRandomCharpoly is not always tested !!\n File test-commentator.C\n this test does not even test if anything is outputted (and it passes even\n though)\n+ File test-ffpack.C\n+ this file does not compile or the test fails for some fields.\n+ File test-ftrmm.C\n+ ftrmm fails on non-double transposed versions.\n+ is fgemm correct on null A and B ?\n File test-matrix-stream.C\n this tests reveals memory leaks\n File test-matrix-utils.h\n put in matrix/random-matrix.h\n File test-smith-form.C\n should work for NTL Integers too\n+ Global test_fgemm (std::ostream &report, const Field &F)\n+ if beta != 0 but A and B are 0 (or don't exist) then C != beta C\n+ needs p prime.\n+ Global test_ftrmm (std::ostream &report, const Field &F)\n+ same code as above ?\n+ same code as above ?\n+ same code as above ?\n+ same code as above ?\n+ same code as above ?\n+ same code as above ?\n Global test_full_multip_matrix (std::ostream &report, size_t PrimeSize,\n size_t Size, std::pair< size_t, size_t > dims)\n it is not possible to allocate some memory and use submatrices ?\n Global Toeplitz<_typename__PRing::CoeffField,__PRing_>::write (std::ostream\n &os=std::cout) const\n this is not MM format at all\n Class Transpose<_Blackbox_>\n no write here. test-blackbox.h requires it\n Class ZOQuad<__Field_>\n needs read for test-blackbox.h\n- Global printPolynomial (const Field &F, const Polynomial &v)\n- this should be elsewhere\n- File test-charpoly.C\n- occasionnnaly there is a \"SIGFPE, Arithmetic exception.\" in CRA\n- testRandomCharpoly is not always tested !!\n- File test-ffpack.C\n- this file does not compile or the test fails for some fields.\n- File test-ftrmm.C\n- ftrmm fails on non-double transposed versions.\n- is fgemm correct on null A and B ?\n- Global test_fgemm (std::ostream &report, const Field &F)\n- needs p prime.\n- if beta != 0 but A and B are 0 (or don't exist) then C != beta C\n- Global test_ftrmm (std::ostream &report, const Field &F)\n- same code as above ?\n- same code as above ?\n- same code as above ?\n- same code as above ?\n- same code as above ?\n- same code as above ?\n \n ===============================================================================\n Generated on Sun May 9 2021 16:28:04 for linbox by\u00a0[doxygen] 1.9.1\n"}]}, {"source1": "./usr/share/doc/liblinbox-dev/test.html", "source2": "./usr/share/doc/liblinbox-dev/test.html", "comments": ["Ordering differences only"], "unified_diff": "@@ -211,44 +211,44 @@\n This will avoid copy back/forth a BlasMatrix<Givaro::ZRing<Integer> >
\n \n: L = [[L1,0],[A,L2]] ;U = [[U1,B],[0,U2]] ; LU = [[ rec(L1,U1), ftrmm(L1,B)],[ftrmm(A,U1),fgemm(A,B)+rec(L2,U2) ]] de m\u00eame UL
\n-\n+RandomPermutation avec P de type [Matrix-Blas]Permutation
\n+: L = [[L1,0],[A,L2]] ;U = [[U1,B],[0,U2]] ; LU = [[ rec(L1,U1), ftrmm(L1,B)],[ftrmm(A,U1),fgemm(A,B)+rec(L2,U2) ]] de m\u00eame UL
\ncreate BMD.applyP(A,P,Tag::Left) ; avec P : BlasPermutation ou P : MatrixPermutation
\nBlasPermutation a un ordre p et une taille r distinctes !!!
make depend on PlotStyle (that owns data)
\n-use getUsingSeries in latex/html/csv/xml
\n+use getUsingSeries in latex/html/csv/xml
\n+make depend on PlotStyle (that owns data)
\nsetUsingSeries(const svector_t &)
\nAllow for 'speed up against col X' style
\nmake depend on PlotData
\n